From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>,
Kalle Valo <kvalo@codeaurora.org>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1()
Date: Wed, 25 Feb 2015 16:34:06 +0000 [thread overview]
Message-ID: <54EDF97E.3060507@lwfinger.net> (raw)
In-Reply-To: <20150225132451.GL19745@mwanda>
On 02/25/2015 07:24 AM, Dan Carpenter wrote:
>>From the indenting, it seems like the READ_NEXT_PAIR() was supposed to
> be inside the while loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> index 3f6c59c..a2bb02c 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> @@ -452,9 +452,10 @@ static void handle_branch1(struct ieee80211_hw *hw, u16 arraylen,
> READ_NEXT_PAIR(v1, v2, i);
> while (v2 != 0xDEAD &&
> v2 != 0xCDEF &&
> - v2 != 0xCDCD && i < arraylen - 2)
> + v2 != 0xCDCD && i < arraylen - 2) {
> _rtl8188e_config_bb_reg(hw, v1, v2);
> READ_NEXT_PAIR(v1, v2, i);
> + }
>
> while (v2 != 0xDEAD && i < arraylen - 2)
> READ_NEXT_PAIR(v1, v2, i);
>
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>,
Kalle Valo <kvalo@codeaurora.org>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1()
Date: Wed, 25 Feb 2015 10:34:06 -0600 [thread overview]
Message-ID: <54EDF97E.3060507@lwfinger.net> (raw)
In-Reply-To: <20150225132451.GL19745@mwanda>
On 02/25/2015 07:24 AM, Dan Carpenter wrote:
>>From the indenting, it seems like the READ_NEXT_PAIR() was supposed to
> be inside the while loop.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> index 3f6c59c..a2bb02c 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/phy.c
> @@ -452,9 +452,10 @@ static void handle_branch1(struct ieee80211_hw *hw, u16 arraylen,
> READ_NEXT_PAIR(v1, v2, i);
> while (v2 != 0xDEAD &&
> v2 != 0xCDEF &&
> - v2 != 0xCDCD && i < arraylen - 2)
> + v2 != 0xCDCD && i < arraylen - 2) {
> _rtl8188e_config_bb_reg(hw, v1, v2);
> READ_NEXT_PAIR(v1, v2, i);
> + }
>
> while (v2 != 0xDEAD && i < arraylen - 2)
> READ_NEXT_PAIR(v1, v2, i);
>
next prev parent reply other threads:[~2015-02-25 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:24 [patch] rtlwifi: rtl8188ee: missing curly braces in handle_branch1() Dan Carpenter
2015-02-25 13:24 ` Dan Carpenter
2015-02-25 16:34 ` Larry Finger [this message]
2015-02-25 16:34 ` Larry Finger
2015-03-03 13:42 ` Kalle Valo
2015-03-03 13:42 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EDF97E.3060507@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.