From: Stephen Warren <swarren@wwwdotorg.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: kexec: Relax SMP validation to improve DT compatibility
Date: Thu, 26 Feb 2015 17:21:19 +0000 [thread overview]
Message-ID: <54EF560F.3070805@wwwdotorg.org> (raw)
In-Reply-To: <1424947028-7438-1-git-send-email-geert+renesas@glider.be>
On 02/26/2015 03:37 AM, Geert Uytterhoeven wrote:
> When trying to kexec into a new kernel on a platform where multiple CPU
> cores are present, but no SMP bringup code is available yet, the
> kexec_load system call fails with:
>
> kexec_load failed: Invalid argument
>
> The SMP test added to machine_kexec_prepare() in commit 2103f6cba61a8b8b
> ("ARM: 7807/1: kexec: validate CPU hotplug support") wants to prohibit
> kexec on SMP platforms where it cannot disable secondary CPUs.
> However, this test is too strict: if the secondary CPUs couldn't be
> enabled in the first place, there's no need to disable them later at
> kexec time. Hence skip the test in the absence of SMP bringup code.
>
> This allows to add all CPU cores to the DTS from the beginning, without
> having to implement SMP bringup first, improving DT compatibility.
Acked-by: Stephen Warren <swarren@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kexec: Relax SMP validation to improve DT compatibility
Date: Thu, 26 Feb 2015 10:21:19 -0700 [thread overview]
Message-ID: <54EF560F.3070805@wwwdotorg.org> (raw)
In-Reply-To: <1424947028-7438-1-git-send-email-geert+renesas@glider.be>
On 02/26/2015 03:37 AM, Geert Uytterhoeven wrote:
> When trying to kexec into a new kernel on a platform where multiple CPU
> cores are present, but no SMP bringup code is available yet, the
> kexec_load system call fails with:
>
> kexec_load failed: Invalid argument
>
> The SMP test added to machine_kexec_prepare() in commit 2103f6cba61a8b8b
> ("ARM: 7807/1: kexec: validate CPU hotplug support") wants to prohibit
> kexec on SMP platforms where it cannot disable secondary CPUs.
> However, this test is too strict: if the secondary CPUs couldn't be
> enabled in the first place, there's no need to disable them later at
> kexec time. Hence skip the test in the absence of SMP bringup code.
>
> This allows to add all CPU cores to the DTS from the beginning, without
> having to implement SMP bringup first, improving DT compatibility.
Acked-by: Stephen Warren <swarren@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Russell King <linux@arm.linux.org.uk>,
Magnus Damm <magnus.damm@gmail.com>,
Stephen Warren <swarren@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: kexec: Relax SMP validation to improve DT compatibility
Date: Thu, 26 Feb 2015 10:21:19 -0700 [thread overview]
Message-ID: <54EF560F.3070805@wwwdotorg.org> (raw)
In-Reply-To: <1424947028-7438-1-git-send-email-geert+renesas@glider.be>
On 02/26/2015 03:37 AM, Geert Uytterhoeven wrote:
> When trying to kexec into a new kernel on a platform where multiple CPU
> cores are present, but no SMP bringup code is available yet, the
> kexec_load system call fails with:
>
> kexec_load failed: Invalid argument
>
> The SMP test added to machine_kexec_prepare() in commit 2103f6cba61a8b8b
> ("ARM: 7807/1: kexec: validate CPU hotplug support") wants to prohibit
> kexec on SMP platforms where it cannot disable secondary CPUs.
> However, this test is too strict: if the secondary CPUs couldn't be
> enabled in the first place, there's no need to disable them later at
> kexec time. Hence skip the test in the absence of SMP bringup code.
>
> This allows to add all CPU cores to the DTS from the beginning, without
> having to implement SMP bringup first, improving DT compatibility.
Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2015-02-26 17:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 10:37 [PATCH] ARM: kexec: Relax SMP validation to improve DT compatibility Geert Uytterhoeven
2015-02-26 10:37 ` Geert Uytterhoeven
2015-02-26 10:37 ` Geert Uytterhoeven
2015-02-26 17:21 ` Stephen Warren [this message]
2015-02-26 17:21 ` Stephen Warren
2015-02-26 17:21 ` Stephen Warren
2015-02-26 17:42 ` Russell King - ARM Linux
2015-02-26 17:42 ` Russell King - ARM Linux
2015-02-26 17:42 ` Russell King - ARM Linux
2015-02-26 18:59 ` Stephen Warren
2015-02-26 19:00 ` Stephen Warren
2015-02-26 19:00 ` Stephen Warren
2015-02-26 19:26 ` Geert Uytterhoeven
2015-02-26 19:26 ` Geert Uytterhoeven
2015-02-26 19:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF560F.3070805@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.