Re: [PATCH v2] RFC: Automatically check xen's public headers for C++ pitfalls.

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 02/26/2015 07:01 PM, Tim Deegan wrote:
> +#ifdef __cplusplus
> +/* 'private' is a keyword in C++, so we have to use a different name for
> + * private state there.  Leaving the C name alone to avoid unnecessary
> + * pain for the existing users. */
> +#define XEN_RING_PRIVATE pvt
> +#else
> +#define XEN_RING_PRIVATE private
> +#endif

Are there likely to be many users outside of the ones using that code
with mem_event? Because if there aren't, there are much more drastic
changes happening in Tamas' pending series, so perhaps seen that way the
change becomes more acceptable.


Thanks,
Razvan