* [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
@ 2015-02-25 16:03 Fabio Estevam
2015-02-25 16:27 ` Otavio Salvador
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-02-25 16:03 UTC (permalink / raw)
To: u-boot
Currently the usage text for the 'ums' command looks like this:
Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
,so remove the extra 'ums' in the text.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
common/cmd_usb_mass_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_usb_mass_storage.c b/common/cmd_usb_mass_storage.c
index 2c879ea..51c3fff 100644
--- a/common/cmd_usb_mass_storage.c
+++ b/common/cmd_usb_mass_storage.c
@@ -159,6 +159,6 @@ exit:
U_BOOT_CMD(ums, 4, 1, do_usb_mass_storage,
"Use the UMS [User Mass Storage]",
- "ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0\n"
+ "<USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0\n"
" devtype defaults to mmc"
);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
2015-02-25 16:03 [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text Fabio Estevam
@ 2015-02-25 16:27 ` Otavio Salvador
2015-02-25 16:39 ` Marek Vasut
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Otavio Salvador @ 2015-02-25 16:27 UTC (permalink / raw)
To: u-boot
On Wed, Feb 25, 2015 at 1:03 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Currently the usage text for the 'ums' command looks like this:
>
> Usage:
> ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
>
> ,so remove the extra 'ums' in the text.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 8+ messages in thread* [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
2015-02-25 16:03 [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text Fabio Estevam
2015-02-25 16:27 ` Otavio Salvador
@ 2015-02-25 16:39 ` Marek Vasut
2015-02-27 13:20 ` Soeren Moch
2015-03-06 15:47 ` [U-Boot] " Tom Rini
3 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2015-02-25 16:39 UTC (permalink / raw)
To: u-boot
On Wednesday, February 25, 2015 at 05:03:19 PM, Fabio Estevam wrote:
> Currently the usage text for the 'ums' command looks like this:
>
> Usage:
> ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
>
> ,so remove the extra 'ums' in the text.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
2015-02-25 16:03 [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text Fabio Estevam
2015-02-25 16:27 ` Otavio Salvador
2015-02-25 16:39 ` Marek Vasut
@ 2015-02-27 13:20 ` Soeren Moch
2015-02-28 16:04 ` Fabio Estevam
2015-03-06 15:47 ` [U-Boot] " Tom Rini
3 siblings, 1 reply; 8+ messages in thread
From: Soeren Moch @ 2015-02-27 13:20 UTC (permalink / raw)
To: u-boot
> Currently the usage text for the 'ums' command looks like this:
>
> Usage:
> ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
>
> ,so remove the extra 'ums' in the text.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
When fixing the ums help text, I think we also should change the
"long name" from "User Mass Storage" to "USB Mass Storage".
Regards,
Soeren
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
2015-02-27 13:20 ` Soeren Moch
@ 2015-02-28 16:04 ` Fabio Estevam
2015-02-28 17:48 ` Marek Vasut
2015-03-01 6:45 ` Soeren Moch
0 siblings, 2 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-02-28 16:04 UTC (permalink / raw)
To: u-boot
Hi Soeren,
On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch <smoch@web.de> wrote:
>> Currently the usage text for the 'ums' command looks like this:
>>
>> Usage:
>> ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
>>
>> ,so remove the extra 'ums' in the text.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
>
>
> When fixing the ums help text, I think we also should change the
> "long name" from "User Mass Storage" to "USB Mass Storage".
Maybe a separate patch for this?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
2015-02-28 16:04 ` Fabio Estevam
@ 2015-02-28 17:48 ` Marek Vasut
2015-03-01 6:45 ` Soeren Moch
1 sibling, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2015-02-28 17:48 UTC (permalink / raw)
To: u-boot
On Saturday, February 28, 2015 at 05:04:09 PM, Fabio Estevam wrote:
> Hi Soeren,
>
> On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch <smoch@web.de> wrote:
> >> Currently the usage text for the 'ums' command looks like this:
> >>
> >> Usage:
> >> ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
> >>
> >> ,so remove the extra 'ums' in the text.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > When fixing the ums help text, I think we also should change the
> > "long name" from "User Mass Storage" to "USB Mass Storage".
>
> Maybe a separate patch for this?
Separate please .
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
2015-02-28 16:04 ` Fabio Estevam
2015-02-28 17:48 ` Marek Vasut
@ 2015-03-01 6:45 ` Soeren Moch
1 sibling, 0 replies; 8+ messages in thread
From: Soeren Moch @ 2015-03-01 6:45 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 28.02.2015 17:04, Fabio Estevam wrote:
> Hi Soeren,
>
> On Fri, Feb 27, 2015 at 10:20 AM, Soeren Moch <smoch@web.de> wrote:
>>> Currently the usage text for the 'ums' command looks like this:
>>>
>>> Usage:
>>> ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
>>>
>>> ,so remove the extra 'ums' in the text.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>>
>> When fixing the ums help text, I think we also should change the
>> "long name" from "User Mass Storage" to "USB Mass Storage".
>
> Maybe a separate patch for this?
>
Thank you for preparing and sending the patch.
Regards,
Soeren
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text
2015-02-25 16:03 [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text Fabio Estevam
` (2 preceding siblings ...)
2015-02-27 13:20 ` Soeren Moch
@ 2015-03-06 15:47 ` Tom Rini
3 siblings, 0 replies; 8+ messages in thread
From: Tom Rini @ 2015-03-06 15:47 UTC (permalink / raw)
To: u-boot
On Wed, Feb 25, 2015 at 01:03:19PM -0300, Fabio Estevam wrote:
> Currently the usage text for the 'ums' command looks like this:
>
> Usage:
> ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0
>
> ,so remove the extra 'ums' in the text.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
> Acked-by: Marek Vasut <marex@denx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150306/dd2894a6/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-06 15:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 16:03 [U-Boot] [PATCH] cmd_usb_mass_storage: Remove extra 'ums' string in the usage text Fabio Estevam
2015-02-25 16:27 ` Otavio Salvador
2015-02-25 16:39 ` Marek Vasut
2015-02-27 13:20 ` Soeren Moch
2015-02-28 16:04 ` Fabio Estevam
2015-02-28 17:48 ` Marek Vasut
2015-03-01 6:45 ` Soeren Moch
2015-03-06 15:47 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.