From: Paolo Bonzini <pbonzini@redhat.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Gleb Natapov <gleb@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Nick Krause <xerofoify@gmail.com>
Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Build warning for unused function in the file,sm7xxfb.c
Date: Fri, 27 Feb 2015 15:21:54 +0000 [thread overview]
Message-ID: <54F08B92.3030006@redhat.com> (raw)
In-Reply-To: <20150227151434.GA2485@sudip-PC>
On 27/02/2015 16:14, Sudip Mukherjee wrote:
>>> I don't understand the change either, I suggest asking the kvmm
>>> developer who accepted it.
> Hi Paolo, We have a small confusion about commit
> bab5bb398273bb37547a185f7b344b37c700d0b9. It looks like the patch
> removed a call to function kvm_make_request() and introduced a new
> function kvm_set_pending_timer() which is just calling
> kvm_make_request() again. and the commit message just says "Adds a
> function kvm_vcpu_set_pending_timer instead of calling
> kvm_make_request in lapic.c.".
It's just a cosmetic change; and yes, I know who the author is.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Gleb Natapov <gleb@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Nick Krause <xerofoify@gmail.com>
Cc: linux-fbdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Build warning for unused function in the file,sm7xxfb.c
Date: Fri, 27 Feb 2015 16:21:54 +0100 [thread overview]
Message-ID: <54F08B92.3030006@redhat.com> (raw)
In-Reply-To: <20150227151434.GA2485@sudip-PC>
On 27/02/2015 16:14, Sudip Mukherjee wrote:
>>> I don't understand the change either, I suggest asking the kvmm
>>> developer who accepted it.
> Hi Paolo, We have a small confusion about commit
> bab5bb398273bb37547a185f7b344b37c700d0b9. It looks like the patch
> removed a call to function kvm_make_request() and introduced a new
> function kvm_set_pending_timer() which is just calling
> kvm_make_request() again. and the commit message just says "Adds a
> function kvm_vcpu_set_pending_timer instead of calling
> kvm_make_request in lapic.c.".
It's just a cosmetic change; and yes, I know who the author is.
Paolo
next prev parent reply other threads:[~2015-02-27 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 4:33 Build warning for unused function in the file,sm7xxfb.c Greg KH
2015-02-26 4:39 ` Sudip Mukherjee
2015-02-26 5:26 ` Sudip Mukherjee
2015-02-26 16:48 ` Greg KH
2015-02-27 15:14 ` Sudip Mukherjee
2015-02-27 15:26 ` Sudip Mukherjee
2015-02-27 15:21 ` Paolo Bonzini [this message]
2015-02-27 15:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F08B92.3030006@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.