From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: linux-pm@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>
Subject: Re: [PATCH] cpuidle: mvebu: Fix the CPU PM notifier usage
Date: Fri, 27 Feb 2015 17:50:23 +0100 [thread overview]
Message-ID: <54F0A04F.20706@linaro.org> (raw)
In-Reply-To: <4892716.Bf612zPN6E@vostro.rjw.lan>
On 02/26/2015 10:55 PM, Rafael J. Wysocki wrote:
> On Thursday, February 26, 2015 06:20:48 PM Gregory CLEMENT wrote:
>> As stated in kernel/cpu_pm.c, "Platform is responsible for ensuring
>> that cpu_pm_enter is not called twice on the same CPU before
>> cpu_pm_exit is called.". In the current code in case of failure when
>> calling mvebu_v7_cpu_suspend, the function cpu_pm_exit() is never
>> called whereas cpu_pm_enter() was called just before.
>>
>> This patch moves the cpu_pm_exit() in order to balance the
>> cpu_pm_enter() calls.
>>
>> Reported-by: Fulvio Benini <fbf@libero.it>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>
> Should that go to "stable" too? Which "stable" series it should go to if so?
Hi Rafael,
do you mind if I take this fix in my tree ? There is the same issue for
cpuidle-arm64.c I fixed.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpuidle: mvebu: Fix the CPU PM notifier usage
Date: Fri, 27 Feb 2015 17:50:23 +0100 [thread overview]
Message-ID: <54F0A04F.20706@linaro.org> (raw)
In-Reply-To: <4892716.Bf612zPN6E@vostro.rjw.lan>
On 02/26/2015 10:55 PM, Rafael J. Wysocki wrote:
> On Thursday, February 26, 2015 06:20:48 PM Gregory CLEMENT wrote:
>> As stated in kernel/cpu_pm.c, "Platform is responsible for ensuring
>> that cpu_pm_enter is not called twice on the same CPU before
>> cpu_pm_exit is called.". In the current code in case of failure when
>> calling mvebu_v7_cpu_suspend, the function cpu_pm_exit() is never
>> called whereas cpu_pm_enter() was called just before.
>>
>> This patch moves the cpu_pm_exit() in order to balance the
>> cpu_pm_enter() calls.
>>
>> Reported-by: Fulvio Benini <fbf@libero.it>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>
> Should that go to "stable" too? Which "stable" series it should go to if so?
Hi Rafael,
do you mind if I take this fix in my tree ? There is the same issue for
cpuidle-arm64.c I fixed.
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-02-27 16:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 17:20 [PATCH] cpuidle: mvebu: Fix the CPU PM notifier usage Gregory CLEMENT
2015-02-26 17:20 ` Gregory CLEMENT
2015-02-26 21:55 ` Rafael J. Wysocki
2015-02-26 21:55 ` Rafael J. Wysocki
2015-02-27 9:39 ` Gregory CLEMENT
2015-02-27 9:39 ` Gregory CLEMENT
2015-03-03 10:30 ` Daniel Lezcano
2015-03-03 10:30 ` Daniel Lezcano
2015-03-03 10:34 ` Gregory CLEMENT
2015-03-03 10:34 ` Gregory CLEMENT
2015-03-03 10:52 ` Fulvio
2015-03-03 10:52 ` Fulvio
2015-03-03 11:12 ` Daniel Lezcano
2015-03-03 11:12 ` Daniel Lezcano
2015-03-03 12:51 ` Gregory CLEMENT
2015-03-03 12:51 ` Gregory CLEMENT
2015-03-03 13:00 ` Daniel Lezcano
2015-03-03 13:00 ` Daniel Lezcano
2015-03-03 14:58 ` Fulvio
2015-03-03 14:58 ` Fulvio
2015-03-03 15:20 ` Daniel Lezcano
2015-03-03 15:20 ` Daniel Lezcano
2015-03-04 14:53 ` Rafael J. Wysocki
2015-03-04 14:53 ` Rafael J. Wysocki
2015-03-04 14:34 ` Daniel Lezcano
2015-03-04 14:34 ` Daniel Lezcano
2015-02-27 16:50 ` Daniel Lezcano [this message]
2015-02-27 16:50 ` Daniel Lezcano
2015-02-27 22:18 ` Rafael J. Wysocki
2015-02-27 22:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F0A04F.20706@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=boris.brezillon@free-electrons.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=nadavh@marvell.com \
--cc=rjw@rjwysocki.net \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.