From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>, linux-arm-msm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arm@kernel.org, olof@lixom.net
Subject: Re: [PATCH 4/4] firmware: qcom: scm: Move the scm driver to drivers/firmware
Date: Fri, 27 Feb 2015 10:58:01 -0800 [thread overview]
Message-ID: <54F0BE39.7020302@codeaurora.org> (raw)
In-Reply-To: <1424987976-14531-4-git-send-email-galak@codeaurora.org>
On 02/26/15 13:59, Kumar Gala wrote:
> Architectural changes in the ARM Linux kernel tree mandate the eventual
> removal of the mach-* directories. Move the scm driver to
> drivers/firmware and the scm header to include/linux to support that
> removal.
>
> Signed-off-by: Kumar Gala <galak@codeaurora.org>
> ---
> MAINTAINERS | 1 +
> arch/arm/mach-qcom/Kconfig | 3 -
> arch/arm/mach-qcom/Makefile | 3 -
> arch/arm/mach-qcom/platsmp.c | 2 +-
> arch/arm/mach-qcom/scm.c | 344 -------------------------------------------
> arch/arm/mach-qcom/scm.h | 29 ----
> drivers/firmware/Kconfig | 4 +
> drivers/firmware/Makefile | 2 +
> drivers/firmware/qcom_scm.c | 344 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/qcom_scm.h | 29 ++++
> 10 files changed, 381 insertions(+), 380 deletions(-)
> delete mode 100644 arch/arm/mach-qcom/scm.c
> delete mode 100644 arch/arm/mach-qcom/scm.h
> create mode 100644 drivers/firmware/qcom_scm.c
> create mode 100644 include/linux/qcom_scm.h
Can you generate this with -M -C? Or just throw
[diff]
renames = copy
int your git config.
The files are the same right?
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 41983883..6517132 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -132,6 +132,10 @@ config ISCSI_IBFT
> detect iSCSI boot parameters dynamically during system boot, say Y.
> Otherwise, say N.
>
> +config QCOM_SCM
> + bool
> + depends on ARM || ARM64
No need to have depends on here if the option is hidden. Just make sure
it isn't selected unless the depends are true.
Also, the drivers/firmware/Kconfig file needs to be sourced in the
arch/arm/Kconfig so that we can still get this option on arm (Lina
noticed it isn't working on arm). It looks like arm64 is already
sourcing it.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] firmware: qcom: scm: Move the scm driver to drivers/firmware
Date: Fri, 27 Feb 2015 10:58:01 -0800 [thread overview]
Message-ID: <54F0BE39.7020302@codeaurora.org> (raw)
In-Reply-To: <1424987976-14531-4-git-send-email-galak@codeaurora.org>
On 02/26/15 13:59, Kumar Gala wrote:
> Architectural changes in the ARM Linux kernel tree mandate the eventual
> removal of the mach-* directories. Move the scm driver to
> drivers/firmware and the scm header to include/linux to support that
> removal.
>
> Signed-off-by: Kumar Gala <galak@codeaurora.org>
> ---
> MAINTAINERS | 1 +
> arch/arm/mach-qcom/Kconfig | 3 -
> arch/arm/mach-qcom/Makefile | 3 -
> arch/arm/mach-qcom/platsmp.c | 2 +-
> arch/arm/mach-qcom/scm.c | 344 -------------------------------------------
> arch/arm/mach-qcom/scm.h | 29 ----
> drivers/firmware/Kconfig | 4 +
> drivers/firmware/Makefile | 2 +
> drivers/firmware/qcom_scm.c | 344 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/qcom_scm.h | 29 ++++
> 10 files changed, 381 insertions(+), 380 deletions(-)
> delete mode 100644 arch/arm/mach-qcom/scm.c
> delete mode 100644 arch/arm/mach-qcom/scm.h
> create mode 100644 drivers/firmware/qcom_scm.c
> create mode 100644 include/linux/qcom_scm.h
Can you generate this with -M -C? Or just throw
[diff]
renames = copy
int your git config.
The files are the same right?
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 41983883..6517132 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -132,6 +132,10 @@ config ISCSI_IBFT
> detect iSCSI boot parameters dynamically during system boot, say Y.
> Otherwise, say N.
>
> +config QCOM_SCM
> + bool
> + depends on ARM || ARM64
No need to have depends on here if the option is hidden. Just make sure
it isn't selected unless the depends are true.
Also, the drivers/firmware/Kconfig file needs to be sourced in the
arch/arm/Kconfig so that we can still get this option on arm (Lina
noticed it isn't working on arm). It looks like arm64 is already
sourcing it.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-02-27 18:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 21:59 [PATCH 1/4] ARM: qcom: Merge scm and scm boot code together Kumar Gala
2015-02-26 21:59 ` Kumar Gala
2015-02-26 21:59 ` [PATCH 2/4] ARM: qcom: Cleanup scm interface to only export what is needed Kumar Gala
2015-02-26 21:59 ` Kumar Gala
2015-02-26 21:59 ` [PATCH 3/4] ARM: qcom: Prep scm code for move to drivers/firmware Kumar Gala
2015-02-26 21:59 ` Kumar Gala
2015-02-26 21:59 ` [PATCH 4/4] firmware: qcom: scm: Move the scm driver " Kumar Gala
2015-02-26 21:59 ` Kumar Gala
2015-02-27 18:58 ` Stephen Boyd [this message]
2015-02-27 18:58 ` Stephen Boyd
2015-02-27 21:36 ` Kumar Gala
2015-02-27 21:36 ` Kumar Gala
-- strict thread matches above, loose matches on Subject: below --
2015-02-27 21:29 Kumar Gala
2015-02-27 21:29 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F0BE39.7020302@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arm@kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.