* [Qemu-trivial] [PATCH] qerror.h: Swap definitions that were not in alphabetical order
@ 2015-02-20 12:58 Alberto Garcia
2015-02-20 17:34 ` Markus Armbruster
2015-02-28 9:04 ` [Qemu-devel] " Michael Tokarev
0 siblings, 2 replies; 6+ messages in thread
From: Alberto Garcia @ 2015-02-20 12:58 UTC (permalink / raw)
To: qemu-trivial; +Cc: Alberto Garcia, Markus Armbruster
Signed-off-by: Alberto Garcia <berto@igalia.com>
---
include/qapi/qmp/qerror.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
index 986260f..57a62d4 100644
--- a/include/qapi/qmp/qerror.h
+++ b/include/qapi/qmp/qerror.h
@@ -37,12 +37,12 @@ void qerror_report_err(Error *err);
#define QERR_BASE_NOT_FOUND \
ERROR_CLASS_GENERIC_ERROR, "Base '%s' not found"
-#define QERR_BLOCK_JOB_NOT_READY \
- ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
-
#define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \
ERROR_CLASS_GENERIC_ERROR, "Block format '%s' used by device '%s' does not support feature '%s'"
+#define QERR_BLOCK_JOB_NOT_READY \
+ ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
+
#define QERR_BUS_NO_HOTPLUG \
ERROR_CLASS_GENERIC_ERROR, "Bus '%s' does not support hotplugging"
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH] qerror.h: Swap definitions that were not in alphabetical order
2015-02-20 12:58 [Qemu-trivial] [PATCH] qerror.h: Swap definitions that were not in alphabetical order Alberto Garcia
@ 2015-02-20 17:34 ` Markus Armbruster
2015-02-28 9:04 ` [Qemu-devel] " Michael Tokarev
1 sibling, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-02-20 17:34 UTC (permalink / raw)
To: Alberto Garcia; +Cc: qemu-trivial
Looks good, except you need to send to qemu-devel@nongnu.org in addition
to qemu-trivial. Thanks!
Alberto Garcia <berto@igalia.com> writes:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> include/qapi/qmp/qerror.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
> index 986260f..57a62d4 100644
> --- a/include/qapi/qmp/qerror.h
> +++ b/include/qapi/qmp/qerror.h
> @@ -37,12 +37,12 @@ void qerror_report_err(Error *err);
> #define QERR_BASE_NOT_FOUND \
> ERROR_CLASS_GENERIC_ERROR, "Base '%s' not found"
>
> -#define QERR_BLOCK_JOB_NOT_READY \
> - ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> -
> #define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \
> ERROR_CLASS_GENERIC_ERROR, "Block format '%s' used by device '%s' does not support feature '%s'"
>
> +#define QERR_BLOCK_JOB_NOT_READY \
> + ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> +
> #define QERR_BUS_NO_HOTPLUG \
> ERROR_CLASS_GENERIC_ERROR, "Bus '%s' does not support hotplugging"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] qerror.h: Swap definitions that were not in alphabetical order
2015-02-20 12:58 [Qemu-trivial] [PATCH] qerror.h: Swap definitions that were not in alphabetical order Alberto Garcia
@ 2015-02-28 9:04 ` Michael Tokarev
2015-02-28 9:04 ` [Qemu-devel] " Michael Tokarev
1 sibling, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-02-28 9:04 UTC (permalink / raw)
To: Alberto Garcia, qemu-trivial; +Cc: Markus Armbruster, qemu-devel
Applied to -trivial, thank you!
Markus, should I add your Reviewed-By (or Acked-By)?
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qerror.h: Swap definitions that were not in alphabetical order
@ 2015-02-28 9:04 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-02-28 9:04 UTC (permalink / raw)
To: Alberto Garcia, qemu-trivial; +Cc: Markus Armbruster, qemu-devel
Applied to -trivial, thank you!
Markus, should I add your Reviewed-By (or Acked-By)?
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qerror.h: Swap definitions that were not in alphabetical order
2015-02-28 9:04 ` [Qemu-devel] " Michael Tokarev
@ 2015-03-02 9:39 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-03-02 9:39 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Alberto Garcia, qemu-devel
Michael Tokarev <mjt@tls.msk.ru> writes:
> Applied to -trivial, thank you!
>
> Markus, should I add your Reviewed-By (or Acked-By)?
I'm working towards getting rid of the whole thing. But until then,
keeping it sorted is good.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-02 9:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 12:58 [Qemu-trivial] [PATCH] qerror.h: Swap definitions that were not in alphabetical order Alberto Garcia
2015-02-20 17:34 ` Markus Armbruster
2015-02-28 9:04 ` Michael Tokarev
2015-02-28 9:04 ` [Qemu-devel] " Michael Tokarev
2015-03-02 9:39 ` [Qemu-trivial] " Markus Armbruster
2015-03-02 9:39 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.