From: Michael Tokarev <mjt@tls.msk.ru>
To: Gonglei <arei.gonglei@huawei.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v2] e500: fix memory leak
Date: Sat, 28 Feb 2015 13:47:52 +0300 [thread overview]
Message-ID: <54F19CD8.4070308@msgid.tls.msk.ru> (raw)
In-Reply-To: <54F19602.4010401@huawei.com>
28.02.2015 13:18, Gonglei wrote:
> On 2015/2/28 18:13, Michael Tokarev wrote:
[]
>> How about this?
>>
> It's ok on function, but seems oddly, isn't it?
I don't see anything odd in it. The `filename' variable is only
used as an argument for load_device_tree() function and is not used
anywhwere else, so it's logical to free it after use.
>> --- a/hw/ppc/e500.c
>> +++ b/hw/ppc/e500.c
>> @@ -308,6 +308,7 @@ static int ppce500_load_device_tree(MachineState *machine,
>> }
>>
>> fdt = load_device_tree(filename, &fdt_size);
>> + g_free(filename);
>> if (!fdt) {
>> goto out;
>> }
>>
Thanks,
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Gonglei <arei.gonglei@huawei.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] e500: fix memory leak
Date: Sat, 28 Feb 2015 13:47:52 +0300 [thread overview]
Message-ID: <54F19CD8.4070308@msgid.tls.msk.ru> (raw)
In-Reply-To: <54F19602.4010401@huawei.com>
28.02.2015 13:18, Gonglei wrote:
> On 2015/2/28 18:13, Michael Tokarev wrote:
[]
>> How about this?
>>
> It's ok on function, but seems oddly, isn't it?
I don't see anything odd in it. The `filename' variable is only
used as an argument for load_device_tree() function and is not used
anywhwere else, so it's logical to free it after use.
>> --- a/hw/ppc/e500.c
>> +++ b/hw/ppc/e500.c
>> @@ -308,6 +308,7 @@ static int ppce500_load_device_tree(MachineState *machine,
>> }
>>
>> fdt = load_device_tree(filename, &fdt_size);
>> + g_free(filename);
>> if (!fdt) {
>> goto out;
>> }
>>
Thanks,
/mjt
next prev parent reply other threads:[~2015-02-28 10:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 10:08 [Qemu-trivial] [PATCH v2] e500: fix memory leak arei.gonglei
2015-02-28 10:08 ` [Qemu-devel] " arei.gonglei
2015-02-28 10:13 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 10:13 ` [Qemu-devel] " Michael Tokarev
2015-02-28 10:18 ` [Qemu-trivial] " Gonglei
2015-02-28 10:18 ` [Qemu-devel] " Gonglei
2015-02-28 10:47 ` Michael Tokarev [this message]
2015-02-28 10:47 ` Michael Tokarev
2015-02-28 16:40 ` [Qemu-trivial] " Paolo Bonzini
2015-02-28 16:40 ` [Qemu-devel] " Paolo Bonzini
2015-02-28 16:47 ` [Qemu-trivial] " Stefan Weil
2015-02-28 16:47 ` Stefan Weil
2015-03-01 10:06 ` [Qemu-trivial] " Paolo Bonzini
2015-03-01 10:06 ` [Qemu-devel] " Paolo Bonzini
2015-03-02 1:17 ` [Qemu-trivial] " Gonglei
2015-03-02 1:17 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F19CD8.4070308@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=arei.gonglei@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.