All of lore.kernel.org
 help / color / mirror / Atom feed
* Getting a 'no-ack' tx status?
@ 2015-02-27 23:26 Ben Greear
  2015-02-28 17:52 ` Ben Greear
  2015-03-02  8:45 ` Michal Kazior
  0 siblings, 2 replies; 3+ messages in thread
From: Ben Greear @ 2015-02-27 23:26 UTC (permalink / raw)
  To: ath10k

Someone reported to me that they never see the
tx_done->no_ack flag set on their AP, even when stations are falling
off the network due to not receiving ACKs.

	if (tx_done->no_ack)
		info->flags &= ~IEEE80211_TX_STAT_ACK;


I am having no luck finding the corresponding code in the 10.1.467
firmware that would cause this to work, but maybe I am just not looking
in the right place.

Has anyone done any testing to see if ath10k actually reports ACK failures
properly back up the stack?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Getting a 'no-ack' tx status?
  2015-02-27 23:26 Getting a 'no-ack' tx status? Ben Greear
@ 2015-02-28 17:52 ` Ben Greear
  2015-03-02  8:45 ` Michal Kazior
  1 sibling, 0 replies; 3+ messages in thread
From: Ben Greear @ 2015-02-28 17:52 UTC (permalink / raw)
  To: ath10k

I think I managed to hack the CT firmware to return the
tx-completion status (OK, XRETRY, DROP) when it is returning the
tx-rate info, and patched the driver to pay attention to it...

A brief test showed some failed-retry counters reported by
the mac80211 stack, so that looks promising.

Will do some more testing when I get a chance.

Thanks,
Ben

On 02/27/2015 03:26 PM, Ben Greear wrote:
> Someone reported to me that they never see the
> tx_done->no_ack flag set on their AP, even when stations are falling
> off the network due to not receiving ACKs.
>
> 	if (tx_done->no_ack)
> 		info->flags &= ~IEEE80211_TX_STAT_ACK;
>
>
> I am having no luck finding the corresponding code in the 10.1.467
> firmware that would cause this to work, but maybe I am just not looking
> in the right place.
>
> Has anyone done any testing to see if ath10k actually reports ACK failures
> properly back up the stack?
>
> Thanks,
> Ben
>

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Getting a 'no-ack' tx status?
  2015-02-27 23:26 Getting a 'no-ack' tx status? Ben Greear
  2015-02-28 17:52 ` Ben Greear
@ 2015-03-02  8:45 ` Michal Kazior
  1 sibling, 0 replies; 3+ messages in thread
From: Michal Kazior @ 2015-03-02  8:45 UTC (permalink / raw)
  To: Ben Greear; +Cc: ath10k

On 28 February 2015 at 00:26, Ben Greear <greearb@candelatech.com> wrote:
> Someone reported to me that they never see the
> tx_done->no_ack flag set on their AP, even when stations are falling
> off the network due to not receiving ACKs.
>
>         if (tx_done->no_ack)
>                 info->flags &= ~IEEE80211_TX_STAT_ACK;
>
>
> I am having no luck finding the corresponding code in the 10.1.467
> firmware that would cause this to work, but maybe I am just not looking
> in the right place.
>
> Has anyone done any testing to see if ath10k actually reports ACK failures
> properly back up the stack?

IIRC 10.1 firmware had a missing condition for that so it reported all
frames as ACKed even if that wasn't the case.

I believe this has been fixed in 10.2.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-02  8:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 23:26 Getting a 'no-ack' tx status? Ben Greear
2015-02-28 17:52 ` Ben Greear
2015-03-02  8:45 ` Michal Kazior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.