All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: Nikolay Dimitrov <picmaster@mail.bg>
Cc: "meta-freescale@yoctoproject.org"
	<meta-freescale@yoctoproject.org>,
	Gary Thomas <gary@mlbassoc.com>
Subject: Re: Audio glitch with SGTL5000
Date: Sun, 01 Mar 2015 15:40:20 -0700	[thread overview]
Message-ID: <54F39554.7070300@boundarydevices.com> (raw)
In-Reply-To: <54F384AD.6040902@mail.bg>

Hi Nikolay,

On 03/01/2015 02:29 PM, Nikolay Dimitrov wrote:
> Hi Eric,
> 
> On 02/28/2015 08:53 PM, Eric Nelson wrote:
>> Hi all,
>>
>> On 01/22/2015 12:52 PM, Fabio Estevam wrote:
>>> Hi Nikolay,
>>>
>>> On Thu, Jan 22, 2015 at 5:49 PM, Nikolay Dimitrov <picmaster@mail.bg>
>>> wrote:
>>>
>>>> Sorry, I didn't mean that at all.
>>>
>>> No problem. I am glad you spotted the problem with the SMALL_POP bit.
>>> I will also check if there is an error in the SMALL_POP bit definition
>>> in the manual.
>>>
>>>>> This is off-topic here on a Yocto list though, so I suggest we move
>>>>> such discussion to the alsa-devel list which is the appropriate place.
>>>>
>>>>
>>>> OK, understood.
>>>
>>> Maybe sending your workaround patch as a RFC could be a start for the
>>> discussion there.
>>>
>>
>> I think I found the problem, and it was fixed in main-line in this
>> commit by Marek:
>>
>>     https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/sound/soc/codecs/sgtl5000.c?id=dd4d2d6dfb49e8916064f2cb07f0ad7b32a82fb7
>>
>>
>> I pushed a 3.10.17 version of it to our Github tree:
>>     https://github.com/boundarydevices/linux-imx6/commit/ff27114
> 
> Can you confirm tha this fix solves the pop on line-out? Just want to
> be sure, as most of the related patch-work fixes mostly the headphones-
> related pop.
> 

Our boards don't support line-out, so I can't confirm that, though
it should (VAG applies to both HP and LO).

Also, Gary reported earlier that the patch doesn't fix the
pop on 3.10.53.

I presume that's because we also have Fabio's SMALL_POP fix applied on
our 3.10.17 tree.

Regards,


Eric



  reply	other threads:[~2015-03-01 22:40 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 22:12 Audio glitch with SGTL5000 Nikolay Dimitrov
2015-01-20 22:23 ` Fabio Estevam
2015-01-21  0:34   ` Nikolay Dimitrov
2015-01-21  0:38     ` Nikolay Dimitrov
2015-01-21  0:51       ` Fabio Estevam
2015-01-21  0:50     ` Fabio Estevam
2015-01-21  2:30       ` Nikolay Dimitrov
2015-01-21  2:56         ` Fabio Estevam
2015-01-21  2:59           ` Fabio Estevam
2015-01-21 23:55             ` Nikolay Dimitrov
2015-01-22  0:00               ` Fabio Estevam
2015-01-22  4:59                 ` Nikolay Dimitrov
2015-01-22 13:24                 ` Gary Thomas
2015-01-22 18:32                   ` Nikolay Dimitrov
2015-01-22 18:35                     ` Gary Thomas
2015-01-22 19:05                       ` Eric Nelson
2015-01-22 19:20                         ` Nikolay Dimitrov
2015-01-22 19:33                           ` Fabio Estevam
2015-01-22 19:49                             ` Nikolay Dimitrov
2015-01-22 19:52                               ` Fabio Estevam
2015-02-28 18:53                                 ` Eric Nelson
2015-02-28 20:29                                   ` Otavio Salvador
2015-03-01 15:08                                   ` Gary Thomas
2015-06-24 18:12                                     ` Nikolay Dimitrov
2015-07-02 21:37                                       ` Otavio Salvador
2015-07-02 22:21                                         ` Nikolay Dimitrov
2015-03-01 21:29                                   ` Nikolay Dimitrov
2015-03-01 22:40                                     ` Eric Nelson [this message]
2015-01-22 19:21                         ` Gary Thomas
2015-01-22 19:46                           ` Gary Thomas
2015-01-22 19:49                             ` Fabio Estevam
2015-01-22 20:16                               ` Gary Thomas
2015-01-22 20:28                                 ` Nikolay Dimitrov
2015-01-22 20:38                                   ` Gary Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F39554.7070300@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=gary@mlbassoc.com \
    --cc=meta-freescale@yoctoproject.org \
    --cc=picmaster@mail.bg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.