From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Olaf Hering <olaf@aepfle.de>
Cc: Tim Deegan <tim@xen.org>,
xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/4] vscsiif.h: remove reference to WWN
Date: Mon, 2 Mar 2015 10:50:50 +0000 [thread overview]
Message-ID: <54F4408A.8080208@citrix.com> (raw)
In-Reply-To: <54F44D930200007800064EC7@mail.emea.novell.com>
On 02/03/15 10:46, Jan Beulich wrote:
>>>> On 02.03.15 at 11:15, <olaf@aepfle.de> wrote:
>> The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation.
>> Remove incorrect reference to WWN because it was never supported. And
>> its not clear how it could be supported. p-devname can be used to store
>> a config string.
> I'm not sure - even if a particular implementation doesn't support
> certain functionality, I would say the interface definition can still
> name this as a possibility.
It would be misleading to suggest it is available if it is not
implemented. Furthermore, Olaf's comment suggests that it cant be
supported with this key, at which point the reference should absolutely
be removed.
~Andrew
next prev parent reply other threads:[~2015-03-02 10:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 10:15 [PATCH 0/4] libbxl: add support for pvscsi, iteration 2 Olaf Hering
2015-03-02 10:15 ` [PATCH 1/4] vscsiif.h: remove reference to WWN Olaf Hering
2015-03-02 10:46 ` Jan Beulich
2015-03-02 10:50 ` Andrew Cooper [this message]
2015-03-02 10:55 ` Jürgen Groß
2015-03-02 11:00 ` Andrew Cooper
2015-03-02 10:59 ` Jan Beulich
2015-03-02 10:59 ` Juergen Gross
2015-03-02 14:34 ` Olaf Hering
2015-03-02 14:40 ` Olaf Hering
2015-03-02 14:55 ` Juergen Gross
2015-03-02 10:16 ` [PATCH 2/4] docs: add vscsi to xenstore-paths.markdown Olaf Hering
2015-03-02 10:16 ` [PATCH 3/4] docs: add pvscsi.txt Olaf Hering
2015-03-02 10:49 ` Jan Beulich
2015-03-02 11:04 ` Juergen Gross
2015-03-02 15:14 ` Olaf Hering
2015-03-02 15:35 ` Juergen Gross
2015-03-02 18:24 ` Olaf Hering
2015-03-02 10:16 ` [PATCH 4/4] libxl: add support for vscsi Olaf Hering
2015-03-02 14:20 ` Olaf Hering
2015-03-02 14:31 ` Ian Campbell
2015-03-02 15:11 ` Olaf Hering
2015-03-02 14:27 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4408A.8080208@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=olaf@aepfle.de \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.