[PATCH] xen/pciback: Don't print scary messages when unsupported by hypervisor.

[PATCH] xen/pciback: Don't print scary messages when unsupported by hypervisor.

[Konrad Rzeszutek Wilk]

We print at the warninig level messages such as:
pciback 0000:90:00.5: MSI-X preparation failed (-38)

which is due to the hypervisor not supporting this sub-hypercall
(which was added in Xen 4.3).

Instead of having scary messages all the time - only have it
when the hypercall is actually supported.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/xen/xen-pciback/pci_stub.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index 7acc796..ddc5500 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -115,7 +115,7 @@ static void pcistub_device_release(struct kref *kref)
 		int err = HYPERVISOR_physdev_op(PHYSDEVOP_release_msix,
 						&ppdev);
 
-		if (err)
+		if (err && err != -ENOSYS)
 			dev_warn(&dev->dev, "MSI-X release failed (%d)\n",
 				 err);
 	}
@@ -376,7 +376,7 @@ static int __devinit pcistub_init_device(struct pci_dev *dev)
 		};
 
 		err = HYPERVISOR_physdev_op(PHYSDEVOP_prepare_msix, &ppdev);
-		if (err)
+		if (err && err != -ENOSYS)
 			dev_err(&dev->dev, "MSI-X preparation failed (%d)\n",
 				err);
 	}
-- 
2.1.0

Re: [PATCH] xen/pciback: Don't print scary messages when unsupported by hypervisor.

[David Vrabel]

On 27/02/15 21:11, Konrad Rzeszutek Wilk wrote:
> We print at the warninig level messages such as:
> pciback 0000:90:00.5: MSI-X preparation failed (-38)
> 
> which is due to the hypervisor not supporting this sub-hypercall
> (which was added in Xen 4.3).
> 
> Instead of having scary messages all the time - only have it
> when the hypercall is actually supported.

Applied to devel/for-linus-4.1, thanks.

David