All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
	QEMU Developer <qemu-devel@nongnu.org>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH 1/3] migration: Fix coding style (whitespace issues)
Date: Mon, 02 Mar 2015 15:15:11 +0300	[thread overview]
Message-ID: <54F4544F.6000602@msgid.tls.msk.ru> (raw)
In-Reply-To: <1425146983-16015-2-git-send-email-sw@weilnetz.de>

28.02.2015 21:09, Stefan Weil wrote:
> * Remove trailing whitespace (fixes 9 errors from checkpatch.pl).
>   One comment line was longer than 80 characters, so wrap it
>   and fix a typo, too.
> * Replace tabs by blanks (fixes 1 error).

This hunk:

> @@ -2421,7 +2421,7 @@ static int qemu_rdma_dest_init(RDMAContext *rdma, Error **errp)
>                          continue;
>                      }
>                  }
> -                    
> +
>                  goto listen;
>              }


clashes with my earlier attemt to clean up this code, I rewrote
this loop a bit to avoid this "twisted" usage of gotos.
I'll apply this patch without this change.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
	QEMU Developer <qemu-devel@nongnu.org>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] migration: Fix coding style (whitespace issues)
Date: Mon, 02 Mar 2015 15:15:11 +0300	[thread overview]
Message-ID: <54F4544F.6000602@msgid.tls.msk.ru> (raw)
In-Reply-To: <1425146983-16015-2-git-send-email-sw@weilnetz.de>

28.02.2015 21:09, Stefan Weil wrote:
> * Remove trailing whitespace (fixes 9 errors from checkpatch.pl).
>   One comment line was longer than 80 characters, so wrap it
>   and fix a typo, too.
> * Replace tabs by blanks (fixes 1 error).

This hunk:

> @@ -2421,7 +2421,7 @@ static int qemu_rdma_dest_init(RDMAContext *rdma, Error **errp)
>                          continue;
>                      }
>                  }
> -                    
> +
>                  goto listen;
>              }


clashes with my earlier attemt to clean up this code, I rewrote
this loop a bit to avoid this "twisted" usage of gotos.
I'll apply this patch without this change.

Thanks,

/mjt

  reply	other threads:[~2015-03-02 12:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-28 18:09 [Qemu-trivial] migration: Fix 32 bit compiler errors Stefan Weil
2015-02-28 18:09 ` [Qemu-devel] " Stefan Weil
2015-02-28 18:09 ` [Qemu-trivial] [PATCH 1/3] migration: Fix coding style (whitespace issues) Stefan Weil
2015-02-28 18:09   ` [Qemu-devel] " Stefan Weil
2015-03-02 12:15   ` Michael Tokarev [this message]
2015-03-02 12:15     ` Michael Tokarev
2015-03-04 12:20   ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-03-04 12:20     ` Dr. David Alan Gilbert
2015-03-17 12:42   ` [Qemu-trivial] " Juan Quintela
2015-03-17 12:42     ` [Qemu-devel] " Juan Quintela
2015-02-28 18:09 ` [Qemu-trivial] [PATCH 2/3] migration: Fix some 32 bit compiler errors Stefan Weil
2015-02-28 18:09   ` [Qemu-devel] " Stefan Weil
2015-03-04 12:44   ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-03-04 12:44     ` Dr. David Alan Gilbert
2015-03-04 21:00     ` [Qemu-trivial] " Stefan Weil
2015-03-04 21:00       ` Stefan Weil
2015-03-05 10:28       ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-03-05 10:28         ` Dr. David Alan Gilbert
2015-03-17 13:10   ` [Qemu-trivial] " Juan Quintela
2015-03-17 13:10     ` [Qemu-devel] " Juan Quintela
2015-02-28 18:09 ` [Qemu-trivial] [PATCH 3/3] migration: Fix remaining " Stefan Weil
2015-02-28 18:09   ` [Qemu-devel] " Stefan Weil
2015-03-04 13:31   ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-03-04 13:31     ` Dr. David Alan Gilbert
2015-03-04 20:45     ` [Qemu-trivial] " Stefan Weil
2015-03-04 20:45       ` Stefan Weil
2015-03-05 10:10       ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-03-05 10:10         ` Dr. David Alan Gilbert
2015-03-17 13:11   ` [Qemu-trivial] " Juan Quintela
2015-03-17 13:11     ` [Qemu-devel] " Juan Quintela
2015-03-02  5:58 ` [Qemu-trivial] migration: Fix " Amit Shah
2015-03-02  5:58   ` [Qemu-devel] " Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F4544F.6000602@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.