From: David Vrabel <david.vrabel@citrix.com>
To: Tao Chen <boby.chen@huawei.com>,
jgross@suse.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org, rudy.zhangmin@huawei.com,
wu.wubin@huawei.com
Subject: Re: [Xen-devel] [PATCH] xen-scsiback: use DRV_PFX in the pr macros
Date: Tue, 3 Mar 2015 10:09:09 +0000 [thread overview]
Message-ID: <54F58845.1040001@citrix.com> (raw)
In-Reply-To: <1425371832-55072-1-git-send-email-boby.chen@huawei.com>
On 03/03/15 08:37, Tao Chen wrote:
> Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX,
> it makes the code easier to read.
You need to #define pr_fmt(fmt) to add a prefix like this.
> struct ids_tuple v; /* translate from */
> - struct scsiback_tpg *tpg; /* translate to */
> + struct scsiback_tpg *tpg; /* translate to */
Please don't make unrelated whitespace changes.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Tao Chen <boby.chen@huawei.com>, <jgross@suse.com>,
<konrad.wilk@oracle.com>, <boris.ostrovsky@oracle.com>,
<david.vrabel@citrix.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xenproject.org>, <rudy.zhangmin@huawei.com>,
<wu.wubin@huawei.com>
Subject: Re: [Xen-devel] [PATCH] xen-scsiback: use DRV_PFX in the pr macros
Date: Tue, 3 Mar 2015 10:09:09 +0000 [thread overview]
Message-ID: <54F58845.1040001@citrix.com> (raw)
In-Reply-To: <1425371832-55072-1-git-send-email-boby.chen@huawei.com>
On 03/03/15 08:37, Tao Chen wrote:
> Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX,
> it makes the code easier to read.
You need to #define pr_fmt(fmt) to add a prefix like this.
> struct ids_tuple v; /* translate from */
> - struct scsiback_tpg *tpg; /* translate to */
> + struct scsiback_tpg *tpg; /* translate to */
Please don't make unrelated whitespace changes.
David
next prev parent reply other threads:[~2015-03-03 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 8:37 [PATCH] xen-scsiback: use DRV_PFX in the pr macros Tao Chen
2015-03-03 8:37 ` Tao Chen
2015-03-03 9:52 ` Juergen Gross
2015-03-04 10:30 ` Chentao (Boby)
2015-03-04 10:30 ` Chentao (Boby)
2015-03-03 9:52 ` Juergen Gross
2015-03-03 10:09 ` David Vrabel
2015-03-03 10:09 ` David Vrabel [this message]
2015-03-03 10:09 ` [Xen-devel] " David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F58845.1040001@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boby.chen@huawei.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rudy.zhangmin@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.