Re: [PATCH 1/2] xen: arm: log warning for interrupt configuration mismatch

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 02/03/2015 17:01, Ian Campbell wrote:
> On Mon, 2015-03-02 at 12:56 +0000, Julien Grall wrote:
>
>>>  From 852f6e3fe49f7fab801f2857b8b505922556d746 Mon Sep 17 00:00:00 2001
>>> From: Ian Campbell <ian.campbell@citrix.com>
>>> Date: Mon, 2 Mar 2015 11:09:35 +0000
>>> Subject: [PATCH] xen: arm: Assume level triggered means high, not low.
>>>
>>> When reading back the ICFG register we cannot know the polarity of the
>>> configuration, just that it is level or edge.
>>>
>>> Since falling edge and low level are invalid for SPIs we should assume
>>> rising edge and high level (we have no better information for PPIs, so
>>> it'll have to do).
>>>
>>> We already assumed rising edge, switch to high level as well.
>>>
>>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>
>> Given the usage of desc->arch.type in Xen, I think this is the right
>> solution:
>>
>> Reviewed-by: Julien Grall <julien.grall@linaro.org>
>
> Applied, thanks.
>
> With your "don't warn if high-level" patch[*] is that all of the fallout
> from this series, other than making desc->arch.type just track level vs
> edge without polarity?

Yes.

Regards,

-- 
Julien Grall