From: Nicolas Schichan <nschichan@freebox.fr>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Tobias Klauser <tklauser@distanz.ch>, Felipe Balbi <balbi@ti.com>,
Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: fix poll callback.
Date: Tue, 03 Mar 2015 14:53:36 +0100 [thread overview]
Message-ID: <54F5BCE0.3060507@freebox.fr> (raw)
In-Reply-To: <1425390142.5130.173.camel@edumazet-glaptop2.roam.corp.google.com>
On 03/03/2015 02:42 PM, Eric Dumazet wrote:
>> To avoid that, I would take priv->tx_lock only once, or add a limit on
>> the number of skbs that can be drained per round.
>
> Something like this (untested) patch
I'm not against testing this patch, but we do not have any SMP capable bcm63xx
board here so I don't think it will be of any use.
bcm6358 and bcm6368 do indeed have two MIPS threads, but SMP is not possible
(due to a data cache or TLB shared across all MIPS threads , unbearably
complicating things, IIRC).
bcm63xx ARM SoCs look like they can support SMP though.
Regards,
--
Nicolas Schichan
Freebox SAS
next prev parent reply other threads:[~2015-03-03 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 11:45 [PATCH] bcm63xx_enet: fix poll callback Nicolas Schichan
2015-03-03 13:29 ` Eric Dumazet
2015-03-03 13:42 ` Eric Dumazet
2015-03-03 13:53 ` Nicolas Schichan [this message]
2015-03-03 14:18 ` Eric Dumazet
2015-03-03 14:43 ` Nicolas Schichan
2015-03-03 17:42 ` Florian Fainelli
2015-03-03 23:05 ` Jonas Gorski
2015-03-03 16:09 ` Alexander Duyck
2015-03-03 16:32 ` Eric Dumazet
2015-03-04 20:45 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-03-02 17:28 Nicolas Schichan
2015-03-03 3:15 ` David Miller
2015-03-03 11:18 ` Nicolas Schichan
2015-03-03 19:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5BCE0.3060507@freebox.fr \
--to=nschichan@freebox.fr \
--cc=alexander.h.duyck@redhat.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=w-lkml@lebenslange-mailadresse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.