From: Christian Ruppert <christian.ruppert@alitech.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"christian.ruppert@abilis.com" <christian.ruppert@abilis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER
Date: Tue, 03 Mar 2015 18:46:53 +0100 [thread overview]
Message-ID: <54F5F38D.5050309@alitech.com> (raw)
In-Reply-To: <20150303172145.GA7076@katana>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2015-03-03 18:21, Wolfram Sang wrote:
>
>> which omit this type of messages completely. Andy's proposal of
>> centralising this looks like a very good solution here (and on
>> top of that removes many useless strings from the kernel
>> binary).
>
> I am all for centralizing printouts. I recommended this at my ELCE
> talk last year, too. However, you need to keep in mind that irqs
> are sometimes optional and you don't want error messages for those
> irqs. IMO worthwhile, but not a low hanging fruit...
There is a lot of truth in that. Thus the initial dev_dbg() suggestion
to go half way. I still think that Andy's proposal (or a variation
thereof to catch the optional irqs case) should be the ultimate goal
but I agree that this is more than a quick patch and that it's
probably way out of scope here.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
iQIcBAEBAgAGBQJU9fONAAoJENOBSR1q+OdQLh0P/3f9NIBGyvpr3ao+UVhiW26f
8ikcd1lHezjGZuILPgsobb4bpePwyV0IYLoqediGtwOSlbe6IlxC5DTzwlcJhUe5
BDtker32yPTohA8uc27PFlnZ3secJ3xngmF43QwsP4waQxdLsufQ85YQ1/P4SXhQ
gkxZpE1J1T4jVshtrf4lWlMJ3okdN2n/aFILRkNPCGc5QV9FjAMDwzYJLhBJw8wj
0Xe0X6zflgLlbUGfIeUIPoS7Stn9JtLZt/ltRAPBfFdKwBLUWOvmqGWl5XBcgzRi
UCEEefQl7T/H5HXOEdUyLuCFNsa7rMLEGX8HVSpqb1516dMM4L4vQomISKQyW5ED
SHLaCwzIsQTLdaY4gfNdKjJQMkuZSktz5zG8k3SRAR1PSqzNn7isUcc12HmoyRUd
2lONuN79r3z2iM591FofG69uC64RAJc5DHBj9gHbyvPwp48SMOQThO2vUunZvDoZ
E9rfux3Dj0txpxeh4GqGUjtDXmIhcLm9uXMYQ2UBMH/vaz3adWcX3rH76MLTIZCS
a0ilv+7Jr8VDgJcik2hiFIsSURSZqKSub6bXefvUYc8jOscREa0SnBQvGT3xkl+p
n57+5d+lWpkT4a5LSVRqkhhAtG+g/Ti09YOfhR2Z3C2xvWxM7VyVbxY69UDPXW5Z
sBDHtNkqCZUcx5wdkPec
=cvA7
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-03-03 17:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 15:27 [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Alexey Brodkin
2015-03-03 16:28 ` Christian Ruppert
[not found] ` <54F5E120.3090705-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>
2015-03-03 16:37 ` Alexey Brodkin
2015-03-03 16:37 ` Alexey Brodkin
[not found] ` <1425400650.17965.53.camel-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2015-03-03 16:50 ` christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ
2015-03-03 16:50 ` christian.ruppert
2015-03-03 17:21 ` Wolfram Sang
2015-03-03 17:46 ` Christian Ruppert [this message]
2015-03-03 19:03 ` Andy Shevchenko
[not found] ` <1425409412.14897.157.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-03 19:11 ` Wolfram Sang
2015-03-03 19:11 ` Wolfram Sang
2015-03-03 19:34 ` Andy Shevchenko
2015-03-03 19:34 ` Andy Shevchenko
2015-03-07 0:24 ` Wolfram Sang
2015-03-07 0:24 ` Wolfram Sang
2015-03-09 8:29 ` Alexey Brodkin
2015-03-09 8:29 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5F38D.5050309@alitech.com \
--to=christian.ruppert@alitech.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christian.ruppert@abilis.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.