Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]


> > > I am all for centralizing printouts. I recommended this at my ELCE
> > > talk last year, too. However, you need to keep in mind that irqs
> > > are sometimes optional and you don't want error messages for those
> > > irqs. IMO worthwhile, but not a low hanging fruit...
> > 
> > There is a lot of truth in that. Thus the initial dev_dbg() suggestion
> > to go half way. I still think that Andy's proposal (or a variation
> > thereof to catch the optional irqs case) should be the ultimate goal
> > but I agree that this is more than a quick patch and that it's
> > probably way out of scope here.
> 
> Yes, I was thinking even about some wrapper on top of platform_get_irq()
> since it seems there are no messaging done inside platform.c, though
> devm_* functions usually have it.

When I had a look a few months ago, the situation with devm_* was messy.
Some rightfully printed errors, some rightfully didn't, some vice versa,
some the other way around, and some did something else...

For driver authors, it is hard to see/remember which devm function does
it and which doesn't. IMO a good cleanup will get rid of this mess. I
started sketching something but especially clks and irqs are basically
everywhere and so it easily grew out of the fun-time project scale,
sadly.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]