All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: pm: fix at91rm9200 standby
Date: Tue, 3 Mar 2015 20:05:56 +0100	[thread overview]
Message-ID: <54F60614.8070307@atmel.com> (raw)
In-Reply-To: <1425409102-29337-1-git-send-email-alexandre.belloni@free-electrons.com>

Le 03/03/2015 19:58, Alexandre Belloni a ?crit :
> at91rm9200 standby and suspend to ram has been broken since
> 00482a4078f4. It is wrongly using AT91_BASE_SYS which is a physical address
> and actually doesn't correspond to any register on at91rm9200.
> 
> Use the correct at91_ramc_base[0] instead.
> 
> Fixes: 00482a4078f4 (ARM: at91: implement the standby function for pm/cpuidle)
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
and immediately added to at91-4.0-fixes.

Thanks. Bye,

> ---
>  arch/arm/mach-at91/pm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index d2c89963af2d..86c0aa819d25 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -44,7 +44,7 @@ static inline void at91rm9200_standby(void)
>  		"    mcr    p15, 0, %0, c7, c0, 4\n\t"
>  		"    str    %5, [%1, %2]"
>  		:
> -		: "r" (0), "r" (AT91_BASE_SYS), "r" (AT91RM9200_SDRAMC_LPR),
> +		: "r" (0), "r" (at91_ramc_base[0]), "r" (AT91RM9200_SDRAMC_LPR),
>  		  "r" (1), "r" (AT91RM9200_SDRAMC_SRR),
>  		  "r" (lpr));
>  }
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Wenyou Yang <Wenyou.Yang@atmel.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH] ARM: at91: pm: fix at91rm9200 standby
Date: Tue, 3 Mar 2015 20:05:56 +0100	[thread overview]
Message-ID: <54F60614.8070307@atmel.com> (raw)
In-Reply-To: <1425409102-29337-1-git-send-email-alexandre.belloni@free-electrons.com>

Le 03/03/2015 19:58, Alexandre Belloni a écrit :
> at91rm9200 standby and suspend to ram has been broken since
> 00482a4078f4. It is wrongly using AT91_BASE_SYS which is a physical address
> and actually doesn't correspond to any register on at91rm9200.
> 
> Use the correct at91_ramc_base[0] instead.
> 
> Fixes: 00482a4078f4 (ARM: at91: implement the standby function for pm/cpuidle)
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
and immediately added to at91-4.0-fixes.

Thanks. Bye,

> ---
>  arch/arm/mach-at91/pm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index d2c89963af2d..86c0aa819d25 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -44,7 +44,7 @@ static inline void at91rm9200_standby(void)
>  		"    mcr    p15, 0, %0, c7, c0, 4\n\t"
>  		"    str    %5, [%1, %2]"
>  		:
> -		: "r" (0), "r" (AT91_BASE_SYS), "r" (AT91RM9200_SDRAMC_LPR),
> +		: "r" (0), "r" (at91_ramc_base[0]), "r" (AT91RM9200_SDRAMC_LPR),
>  		  "r" (1), "r" (AT91RM9200_SDRAMC_SRR),
>  		  "r" (lpr));
>  }
> 


-- 
Nicolas Ferre

  reply	other threads:[~2015-03-03 19:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 18:58 [PATCH] ARM: at91: pm: fix at91rm9200 standby Alexandre Belloni
2015-03-03 18:58 ` Alexandre Belloni
2015-03-03 19:05 ` Nicolas Ferre [this message]
2015-03-03 19:05   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F60614.8070307@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.