From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Drop vpc from 004's and 104's format list
Date: Tue, 03 Mar 2015 15:06:26 -0700 [thread overview]
Message-ID: <54F63062.401@redhat.com> (raw)
In-Reply-To: <1425417759-17170-3-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On 03/03/2015 02:22 PM, Max Reitz wrote:
> Both tests require the test image to have a specific size; this cannot
> be guaranteed by vpc (unless tuning the test specifically for that
> format).
>
> It is safe to exclude vpc from 004 because what is tested there is
> implemented in a generic part in the block layer and not
> format-specific.
>
> It is safe to exclude vpc from 104 because for vpc basically every image
> size is "unaligned", so if that would break at some point in time, we
> would quickly notice just by running the generic tests.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/004 | 2 +-
> tests/qemu-iotests/104 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-03 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 21:22 [Qemu-devel] [PATCH 0/2] iotests: Make tests pass for vpc Max Reitz
2015-03-03 21:22 ` [Qemu-devel] [PATCH 1/2] iotests: Remove 006 Max Reitz
2015-03-03 22:05 ` Eric Blake
2015-03-03 22:10 ` Max Reitz
2015-03-03 21:22 ` [Qemu-devel] [PATCH 2/2] iotests: Drop vpc from 004's and 104's format list Max Reitz
2015-03-03 22:06 ` Eric Blake [this message]
2015-03-04 10:19 ` [Qemu-devel] [PATCH 0/2] iotests: Make tests pass for vpc Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F63062.401@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.