All of lore.kernel.org
 help / color / mirror / Atom feed
From: yjin <yanjiang.jin@windriver.com>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: <horia.geanta@freescale.com>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <ruchika.gupta@freescale.com>,
	<cristian.stoica@freescale.com>, <NiteshNarayanLal@freescale.com>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<jinyanjiang@gmail.com>
Subject: Re: [PATCH 2/3] crypto: caam_rng: fix rng_unmap_ctx's DMA_UNMAP size problem
Date: Wed, 4 Mar 2015 13:33:22 +0800	[thread overview]
Message-ID: <54F69922.6080404@windriver.com> (raw)
In-Reply-To: <20150303133120.6706da49d0f7188a8213fe36@freescale.com>


On 2015年03月04日 03:31, Kim Phillips wrote:
> On Tue, 3 Mar 2015 14:50:52 +0800
> <yanjiang.jin@windriver.com> wrote:
>
>> -		dma_unmap_single(jrdev, ctx->sh_desc_dma, DESC_RNG_LEN,
>> -				 DMA_TO_DEVICE);
>> +		dma_unmap_single(jrdev, ctx->sh_desc_dma,
>> +				desc_bytes(ctx->sh_desc), DMA_TO_DEVICE);
> alignment: the 'd' in desc_bytes should fall directly under the 'j'
> in jrdev.
>
> Also, DESC_RNG_LEN should be corrected to (4 * CAAM_CMD_SZ).

Hi Kim,

I can't find the obvious limitation for the RNG descriptor length in 
Freescale documents, could you point out it?

Thanks!
Yanjiang
>
> Kim
>
>

  reply	other threads:[~2015-03-04  5:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03  6:50 [PATCH 0/3] fix some CAAM warnings yanjiang.jin
2015-03-03  6:50 ` [PATCH 1/3] crypto: caam: fix some compile warnings yanjiang.jin
2015-03-03 18:59   ` Kim Phillips
2015-03-04  2:32     ` yjin
2015-03-04  4:57       ` yjin
2015-03-04  9:03         ` Cristian Stoica
2015-03-04 18:34           ` Kim Phillips
2015-03-05  7:12             ` Cristian Stoica
2015-03-06  0:38               ` Kim Phillips
2015-03-04  8:48       ` Cristian Stoica
2015-03-04  9:11       ` Cristian Stoica
2015-03-03  6:50 ` [PATCH 2/3] crypto: caam_rng: fix rng_unmap_ctx's DMA_UNMAP size problem yanjiang.jin
2015-03-03 19:31   ` Kim Phillips
2015-03-04  5:33     ` yjin [this message]
2015-03-04 18:36       ` Kim Phillips
2015-03-05  2:52         ` yjin
2015-03-06  0:28           ` Kim Phillips
2015-03-03  6:50 ` [PATCH 3/3] crypto: caamhash: - fix uninitialized edesc->sec4_sg_bytes field yanjiang.jin
2015-03-03 13:39 ` [PATCH 0/3] fix some CAAM warnings Horia Geantă

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F69922.6080404@windriver.com \
    --to=yanjiang.jin@windriver.com \
    --cc=NiteshNarayanLal@freescale.com \
    --cc=cristian.stoica@freescale.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@freescale.com \
    --cc=jinyanjiang@gmail.com \
    --cc=kim.phillips@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruchika.gupta@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.