From: Cristian Stoica <cristian.stoica@freescale.com>
To: yjin <yanjiang.jin@windriver.com>,
Kim Phillips <kim.phillips@freescale.com>
Cc: <horia.geanta@freescale.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>, <ruchika.gupta@freescale.com>,
<NiteshNarayanLal@freescale.com>, <linux-crypto@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <jinyanjiang@gmail.com>
Subject: Re: [PATCH 1/3] crypto: caam: fix some compile warnings
Date: Wed, 4 Mar 2015 10:48:55 +0200 [thread overview]
Message-ID: <54F6C6F7.6020400@freescale.com> (raw)
In-Reply-To: <54F66EA3.7080506@windriver.com>
Hi Yanjiang,
On 03/04/2015 04:32 AM, yjin wrote:
>
> On 2015年03月04日 02:59, Kim Phillips wrote:
>> On Tue, 3 Mar 2015 14:50:51 +0800
>> <yanjiang.jin@windriver.com> wrote:
>>
>>> This commit is to avoid the below warnings:
>>>
>>> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning:
>>> 'dma_map_sg_chained' defined but not used [-Wunused-function]
>>> static int dma_map_sg_chained(struct device *dev, struct
>>> scatterlist *sg,
[...]
>
> We can find an example in Freescale SDK 1.6:
> caampkc.c includes pkc_desc.h, pkc_desc.h includes sg_sw_sec4.h, but
> caampkc.c doesn't call those functions.
This one was fixed in sdk-1.7 with the following patch:
diff --git a/drivers/crypto/caam/pkc_desc.h b/drivers/crypto/caam/pkc_desc.h
index f73ad07..03013c2 100644
--- a/drivers/crypto/caam/pkc_desc.h
+++ b/drivers/crypto/caam/pkc_desc.h
@@ -20,7 +20,6 @@
#include "desc_constr.h"
#include "jr.h"
#include "error.h"
-#include "sg_sw_sec4.h"
#include <linux/crypto.h>
#include "pdb.h"
Cristian S.
next prev parent reply other threads:[~2015-03-04 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 6:50 [PATCH 0/3] fix some CAAM warnings yanjiang.jin
2015-03-03 6:50 ` [PATCH 1/3] crypto: caam: fix some compile warnings yanjiang.jin
2015-03-03 18:59 ` Kim Phillips
2015-03-04 2:32 ` yjin
2015-03-04 4:57 ` yjin
2015-03-04 9:03 ` Cristian Stoica
2015-03-04 18:34 ` Kim Phillips
2015-03-05 7:12 ` Cristian Stoica
2015-03-06 0:38 ` Kim Phillips
2015-03-04 8:48 ` Cristian Stoica [this message]
2015-03-04 9:11 ` Cristian Stoica
2015-03-03 6:50 ` [PATCH 2/3] crypto: caam_rng: fix rng_unmap_ctx's DMA_UNMAP size problem yanjiang.jin
2015-03-03 19:31 ` Kim Phillips
2015-03-04 5:33 ` yjin
2015-03-04 18:36 ` Kim Phillips
2015-03-05 2:52 ` yjin
2015-03-06 0:28 ` Kim Phillips
2015-03-03 6:50 ` [PATCH 3/3] crypto: caamhash: - fix uninitialized edesc->sec4_sg_bytes field yanjiang.jin
2015-03-03 13:39 ` [PATCH 0/3] fix some CAAM warnings Horia Geantă
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F6C6F7.6020400@freescale.com \
--to=cristian.stoica@freescale.com \
--cc=NiteshNarayanLal@freescale.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@freescale.com \
--cc=jinyanjiang@gmail.com \
--cc=kim.phillips@freescale.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruchika.gupta@freescale.com \
--cc=yanjiang.jin@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.