All of lore.kernel.org
 help / color / mirror / Atom feed
From: leroy christophe <christophe.leroy@c-s.fr>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1
Date: Wed, 04 Mar 2015 09:00:39 +0100	[thread overview]
Message-ID: <54F6BBA7.8040008@c-s.fr> (raw)
In-Reply-To: <20150303184403.GE21293@sirena.org.uk>

Le 03/03/2015 19:44, Mark Brown a écrit :
> On Thu, Feb 26, 2015 at 05:11:42PM +0100, Christophe Leroy wrote:
>> On CPM2, the SPI parameter RAM is dynamically allocated in the dualport RAM
>> whereas in CPM1, it is statically allocated to a default address with
>> capability to relocate it somewhere else via the use of CPM micropatch.
>> The address of the parameter RAM is given by the boot loader and expected
>> to be mapped via of_iomap()
> Why are we using of_iomap() rather than a generic I/O mapping function
> here?
Euh ...

because all drivers for powerpc seems to be using of_iomap(), as on 
powerpc the HW is described by the bootloader in a OF device tree.
Today, of_iomap() is at least used in FSL SPI, FSL UART, SPI mpc52xx, 
UART mpc52xx, i2c-mpc, i2c-cpm, freescale ethernet drivers, etc ....

Is it not correct ?

WARNING: multiple messages have this Message-ID (diff)
From: leroy christophe <christophe.leroy@c-s.fr>
To: Mark Brown <broonie@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1
Date: Wed, 04 Mar 2015 09:00:39 +0100	[thread overview]
Message-ID: <54F6BBA7.8040008@c-s.fr> (raw)
In-Reply-To: <20150303184403.GE21293@sirena.org.uk>

Le 03/03/2015 19:44, Mark Brown a écrit :
> On Thu, Feb 26, 2015 at 05:11:42PM +0100, Christophe Leroy wrote:
>> On CPM2, the SPI parameter RAM is dynamically allocated in the dualport RAM
>> whereas in CPM1, it is statically allocated to a default address with
>> capability to relocate it somewhere else via the use of CPM micropatch.
>> The address of the parameter RAM is given by the boot loader and expected
>> to be mapped via of_iomap()
> Why are we using of_iomap() rather than a generic I/O mapping function
> here?
Euh ...

because all drivers for powerpc seems to be using of_iomap(), as on 
powerpc the HW is described by the bootloader in a OF device tree.
Today, of_iomap() is at least used in FSL SPI, FSL UART, SPI mpc52xx, 
UART mpc52xx, i2c-mpc, i2c-cpm, freescale ethernet drivers, etc ....

Is it not correct ?

  reply	other threads:[~2015-03-04  8:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-26 16:11 [PATCH] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1 Christophe Leroy
2015-02-26 16:11 ` Christophe Leroy
2015-02-26 16:11 ` Christophe Leroy
     [not found] ` <20150226161142.D08681A2360-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-03-03 18:44   ` Mark Brown
2015-03-03 18:44     ` Mark Brown
2015-03-03 18:44     ` Mark Brown
2015-03-04  8:00     ` leroy christophe [this message]
2015-03-04  8:00       ` leroy christophe
     [not found]       ` <54F6BBA7.8040008-GgN8y9CXRhA@public.gmane.org>
2015-03-06 11:44         ` Mark Brown
2015-03-06 11:44           ` Mark Brown
2015-03-06 11:44           ` Mark Brown
     [not found]           ` <20150306114413.GM21293-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-12  6:52             ` leroy christophe
2015-03-12  6:52               ` leroy christophe
2015-03-12  6:52               ` leroy christophe
2015-03-18 12:03               ` Mark Brown
2015-03-18 12:03                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F6BBA7.8040008@c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.