Re: [PATCH][meta-oe] samba: disable services for sysvinit

[wenzong fan <wenzong.fan@windriver.com>]

On 03/04/2015 05:12 PM, Andreas Oberritter wrote:
> Dear Wenzong Fan,
>
> On 04.03.2015 07:18, wenzong.fan@windriver.com wrote:
>> From: Wenzong Fan <wenzong.fan@windriver.com>
>>
>> The smb, nmb, winbind services have been disabled for systemd system
>> by default, disable them for sysvinit as well.
>
> why would anybody install these services without the desire for using
> them? Did the patch disabling them for systemd get merged by mistake? I
> remember Paul objecting to it.

The samba is not a common service that required by system, especially in 
some security environment, it should be configured correctly first - 
This is why I incline to disable it by default.

Yes, it did - this may give me some hints that it should be disabled ...

Thanks
Wenzong

>
> Regards,
> Andreas
>
>>
>> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
>> ---
>>   meta-oe/recipes-connectivity/samba/samba.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-connectivity/samba/samba.inc b/meta-oe/recipes-connectivity/samba/samba.inc
>> index abfd5ca..99216ce 100644
>> --- a/meta-oe/recipes-connectivity/samba/samba.inc
>> +++ b/meta-oe/recipes-connectivity/samba/samba.inc
>> @@ -69,7 +69,7 @@ INITSCRIPT_NAME_winbind = "winbind"
>>   # No dependencies, goes in at level 20 (NOTE: take care with the
>>   # level, later levels put the shutdown later too - see the links
>>   # in rc6.d, the shutdown must precede network shutdown).
>> -INITSCRIPT_PARAMS = "defaults"
>> +INITSCRIPT_PARAMS = "disable"
>>   CONFFILES_${PN} = "${sysconfdir}/samba/smb.conf"
>>
>>   do_configure_prepend () {
>>
>