[nfs-utils PATCH] mountstats: Normalize the mountpoints passed on the command line.

[nfs-utils PATCH] mountstats: Normalize the mountpoints passed on the command line.

[Scott Mayhew]

Normalize the mountpoints passed on the command line so that commands
like 'mountstats /mnt/' succeed rather than fail.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 tools/mountstats/mountstats.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 7f5dee1..38943eb 100644
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -686,7 +686,7 @@ def mountstats_command(args):
     """Mountstats command
     """
     mountstats = parse_stats_file(args.infile)
-    mountpoints = args.mountpoints
+    mountpoints = [os.path.normpath(mp) for mp in args.mountpoints]
 
     # make certain devices contains only NFS mount points
     if len(mountpoints) > 0:
@@ -735,7 +735,7 @@ def nfsstat_command(args):
     """nfsstat-like command for NFS mount points
     """
     mountstats = parse_stats_file(args.infile)
-    mountpoints = args.mountpoints
+    mountpoints = [os.path.normpath(mp) for mp in args.mountpoints]
     v3stats = DeviceData()
     v3stats.setup_accumulator(Nfsv3ops)
     v4stats = DeviceData()
@@ -822,7 +822,7 @@ def iostat_command(args):
     """iostat-like command for NFS mount points
     """
     mountstats = parse_stats_file(args.infile)
-    devices = args.mountpoints
+    devices = [os.path.normpath(mp) for mp in args.mountpoints]
 
     if args.since:
         old_mountstats = parse_stats_file(args.since)
-- 
1.9.3

Re: [nfs-utils PATCH] mountstats: Normalize the mountpoints passed on the command line.

[Steve Dickson]

On 03/03/2015 02:15 PM, Scott Mayhew wrote:
> Normalize the mountpoints passed on the command line so that commands
> like 'mountstats /mnt/' succeed rather than fail.
> 
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed...

steved.

> ---
>  tools/mountstats/mountstats.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 7f5dee1..38943eb 100644
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -686,7 +686,7 @@ def mountstats_command(args):
>      """Mountstats command
>      """
>      mountstats = parse_stats_file(args.infile)
> -    mountpoints = args.mountpoints
> +    mountpoints = [os.path.normpath(mp) for mp in args.mountpoints]
>  
>      # make certain devices contains only NFS mount points
>      if len(mountpoints) > 0:
> @@ -735,7 +735,7 @@ def nfsstat_command(args):
>      """nfsstat-like command for NFS mount points
>      """
>      mountstats = parse_stats_file(args.infile)
> -    mountpoints = args.mountpoints
> +    mountpoints = [os.path.normpath(mp) for mp in args.mountpoints]
>      v3stats = DeviceData()
>      v3stats.setup_accumulator(Nfsv3ops)
>      v4stats = DeviceData()
> @@ -822,7 +822,7 @@ def iostat_command(args):
>      """iostat-like command for NFS mount points
>      """
>      mountstats = parse_stats_file(args.infile)
> -    devices = args.mountpoints
> +    devices = [os.path.normpath(mp) for mp in args.mountpoints]
>  
>      if args.since:
>          old_mountstats = parse_stats_file(args.since)
> -- 1.9.3
>