Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Fixed error 'else should follow close brace '}".

[Jes Sorensen <jes.sorensen@gmail.com>]

On 03/04/15 16:15, Yeliz Taneroglu wrote:
> This patch fixes error 'else should follow close brace '}"
> found by checkpatch in driver rtl8723au.
> 
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_efuse.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Hi Yeliz,

Your patch is fine, calling it an error is maybe a little much, but I
think this is fine for this case.

Cheers
Jes



> diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
> index a6deddc..29fc25b 100644
> --- a/drivers/staging/rtl8723au/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
> @@ -304,8 +304,7 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
>  		}
>  		data = rtl8723au_read8(Adapter, EFUSE_CTRL);
>  		return data;
> -	}
> -	else
> +	} else
>  		return 0xFF;
>  }/* EFUSE_Read1Byte23a */
>  
>