All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rtl8723au: Fixed error 'else should follow close brace '}".
@ 2015-03-04 21:15 Yeliz Taneroglu
  2015-03-05  1:40 ` [Outreachy kernel] " Jes Sorensen
  0 siblings, 1 reply; 2+ messages in thread
From: Yeliz Taneroglu @ 2015-03-04 21:15 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Yeliz Taneroglu

This patch fixes error 'else should follow close brace '}"
found by checkpatch in driver rtl8723au.

Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_efuse.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
index a6deddc..29fc25b 100644
--- a/drivers/staging/rtl8723au/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
@@ -304,8 +304,7 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
 		}
 		data = rtl8723au_read8(Adapter, EFUSE_CTRL);
 		return data;
-	}
-	else
+	} else
 		return 0xFF;
 }/* EFUSE_Read1Byte23a */
 
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Fixed error 'else should follow close brace '}".
  2015-03-04 21:15 [PATCH] Staging: rtl8723au: Fixed error 'else should follow close brace '}" Yeliz Taneroglu
@ 2015-03-05  1:40 ` Jes Sorensen
  0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2015-03-05  1:40 UTC (permalink / raw)
  To: Yeliz Taneroglu, outreachy-kernel

On 03/04/15 16:15, Yeliz Taneroglu wrote:
> This patch fixes error 'else should follow close brace '}"
> found by checkpatch in driver rtl8723au.
> 
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_efuse.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Hi Yeliz,

Your patch is fine, calling it an error is maybe a little much, but I
think this is fine for this case.

Cheers
Jes



> diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
> index a6deddc..29fc25b 100644
> --- a/drivers/staging/rtl8723au/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
> @@ -304,8 +304,7 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
>  		}
>  		data = rtl8723au_read8(Adapter, EFUSE_CTRL);
>  		return data;
> -	}
> -	else
> +	} else
>  		return 0xFF;
>  }/* EFUSE_Read1Byte23a */
>  
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-05  1:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-04 21:15 [PATCH] Staging: rtl8723au: Fixed error 'else should follow close brace '}" Yeliz Taneroglu
2015-03-05  1:40 ` [Outreachy kernel] " Jes Sorensen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.