From: Ray Jui <rjui@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Christian Daudt <bcm@fixthebug.org>,
Matt Porter <mporter@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>,
Scott Branden <sbranden@broadcom.com>,
Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger
Subject: Re: [PATCH v9 2/4] pinctrl: cygnus: add gpio/pinconf driver
Date: Wed, 4 Mar 2015 21:01:45 -0800 [thread overview]
Message-ID: <54F7E339.50902@broadcom.com> (raw)
In-Reply-To: <54F742CA.7080500@broadcom.com>
Hi Linus,
>>> +#include <linux/kernel.h>
>>> +#include <linux/slab.h>
>>> +#include <linux/module.h>
>>> +#include <linux/interrupt.h>
>>> +#include <linux/io.h>
>>> +#include <linux/gpio.h>
>>
>> This should be:
>> #include <linux/gpio/driver.h>
In fact, just by trying it out I found I need linux/gpio.h for APIs like
gpiochip_add_pin_range, and etc.
>>
>>
>
> Great! I will address all comments and re-send a BIG patch series with
> the other pinctrl patch series consolidated.
>
> Thanks!
>
> Ray
>
I've consolidated this patch series with the IOMUX and sent out a
combined patch series earlier. I believe all other comments have been
addressed except the above include header one.
Thanks,
Ray
WARNING: multiple messages have this Message-ID (diff)
From: rjui@broadcom.com (Ray Jui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/4] pinctrl: cygnus: add gpio/pinconf driver
Date: Wed, 4 Mar 2015 21:01:45 -0800 [thread overview]
Message-ID: <54F7E339.50902@broadcom.com> (raw)
In-Reply-To: <54F742CA.7080500@broadcom.com>
Hi Linus,
>>> +#include <linux/kernel.h>
>>> +#include <linux/slab.h>
>>> +#include <linux/module.h>
>>> +#include <linux/interrupt.h>
>>> +#include <linux/io.h>
>>> +#include <linux/gpio.h>
>>
>> This should be:
>> #include <linux/gpio/driver.h>
In fact, just by trying it out I found I need linux/gpio.h for APIs like
gpiochip_add_pin_range, and etc.
>>
>>
>
> Great! I will address all comments and re-send a BIG patch series with
> the other pinctrl patch series consolidated.
>
> Thanks!
>
> Ray
>
I've consolidated this patch series with the IOMUX and sent out a
combined patch series earlier. I believe all other comments have been
addressed except the above include header one.
Thanks,
Ray
WARNING: multiple messages have this Message-ID (diff)
From: Ray Jui <rjui@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Christian Daudt <bcm@fixthebug.org>,
Matt Porter <mporter@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Joe Perches <joe@perches.com>, "Arnd Bergmann" <arnd@arndb.de>,
Scott Branden <sbranden@broadcom.com>,
"Dmitry Torokhov" <dtor@google.com>,
Anatol Pomazau <anatol@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v9 2/4] pinctrl: cygnus: add gpio/pinconf driver
Date: Wed, 4 Mar 2015 21:01:45 -0800 [thread overview]
Message-ID: <54F7E339.50902@broadcom.com> (raw)
In-Reply-To: <54F742CA.7080500@broadcom.com>
Hi Linus,
>>> +#include <linux/kernel.h>
>>> +#include <linux/slab.h>
>>> +#include <linux/module.h>
>>> +#include <linux/interrupt.h>
>>> +#include <linux/io.h>
>>> +#include <linux/gpio.h>
>>
>> This should be:
>> #include <linux/gpio/driver.h>
In fact, just by trying it out I found I need linux/gpio.h for APIs like
gpiochip_add_pin_range, and etc.
>>
>>
>
> Great! I will address all comments and re-send a BIG patch series with
> the other pinctrl patch series consolidated.
>
> Thanks!
>
> Ray
>
I've consolidated this patch series with the IOMUX and sent out a
combined patch series earlier. I believe all other comments have been
addressed except the above include header one.
Thanks,
Ray
next prev parent reply other threads:[~2015-03-05 5:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 22:16 [PATCH v9 0/4] Add gpio/pinconf support to Broadcom Cygnus SoC Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` [PATCH v9 1/4] pinctrl: Cygnus: define Broadcom Cygnus GPIO/PINCONF binding Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` [PATCH v9 2/4] pinctrl: cygnus: add gpio/pinconf driver Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` Ray Jui
[not found] ` <1423606584-21795-3-git-send-email-rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-04 9:48 ` Linus Walleij
2015-03-04 9:48 ` Linus Walleij
2015-03-04 9:48 ` Linus Walleij
[not found] ` <CACRpkda-C1upKfa4FKLcVF9sxL4T=B+eG9ndun4fS6DZ9TfCSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-04 17:37 ` Ray Jui
2015-03-04 17:37 ` Ray Jui
2015-03-04 17:37 ` Ray Jui
2015-03-05 5:01 ` Ray Jui [this message]
2015-03-05 5:01 ` Ray Jui
2015-03-05 5:01 ` Ray Jui
2015-02-10 22:16 ` [PATCH v9 3/4] ARM: dts: enable GPIO for Broadcom Cygnus Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` [PATCH v9 4/4] ARM: dts: cygnus: enable GPIO based hook detection Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-10 22:16 ` Ray Jui
2015-02-25 19:30 ` [PATCH v9 0/4] Add gpio/pinconf support to Broadcom Cygnus SoC Dmitry Torokhov
2015-02-25 19:30 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F7E339.50902@broadcom.com \
--to=rjui@broadcom.com \
--cc=anatol@google.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger \
--cc=dtor@google.com \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mporter@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.