From: Gonglei <arei.gonglei@huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/9] arm: fix memory leak
Date: Thu, 5 Mar 2015 17:43:17 +0800 [thread overview]
Message-ID: <54F82535.1050903@huawei.com> (raw)
In-Reply-To: <87oao7zv8m.fsf@blackfin.pond.sub.org>
On 2015/3/5 16:47, Markus Armbruster wrote:
> Hard-won personal experience: the more trivial a change is, the more
> likely I am to screw it up in some stupid way.
>
> In other words: no change is too trivial to screw it up.
>
> Corollary: no change is trivial enough to skip testing.
I can't agree any more. Never again. :(
Regards,
-Gonglei
WARNING: multiple messages have this Message-ID (diff)
From: Gonglei <arei.gonglei@huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/9] arm: fix memory leak
Date: Thu, 5 Mar 2015 17:43:17 +0800 [thread overview]
Message-ID: <54F82535.1050903@huawei.com> (raw)
In-Reply-To: <87oao7zv8m.fsf@blackfin.pond.sub.org>
On 2015/3/5 16:47, Markus Armbruster wrote:
> Hard-won personal experience: the more trivial a change is, the more
> likely I am to screw it up in some stupid way.
>
> In other words: no change is too trivial to screw it up.
>
> Corollary: no change is trivial enough to skip testing.
I can't agree any more. Never again. :(
Regards,
-Gonglei
next prev parent reply other threads:[~2015-03-05 9:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 7:50 [Qemu-trivial] [PATCH 0/9] Coverity defects fixes arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 1/9] nbd: fix resource leak arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 2/9] arm: fix memory leak arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-28 9:52 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 9:52 ` [Qemu-devel] " Michael Tokarev
2015-02-28 9:59 ` [Qemu-trivial] " Gonglei
2015-02-28 9:59 ` [Qemu-devel] " Gonglei
2015-02-28 10:18 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 10:18 ` [Qemu-devel] " Michael Tokarev
2015-02-28 10:21 ` Gonglei
2015-02-28 10:21 ` [Qemu-devel] " Gonglei
2015-03-04 13:16 ` Michael Tokarev
2015-03-04 13:16 ` [Qemu-devel] " Michael Tokarev
2015-03-05 2:26 ` Gonglei
2015-03-05 2:26 ` [Qemu-devel] " Gonglei
2015-03-05 8:47 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
2015-03-05 8:47 ` [Qemu-devel] [Qemu-trivial] " Markus Armbruster
2015-03-05 9:43 ` Gonglei [this message]
2015-03-05 9:43 ` Gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 3/9] sparc/leon3.c: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 4/9] macio: fix possible " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 5/9] e500: fix " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-28 9:41 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 9:41 ` [Qemu-devel] " Michael Tokarev
2015-02-28 9:57 ` [Qemu-trivial] " Gonglei
2015-02-28 9:57 ` [Qemu-devel] " Gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 6/9] 9pfs: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-28 9:46 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 9:46 ` [Qemu-devel] " Michael Tokarev
2015-03-04 12:30 ` [Qemu-trivial] " Michael Tokarev
2015-03-04 12:30 ` [Qemu-devel] " Michael Tokarev
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 7/9] milkymist.c: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 8/9] sysbus: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-27 7:50 ` [Qemu-trivial] [PATCH 9/9] microblaze: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] " arei.gonglei
2015-02-28 9:54 ` [Qemu-trivial] [PATCH 0/9] Coverity defects fixes Michael Tokarev
2015-02-28 9:54 ` [Qemu-devel] " Michael Tokarev
2015-02-28 10:03 ` [Qemu-trivial] " Gonglei
2015-02-28 10:03 ` [Qemu-devel] " Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F82535.1050903@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.