From: Marc Zyngier <marc.zyngier@arm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Eric Auger <eric.auger@linaro.org>,
"eric.auger@st.com" <eric.auger@st.com>,
"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: Andre Przywara <Andre.Przywara@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@linaro.org" <patches@linaro.org>,
"gleb@kernel.org" <gleb@kernel.org>
Subject: Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support
Date: Thu, 05 Mar 2015 11:33:07 +0000 [thread overview]
Message-ID: <54F83EF3.4070903@arm.com> (raw)
In-Reply-To: <54F83DAE.2060607@redhat.com>
On 05/03/15 11:27, Paolo Bonzini wrote:
>
>
> On 05/03/2015 11:53, Marc Zyngier wrote:
>>> +#ifdef CONFIG_HAVE_KVM_IRQFD
>>> + case KVM_CAP_IRQFD:
>>> + r = vgic_present;
>>> + break;
>>> +#endif
>>
>> Nitpick: we have "select HAVE_KVM_IRQFD", so we can lose the #ifdef-ery.
>
> Alternatively, I've just posted a patch to move the KVM_CAP_IRQFD case
> to common code.
>
> vgic_present probably should be replaced by
> IS_ENABLED(CONFIG_KVM_ARM_VGIC). I've sent a patch for this.
Right. We can probably take this at the same time as Eric's series.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support
Date: Thu, 05 Mar 2015 11:33:07 +0000 [thread overview]
Message-ID: <54F83EF3.4070903@arm.com> (raw)
In-Reply-To: <54F83DAE.2060607@redhat.com>
On 05/03/15 11:27, Paolo Bonzini wrote:
>
>
> On 05/03/2015 11:53, Marc Zyngier wrote:
>>> +#ifdef CONFIG_HAVE_KVM_IRQFD
>>> + case KVM_CAP_IRQFD:
>>> + r = vgic_present;
>>> + break;
>>> +#endif
>>
>> Nitpick: we have "select HAVE_KVM_IRQFD", so we can lose the #ifdef-ery.
>
> Alternatively, I've just posted a patch to move the KVM_CAP_IRQFD case
> to common code.
>
> vgic_present probably should be replaced by
> IS_ENABLED(CONFIG_KVM_ARM_VGIC). I've sent a patch for this.
Right. We can probably take this at the same time as Eric's series.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2015-03-05 11:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 10:14 [PATCH v9 0/5] irqfd support for arm/arm64 Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` [PATCH v9 1/5] KVM: arm/arm64: unset CONFIG_HAVE_KVM_IRQCHIP Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` [PATCH v9 2/5] KVM: introduce kvm_arch_intc_initialized and use it in irqfd Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` [PATCH v9 3/5] KVM: arm/arm64: implement kvm_arch_intc_initialized Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` [PATCH v9 4/5] KVM: arm/arm64: remove coarse grain dist locking at kvm_vgic_sync_hwstate Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` [PATCH v9 5/5] KVM: arm/arm64: add irqfd support Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-04 10:14 ` Eric Auger
2015-03-05 10:53 ` Marc Zyngier
2015-03-05 10:53 ` Marc Zyngier
2015-03-05 11:27 ` Paolo Bonzini
2015-03-05 11:27 ` Paolo Bonzini
2015-03-05 11:27 ` Paolo Bonzini
2015-03-05 11:33 ` Marc Zyngier [this message]
2015-03-05 11:33 ` Marc Zyngier
2015-03-11 14:24 ` Christoffer Dall
2015-03-11 14:24 ` Christoffer Dall
2015-03-11 16:54 ` Eric Auger
2015-03-11 16:54 ` Eric Auger
2015-03-11 16:54 ` Eric Auger
2015-03-05 14:04 ` Eric Auger
2015-03-05 14:04 ` Eric Auger
2015-03-05 14:20 ` Marc Zyngier
2015-03-05 14:20 ` Marc Zyngier
2015-03-05 14:26 ` Eric Auger
2015-03-05 14:26 ` Eric Auger
2015-03-05 14:26 ` Eric Auger
2015-03-05 14:34 ` Marc Zyngier
2015-03-05 14:34 ` Marc Zyngier
2015-03-05 14:34 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F83EF3.4070903@arm.com \
--to=marc.zyngier@arm.com \
--cc=Andre.Przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=eric.auger@st.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.