* [PATCH] ARM: dts: exynos4: add nodes for jpeg codec
@ 2015-03-05 12:28 Marek Szyprowski
2015-03-05 12:41 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Marek Szyprowski @ 2015-03-05 12:28 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Marek Szyprowski, Kukjin Kim
This patch adds nodes for hardware JPEG codec found in Exynos 4210 and
4x12 SoCs.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++
arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 77ea547..1bd630a 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -685,6 +685,15 @@
#include "exynos4412-tmu-sensor-conf.dtsi"
};
+ jpeg-codec@11840000 {
+ compatible = "samsung,exynos4210-jpeg";
+ reg = <0x11840000 0x1000>;
+ interrupts = <0 88 0>;
+ clocks = <&clock CLK_JPEG>;
+ clock-names = "jpeg";
+ samsung,power-domain = <&pd_cam>;
+ };
+
hdmi: hdmi@12D00000 {
compatible = "samsung,exynos4210-hdmi";
reg = <0x12D00000 0x70000>;
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 6a6abe1..72b9a1d 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -299,6 +299,10 @@
status = "disabled";
};
+ jpeg-codec@11840000 {
+ compatible = "samsung,exynos4212-jpeg";
+ };
+
hdmi: hdmi@12D00000 {
compatible = "samsung,exynos4212-hdmi";
};
--
1.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: exynos4: add nodes for jpeg codec
2015-03-05 12:28 [PATCH] ARM: dts: exynos4: add nodes for jpeg codec Marek Szyprowski
@ 2015-03-05 12:41 ` Javier Martinez Canillas
2015-03-05 12:48 ` Marek Szyprowski
2015-03-05 12:48 ` [PATCH v2] " Marek Szyprowski
0 siblings, 2 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-03-05 12:41 UTC (permalink / raw)
To: Marek Szyprowski; +Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim
Hello Marek,
Patch looks good to me. Just a small comment below so feel free to add my
Reviewed by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
On Thu, Mar 5, 2015 at 1:28 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> This patch adds nodes for hardware JPEG codec found in Exynos 4210 and
> 4x12 SoCs.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++
> arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 77ea547..1bd630a 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -685,6 +685,15 @@
> #include "exynos4412-tmu-sensor-conf.dtsi"
> };
>
> + jpeg-codec@11840000 {
> + compatible = "samsung,exynos4210-jpeg";
> + reg = <0x11840000 0x1000>;
> + interrupts = <0 88 0>;
> + clocks = <&clock CLK_JPEG>;
> + clock-names = "jpeg";
> + samsung,power-domain = <&pd_cam>;
Shouldn't you use the generic "power-domains" property here instead?
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: exynos4: add nodes for jpeg codec
2015-03-05 12:41 ` Javier Martinez Canillas
@ 2015-03-05 12:48 ` Marek Szyprowski
2015-03-05 12:48 ` [PATCH v2] " Marek Szyprowski
1 sibling, 0 replies; 4+ messages in thread
From: Marek Szyprowski @ 2015-03-05 12:48 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim
Hello,
On 2015-03-05 13:41, Javier Martinez Canillas wrote:
> Hello Marek,
>
> Patch looks good to me. Just a small comment below so feel free to add my
>
> Reviewed by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> On Thu, Mar 5, 2015 at 1:28 PM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> This patch adds nodes for hardware JPEG codec found in Exynos 4210 and
>> 4x12 SoCs.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++
>> arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 77ea547..1bd630a 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -685,6 +685,15 @@
>> #include "exynos4412-tmu-sensor-conf.dtsi"
>> };
>>
>> + jpeg-codec@11840000 {
>> + compatible = "samsung,exynos4210-jpeg";
>> + reg = <0x11840000 0x1000>;
>> + interrupts = <0 88 0>;
>> + clocks = <&clock CLK_JPEG>;
>> + clock-names = "jpeg";
>> + samsung,power-domain = <&pd_cam>;
> Shouldn't you use the generic "power-domains" property here instead?
Definitely. I've missed that after rebasing my local tree...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] ARM: dts: exynos4: add nodes for jpeg codec
2015-03-05 12:41 ` Javier Martinez Canillas
2015-03-05 12:48 ` Marek Szyprowski
@ 2015-03-05 12:48 ` Marek Szyprowski
1 sibling, 0 replies; 4+ messages in thread
From: Marek Szyprowski @ 2015-03-05 12:48 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Marek Szyprowski, Kukjin Kim
This patch adds nodes for hardware JPEG codec found in Exynos 4210 and
4x12 SoCs.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++
arch/arm/boot/dts/exynos4x12.dtsi | 4 ++++
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 77ea547..99f110d 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -685,6 +685,15 @@
#include "exynos4412-tmu-sensor-conf.dtsi"
};
+ jpeg-codec@11840000 {
+ compatible = "samsung,exynos4210-jpeg";
+ reg = <0x11840000 0x1000>;
+ interrupts = <0 88 0>;
+ clocks = <&clock CLK_JPEG>;
+ clock-names = "jpeg";
+ power-domains = <&pd_cam>;
+ };
+
hdmi: hdmi@12D00000 {
compatible = "samsung,exynos4210-hdmi";
reg = <0x12D00000 0x70000>;
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 6a6abe1..72b9a1d 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -299,6 +299,10 @@
status = "disabled";
};
+ jpeg-codec@11840000 {
+ compatible = "samsung,exynos4212-jpeg";
+ };
+
hdmi: hdmi@12D00000 {
compatible = "samsung,exynos4212-hdmi";
};
--
1.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-05 12:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-05 12:28 [PATCH] ARM: dts: exynos4: add nodes for jpeg codec Marek Szyprowski
2015-03-05 12:41 ` Javier Martinez Canillas
2015-03-05 12:48 ` Marek Szyprowski
2015-03-05 12:48 ` [PATCH v2] " Marek Szyprowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.