Re: gadgetfs broken since 7f7f25e8

[Alexander Holler <holler@ahsoftware.de>]

Am 04.03.2015 um 16:31 schrieb Alan Stern:

> check to see what those values actually were.  It's easy enough to fix
> up, though; revised patch below.

Thanks, in contrast to the patch from Al Viro that one applies.

I wonder if the patches in the (vfs-)tree he has used as base might fix 
some more problems of gadgetfs I've discovered since I can use it.

In detail it's only usable once (3.19). When unmounting it throws one or 
two warnings because of too much puts (kernel/module.c:963, see below). 
The result is that a subsequent mount afterwards fails because the old 
instance is still busy (Resource temporarily unavailable).

I haven't looked deeper into that problem up to now.

Regards,

Alexander Holler


[  151.425966] gadgetfs: USB Gadget filesystem, version 24 Aug 2004
[  151.479616] gadgetfs: bound to musb-hdrc driver
[  151.781095] gadgetfs: connected
[  151.785871] gadgetfs: disconnected
[  151.864187] gadgetfs: connected
[  151.873258] gadgetfs: configuration #1
[  151.962240] musb_g_ep0_irq 804: SETUP packet len 0 != 8 ?
[  155.065272] input:   USB Keyboard as 
/devices/platform/ocp/47400000.usb/47401c00.usb/musb-hdrc.1.auto/usb2/2-1/2-1:1.0/0003:04D9:1603.0003/input/input2
[  155.119746] hid-generic 0003:04D9:1603.0003: input,hidraw0: USB HID 
v1.10 Keyboard [  USB Keyboard] on usb-musb-hdrc.1.auto-1/input0
[  155.138194] input:   USB Keyboard as 
/devices/platform/ocp/47400000.usb/47401c00.usb/musb-hdrc.1.auto/usb2/2-1/2-1:1.1/0003:04D9:1603.0004/input/input3
[  155.189783] hid-generic 0003:04D9:1603.0004: input,hidraw1: USB HID 
v1.10 Device [  USB Keyboard] on usb-musb-hdrc.1.auto-1/input1
[  155.190002] gadgetfs: disconnected
[  155.190352] ------------[ cut here ]------------
[  155.190389] WARNING: CPU: 0 PID: 1290 at kernel/module.c:963 
module_put+0x54/0x5c()
[  155.190396] Modules linked in: gadgetfs usb_f_ecm usb_f_rndis u_ether 
libcomposite configfs ipv6 bnep bluetooth rfkill hid_generic tda998x 
tilcdc drm_kms_helper ti_cpsw ptp drm usbhid pps_core davinci_cpdma 
omap_mailbox cppi41 [last unloaded: g_ether]
[  155.190459] CPU: 0 PID: 1290 Comm: usb-mitm Not tainted 
3.19.0-bbb-00080-g5e25c2a #246
[  155.190466] Hardware name: Generic AM33XX (Flattened Device Tree)
[  155.190505] [<c00126f0>] (unwind_backtrace) from [<c00108d8>] 
(show_stack+0x10/0x14)
[  155.190527] [<c00108d8>] (show_stack) from [<c002ef74>] 
(warn_slowpath_common+0x80/0xa8)
[  155.190542] [<c002ef74>] (warn_slowpath_common) from [<c002f02c>] 
(warn_slowpath_null+0x18/0x20)
[  155.190556] [<c002f02c>] (warn_slowpath_null) from [<c0069afc>] 
(module_put+0x54/0x5c)
[  155.190581] [<c0069afc>] (module_put) from [<c00c3be0>] 
(deactivate_locked_super+0x4c/0x64)
[  155.190598] [<c00c3be0>] (deactivate_locked_super) from [<c00d8d88>] 
(cleanup_mnt+0x4c/0x6c)
[  155.190614] [<c00d8d88>] (cleanup_mnt) from [<c0041908>] 
(task_work_run+0x8c/0xa4)
[  155.190628] [<c0041908>] (task_work_run) from [<c001059c>] 
(do_work_pending+0x98/0xac)
[  155.190642] [<c001059c>] (do_work_pending) from [<c000dc04>] 
(work_pending+0xc/0x20)
[  155.190649] ---[ end trace c3d57fca714062a3 ]---