All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alexander Holler <holler@ahsoftware.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Richard Weinberger <richard.weinberger@gmail.com>,
	USB list <linux-usb@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Felipe Balbi <balbi@ti.com>
Subject: Re: gadgetfs broken since 7f7f25e8
Date: Sat, 7 Mar 2015 20:51:32 +0000	[thread overview]
Message-ID: <20150307205132.GD29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <54FB59A7.2080705@ahsoftware.de>

On Sat, Mar 07, 2015 at 09:03:51PM +0100, Alexander Holler wrote:
> Am 07.03.2015 um 12:23 schrieb Alexander Holler:
> > Am 04.03.2015 um 16:31 schrieb Alan Stern:
> > 
> >> check to see what those values actually were.  It's easy enough to fix
> >> up, though; revised patch below.
> > 
> > Thanks, in contrast to the patch from Al Viro that one applies.

Translation: it applies to mainline as well as to vfs.git#gadget +
ep_config_operations patch it's incremental to.

> And as I've just tested it, it isn't complete. ep_config_operations will
> be switched to ep_io_operations and suffers under the same problem of
> not having initially (aio_)read/(aio_)write since commit  7f7f25e8 (3.16).

Incremental patch does not deal with the problem handled by the patch
it is incremental to, film at 11...

FWIW, patches in vfs.git#gadget are fixing fairly obvious bugs - leaks and
use-after-free.

  reply	other threads:[~2015-03-07 20:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02  8:28 gadgetfs broken since 7f7f25e8 Alexander Holler
2015-03-02  9:13 ` Richard Weinberger
2015-03-02 10:20   ` Al Viro
2015-03-02 11:39     ` Alexander Holler
2015-03-02 13:02       ` Alexander Holler
2015-03-02 14:31         ` Alexander Holler
2015-03-03  8:39         ` Al Viro
2015-03-03 15:47           ` Alan Stern
2015-03-03 21:42             ` Al Viro
2015-03-04 15:31               ` Alan Stern
2015-03-07 11:23                 ` Alexander Holler
2015-03-07 20:03                   ` Alexander Holler
2015-03-07 20:51                     ` Al Viro [this message]
2015-03-07 20:59                       ` Alexander Holler
2015-03-07 21:08                     ` Alan Stern
2015-03-08 17:38                       ` Al Viro
2015-03-08 18:35                         ` Alan Stern
2015-03-08 19:20                           ` Al Viro
2015-03-10 21:07                           ` Felipe Balbi
2015-03-11 10:29                   ` Alexander Holler
2015-03-11 10:37                     ` Alexander Holler
2015-03-03 22:20             ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150307205132.GD29656@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=balbi@ti.com \
    --cc=holler@ahsoftware.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=richard.weinberger@gmail.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.