From: Larry Finger <Larry.Finger@lwfinger.net>
To: 54FB3523.7060600@lwfinger.net
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock
Date: Sat, 07 Mar 2015 11:44:24 -0600 [thread overview]
Message-ID: <54FB38F8.1080600@lwfinger.net> (raw)
In-Reply-To: <1425749756.11323.5.camel@gmail.com>
On 03/07/2015 11:35 AM, Matteo Semenzato wrote:
> Il giorno sab, 07/03/2015 alle 11.28 -0600, Larry Finger ha scritto:
>> Have you actually tested this patch, or did you find this with some static checker?
>>
>> Larry
> The double unlock was found using smatch.
Are you really willing to test changes in locking based on a static checker? I
would not be so quick.
By the way, my reading of the documentation is that up releases the lock whereas
down sets it. Thus, I think your patch introduces a bug rather than fix one. I
agree that there is a mismatch, but I do not think your patch fixes anything.
Until this is actually tested on running code, NACK.
Larry
next prev parent reply other threads:[~2015-03-07 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 15:33 [PATCH RESEND] Staging: rtl8188eu: fix double unlock Matteo Semenzato
2015-03-07 17:28 ` Larry Finger
2015-03-07 17:35 ` Matteo Semenzato
2015-03-07 17:44 ` Larry Finger [this message]
2015-03-09 9:16 ` Dan Carpenter
2015-03-09 14:21 ` Matteo Semenzato
2015-03-09 14:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FB38F8.1080600@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=54FB3523.7060600@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.