From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jan Beulich <jbeulich@suse.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests
Date: Mon, 9 Mar 2015 10:02:08 +0100 [thread overview]
Message-ID: <54FD6190.20007@citrix.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D1261AEA7B@SHSMSX101.ccr.corp.intel.com>
El 09/03/15 a les 4.30, Tian, Kevin ha escrit:
>> From: Roger Pau Monne [mailto:roger.pau@citrix.com]
>> Sent: Friday, February 27, 2015 7:34 PM
>>
>> iommu_share_p2m_table should not prevent PVH guests from using a shared
>> page
>> table between the IOMMU and EPT. Clean the code by removing the asserts in
>> the vendor specific implementations (amd_iommu_share_p2m,
>> iommu_set_pgd),
>> and moving the hap_enabled assert to the caller (iommu_share_p2m_table).
>>
>> Also fix another incorrect usage of is_hvm_domain usage in
>> arch_iommu_populate_page_table. This has not given problems so far
>> because
>> all the pages in PVH guests are of type PGT_writable_page.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>> Cc: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
>> Cc: Jan Beulich <jbeulich@suse.com>
>> Cc: Yang Zhang <yang.z.zhang@intel.com>
>> Cc: Kevin Tian <kevin.tian@intel.com>
>
> Acked-by: Kevin Tian <kevin.tian@intel.com>
>
> btw, does this patch fix your earlier iommu faults with PVH Dom0?
Yes, it fixes booting a PVH Dom0 on hosts that share the page tables
between EPT and the IOMMU(s).
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-03-09 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 11:33 [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests Roger Pau Monne
2015-03-04 16:53 ` David Vrabel
2015-03-05 9:49 ` Tim Deegan
2015-03-09 3:30 ` Tian, Kevin
2015-03-09 9:02 ` Roger Pau Monné [this message]
2015-03-10 12:51 ` Julien Grall
2015-03-10 13:06 ` Jan Beulich
2015-03-10 13:18 ` Julien Grall
2015-03-10 13:35 ` Jan Beulich
2015-03-11 10:52 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD6190.20007@citrix.com \
--to=roger.pau@citrix.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.