All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Yang Zhang <yang.z.zhang@intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
	Jan Beulich <jbeulich@suse.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests
Date: Wed, 4 Mar 2015 16:53:39 +0000	[thread overview]
Message-ID: <54F73893.2060805@citrix.com> (raw)
In-Reply-To: <1425036812-23536-1-git-send-email-roger.pau@citrix.com>

On 27/02/15 11:33, Roger Pau Monne wrote:
> iommu_share_p2m_table should not prevent PVH guests from using a shared page
> table between the IOMMU and EPT. Clean the code by removing the asserts in
> the vendor specific implementations (amd_iommu_share_p2m, iommu_set_pgd),
> and moving the hap_enabled assert to the caller (iommu_share_p2m_table).
> 
> Also fix another incorrect usage of is_hvm_domain usage in
> arch_iommu_populate_page_table. This has not given problems so far because
> all the pages in PVH guests are of type PGT_writable_page.

dom0 PVH failed to boot on my test system without this patch so:

Tested-by: David Vrabel <david.vrabel@citrix.com>

Thanks.

David

  reply	other threads:[~2015-03-04 16:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 11:33 [PATCH v2] xen/iommu: fix usage of shared EPT/IOMMU page tables on PVH guests Roger Pau Monne
2015-03-04 16:53 ` David Vrabel [this message]
2015-03-05  9:49 ` Tim Deegan
2015-03-09  3:30 ` Tian, Kevin
2015-03-09  9:02   ` Roger Pau Monné
2015-03-10 12:51 ` Julien Grall
2015-03-10 13:06   ` Jan Beulich
2015-03-10 13:18     ` Julien Grall
2015-03-10 13:35       ` Jan Beulich
2015-03-11 10:52         ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F73893.2060805@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=jbeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=roger.pau@citrix.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.