From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: thomas.petazzoni@free-electrons.com,
boris.brezillon@free-electrons.com,
Antoine Tenart <antoine.tenart@free-electrons.com>,
linux-kernel@vger.kernel.org, zmxu@marvell.com,
linux-mtd@lists.infradead.org, jszhang@marvell.com,
computersforpeace@gmail.com, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller
Date: Mon, 09 Mar 2015 08:37:51 -0300 [thread overview]
Message-ID: <54FD860F.2000008@free-electrons.com> (raw)
In-Reply-To: <87ioebxhc7.fsf@free.fr>
On 03/08/2015 07:19 PM, Robert Jarzmik wrote:
> Ezequiel Garcia <ezequiel.garcia@free-electrons.com> writes:
>
>>> I think you'll kill the zylonite board, and I'll nack it if that's the case. At
>>> least that's what happened when I tried to use onfi default values last time in
>>> barebox development.
>>>
>>> I can test your changes, but if the specific zylonite nand (ie. nand id 0xba20,
>>> ie. pxa310 embedded flash) gets broken, I'm against the removal of the legacy
>>> timings removal.
>>>
>>
>> I'm not speaking of any timing params here, but about the flash
>> identification.
>>
>> Which flash do you have there?
> The one with 0xba20 id as I said, which is AFAIK a Numonyx NAND02GR4B2C.
>
$ grep "0xBA" drivers/mtd/nand/nand_ids.c
EXTENDED_ID_NAND("NAND 256MiB 1,8V 16-bit", 0xBA, 256, LP_OPTIONS16),
Seems already supported by the NAND core. The MTD way of probing
a non-ONFI device is by using the IDs in nand_ids.c. Additional
configuration (timings in this case) is applied between the nand_scan_ident()
and nand_scan_tail() calls.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller
Date: Mon, 09 Mar 2015 08:37:51 -0300 [thread overview]
Message-ID: <54FD860F.2000008@free-electrons.com> (raw)
In-Reply-To: <87ioebxhc7.fsf@free.fr>
On 03/08/2015 07:19 PM, Robert Jarzmik wrote:
> Ezequiel Garcia <ezequiel.garcia@free-electrons.com> writes:
>
>>> I think you'll kill the zylonite board, and I'll nack it if that's the case. At
>>> least that's what happened when I tried to use onfi default values last time in
>>> barebox development.
>>>
>>> I can test your changes, but if the specific zylonite nand (ie. nand id 0xba20,
>>> ie. pxa310 embedded flash) gets broken, I'm against the removal of the legacy
>>> timings removal.
>>>
>>
>> I'm not speaking of any timing params here, but about the flash
>> identification.
>>
>> Which flash do you have there?
> The one with 0xba20 id as I said, which is AFAIK a Numonyx NAND02GR4B2C.
>
$ grep "0xBA" drivers/mtd/nand/nand_ids.c
EXTENDED_ID_NAND("NAND 256MiB 1,8V 16-bit", 0xBA, 256, LP_OPTIONS16),
Seems already supported by the NAND core. The MTD way of probing
a non-ONFI device is by using the IDs in nand_ids.c. Additional
configuration (timings in this case) is applied between the nand_scan_ident()
and nand_scan_tail() calls.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com, dwmw2@infradead.org,
computersforpeace@gmail.com, thomas.petazzoni@free-electrons.com,
boris.brezillon@free-electrons.com, linux-kernel@vger.kernel.org,
zmxu@marvell.com, linux-mtd@lists.infradead.org,
jszhang@marvell.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller
Date: Mon, 09 Mar 2015 08:37:51 -0300 [thread overview]
Message-ID: <54FD860F.2000008@free-electrons.com> (raw)
In-Reply-To: <87ioebxhc7.fsf@free.fr>
On 03/08/2015 07:19 PM, Robert Jarzmik wrote:
> Ezequiel Garcia <ezequiel.garcia@free-electrons.com> writes:
>
>>> I think you'll kill the zylonite board, and I'll nack it if that's the case. At
>>> least that's what happened when I tried to use onfi default values last time in
>>> barebox development.
>>>
>>> I can test your changes, but if the specific zylonite nand (ie. nand id 0xba20,
>>> ie. pxa310 embedded flash) gets broken, I'm against the removal of the legacy
>>> timings removal.
>>>
>>
>> I'm not speaking of any timing params here, but about the flash
>> identification.
>>
>> Which flash do you have there?
> The one with 0xba20 id as I said, which is AFAIK a Numonyx NAND02GR4B2C.
>
$ grep "0xBA" drivers/mtd/nand/nand_ids.c
EXTENDED_ID_NAND("NAND 256MiB 1,8V 16-bit", 0xBA, 256, LP_OPTIONS16),
Seems already supported by the NAND core. The MTD way of probing
a non-ONFI device is by using the IDs in nand_ids.c. Additional
configuration (timings in this case) is applied between the nand_scan_ident()
and nand_scan_tail() calls.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-09 11:37 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 11:31 [PATCH v3 0/9] ARM: berlin: add nand support Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` [PATCH v3 1/9] mtd: pxa3xx_nand: add a non mandatory ECC clock Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` [PATCH v3 2/9] Documentation: bindings: document the clocks for pxa3xx-nand Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` [PATCH v3 3/9] mtd: pxa3xx_nand: add a default chunk size Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` [PATCH v3 4/9] mtd: pxa3xx_nand: rework timings setup Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 12:50 ` Thomas Petazzoni
2015-03-05 12:50 ` Thomas Petazzoni
2015-03-05 12:50 ` Thomas Petazzoni
2015-03-05 12:55 ` Antoine Tenart
2015-03-05 12:55 ` Antoine Tenart
2015-03-05 12:55 ` Antoine Tenart
2015-03-09 13:37 ` Ezequiel Garcia
2015-03-09 13:37 ` Ezequiel Garcia
2015-03-09 13:37 ` Ezequiel Garcia
2015-03-05 11:31 ` [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 13:00 ` Thomas Petazzoni
2015-03-05 13:00 ` Thomas Petazzoni
2015-03-05 13:00 ` Thomas Petazzoni
2015-03-05 13:08 ` Antoine Tenart
2015-03-05 13:08 ` Antoine Tenart
2015-03-05 13:08 ` Antoine Tenart
2015-03-07 3:18 ` Ezequiel Garcia
2015-03-07 3:18 ` Ezequiel Garcia
2015-03-07 3:18 ` Ezequiel Garcia
2015-03-08 17:14 ` Robert Jarzmik
2015-03-08 17:14 ` Robert Jarzmik
2015-03-08 17:14 ` Robert Jarzmik
2015-03-08 20:22 ` Ezequiel Garcia
2015-03-08 20:22 ` Ezequiel Garcia
2015-03-08 20:22 ` Ezequiel Garcia
2015-03-08 22:19 ` Robert Jarzmik
2015-03-08 22:19 ` Robert Jarzmik
2015-03-08 22:19 ` Robert Jarzmik
2015-03-09 11:37 ` Ezequiel Garcia [this message]
2015-03-09 11:37 ` Ezequiel Garcia
2015-03-09 11:37 ` Ezequiel Garcia
2015-03-09 20:15 ` Robert Jarzmik
2015-03-09 20:15 ` Robert Jarzmik
2015-03-09 20:15 ` Robert Jarzmik
2015-03-05 11:31 ` [PATCH v3 6/9] Documentation: bindings: add the Berlin nand controller compatible Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` [PATCH v3 7/9] mtd: nand: let Marvell Berlin SoCs select the pxa3xx driver Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` [PATCH v3 8/9] ARM: berlin: add BG2Q node for the nand Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` [PATCH v3 9/9] ARM: berlin: enable flash on the BG2Q DMP Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
2015-03-05 11:31 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD860F.2000008@free-electrons.com \
--to=ezequiel.garcia@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.