All of lore.kernel.org
 help / color / mirror / Atom feed
From: jorge.ramirez-ortiz@linaro.org (Jorge Ramirez-Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [version 2]  amba uarts - arm type uarts fifo size provided by device tree
Date: Mon, 09 Mar 2015 08:25:19 -0400	[thread overview]
Message-ID: <54FD912F.8080403@linaro.org> (raw)
In-Reply-To: <20150303165534.GB10239@leverpostej>

On 03/03/2015 11:55 AM, Mark Rutland wrote:
> On Wed, Feb 18, 2015 at 08:07:47PM +0000, Jorge Ramirez-Ortiz wrote:
>> [PATCH 1/2] Documentation: bindings: add optional fifo size property
>> [PATCH 2/2] drivers/tty: pl011: read fifo size from OF if present [updated]
>>
>> These patches aim at resolving an issue present on some of the amba pl011 uarts.
>>
>> They were developed for the Hisilicon Hi6220 SoC where the fifo size on the
>> uarts is 64 despite the amba revision having been set to 1. 
> Are we certain that the FIFO length is the only difference between the
> HI6220 PL011 and a regular PL011?

you were right.

I just confirmed that there are a number of differences on top of the fifo size
requiring many additional software changes.
This is not great news since the uart announces itself as vendor_arm version 1.

so please discard this patch.

>
> It may be worth adding a compatible string in addition, just in case.
>
> Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [version 2]  amba uarts - arm type uarts fifo size provided by device tree
Date: Mon, 09 Mar 2015 08:25:19 -0400	[thread overview]
Message-ID: <54FD912F.8080403@linaro.org> (raw)
In-Reply-To: <20150303165534.GB10239@leverpostej>

On 03/03/2015 11:55 AM, Mark Rutland wrote:
> On Wed, Feb 18, 2015 at 08:07:47PM +0000, Jorge Ramirez-Ortiz wrote:
>> [PATCH 1/2] Documentation: bindings: add optional fifo size property
>> [PATCH 2/2] drivers/tty: pl011: read fifo size from OF if present [updated]
>>
>> These patches aim at resolving an issue present on some of the amba pl011 uarts.
>>
>> They were developed for the Hisilicon Hi6220 SoC where the fifo size on the
>> uarts is 64 despite the amba revision having been set to 1. 
> Are we certain that the FIFO length is the only difference between the
> HI6220 PL011 and a regular PL011?

you were right.

I just confirmed that there are a number of differences on top of the fifo size
requiring many additional software changes.
This is not great news since the uart announces itself as vendor_arm version 1.

so please discard this patch.

>
> It may be worth adding a compatible string in addition, just in case.
>
> Mark.


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-03-09 12:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <amba uarts - arm type uarts fifo size provided by device tree>
2015-02-18 20:07 ` [version 2] amba uarts - arm type uarts fifo size provided by device tree Jorge Ramirez-Ortiz
2015-02-18 20:07   ` Jorge Ramirez-Ortiz
2015-02-18 20:07   ` [PATCH 1/2] Documentation: bindings: add optional fifo size property to AMBA UARTs Jorge Ramirez-Ortiz
2015-02-18 20:07     ` Jorge Ramirez-Ortiz
2015-02-18 21:17     ` Rob Herring
2015-02-18 21:17       ` Rob Herring
2015-02-18 20:07   ` [PATCH 2/2] drivers/tty: pl011: read fifo size from OF if present Jorge Ramirez-Ortiz
2015-02-18 20:07     ` Jorge Ramirez-Ortiz
2015-03-03 15:39     ` Jorge Ramirez-Ortiz
2015-03-03 15:39       ` Jorge Ramirez-Ortiz
2015-03-03 16:55   ` [version 2] amba uarts - arm type uarts fifo size provided by device tree Mark Rutland
2015-03-03 16:55     ` Mark Rutland
2015-03-04 20:52     ` Jorge Ramirez-Ortiz
2015-03-04 20:52       ` Jorge Ramirez-Ortiz
2015-03-09 12:25     ` Jorge Ramirez-Ortiz [this message]
2015-03-09 12:25       ` Jorge Ramirez-Ortiz
2015-03-09 12:29       ` Russell King - ARM Linux
2015-03-09 12:29         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FD912F.8080403@linaro.org \
    --to=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.