All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Edgar E . Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-trivial] [PATCH] cris: remove unused cris_cond15 declarations
Date: Tue, 10 Mar 2015 10:18:13 +0300	[thread overview]
Message-ID: <54FE9AB5.2040300@msgid.tls.msk.ru> (raw)
In-Reply-To: <54FE996C.2040501@weilnetz.de>

10.03.2015 10:12, Stefan Weil wrote:
[]
> There remains a comment in disas/cris.c referring to cris_conds15. Maybe you
> want to add that to your patch, too (keep my review then).

Oh yeah, I overlooked it.

However maybe we should keep this somehow (maybe in a better comment
in this cris_cc_strings[] place?).  I'll leave this to Edgar.

Meanwhile I updated the patch adding removal of this variable reference
from a comment in cris_cc_strings[] definition.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Edgar E . Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] cris: remove unused cris_cond15 declarations
Date: Tue, 10 Mar 2015 10:18:13 +0300	[thread overview]
Message-ID: <54FE9AB5.2040300@msgid.tls.msk.ru> (raw)
In-Reply-To: <54FE996C.2040501@weilnetz.de>

10.03.2015 10:12, Stefan Weil wrote:
[]
> There remains a comment in disas/cris.c referring to cris_conds15. Maybe you
> want to add that to your patch, too (keep my review then).

Oh yeah, I overlooked it.

However maybe we should keep this somehow (maybe in a better comment
in this cris_cc_strings[] place?).  I'll leave this to Edgar.

Meanwhile I updated the patch adding removal of this variable reference
from a comment in cris_cc_strings[] definition.

Thanks,

/mjt

  reply	other threads:[~2015-03-10  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  5:40 [Qemu-trivial] [PATCH] cris: remove unused cris_cond15 declarations Michael Tokarev
2015-03-10  5:40 ` [Qemu-devel] " Michael Tokarev
2015-03-10  7:12 ` [Qemu-trivial] " Stefan Weil
2015-03-10  7:12   ` [Qemu-devel] " Stefan Weil
2015-03-10  7:18   ` Michael Tokarev [this message]
2015-03-10  7:18     ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FE9AB5.2040300@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.