From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 09/15] ARM: dts: sun4i: Add USB Dual Role Controller
Date: Tue, 10 Mar 2015 10:10:24 +0100 [thread overview]
Message-ID: <54FEB500.8050409@redhat.com> (raw)
In-Reply-To: <CAGRGNgVsf05rtLC2+yOPrbrPV-ceQzPC=ZX1zX+hfNxdC7OX-A@mail.gmail.com>
Hi,
On 10-03-15 00:31, Julian Calaby wrote:
> Hi Hans,
>
> On Tue, Mar 10, 2015 at 7:40 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Add a node for the otg/drc usb controller to sun4i-a10.dtsi.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> arch/arm/boot/dts/sun4i-a10.dtsi | 12 ++++++++++++
>> drivers/usb/musb/Kconfig | 1 +
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>> index 8180a3a..fab8e9a 100644
>> --- a/drivers/usb/musb/Kconfig
>> +++ b/drivers/usb/musb/Kconfig
>> @@ -65,6 +65,7 @@ comment "Platform Glue Layer"
>> config USB_MUSB_SUNXI
>> tristate "Allwinner (sunxi)"
>> depends on ARCH_SUNXI
>> + depends on NOP_USB_XCEIV
>
> Shouldn't this be in a different patch?
Yes, this was a later fixup commit which got squashed into the wrong patch,
thanks for catching this.
This has been fixed in my personal tree, and will be in v2 of this set:
https://github.com/jwrdegoede/linux-sunxi/commits/sunxi-wip
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Julian Calaby
<julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Roman Byshko <rbyshko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Mailing List,
Arm"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 09/15] ARM: dts: sun4i: Add USB Dual Role Controller
Date: Tue, 10 Mar 2015 10:10:24 +0100 [thread overview]
Message-ID: <54FEB500.8050409@redhat.com> (raw)
In-Reply-To: <CAGRGNgVsf05rtLC2+yOPrbrPV-ceQzPC=ZX1zX+hfNxdC7OX-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi,
On 10-03-15 00:31, Julian Calaby wrote:
> Hi Hans,
>
> On Tue, Mar 10, 2015 at 7:40 AM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> Add a node for the otg/drc usb controller to sun4i-a10.dtsi.
>>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> arch/arm/boot/dts/sun4i-a10.dtsi | 12 ++++++++++++
>> drivers/usb/musb/Kconfig | 1 +
>> 2 files changed, 13 insertions(+)
>>
>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>> index 8180a3a..fab8e9a 100644
>> --- a/drivers/usb/musb/Kconfig
>> +++ b/drivers/usb/musb/Kconfig
>> @@ -65,6 +65,7 @@ comment "Platform Glue Layer"
>> config USB_MUSB_SUNXI
>> tristate "Allwinner (sunxi)"
>> depends on ARCH_SUNXI
>> + depends on NOP_USB_XCEIV
>
> Shouldn't this be in a different patch?
Yes, this was a later fixup commit which got squashed into the wrong patch,
thanks for catching this.
This has been fixed in my personal tree, and will be in v2 of this set:
https://github.com/jwrdegoede/linux-sunxi/commits/sunxi-wip
Regards,
Hans
next prev parent reply other threads:[~2015-03-10 9:10 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:40 [PATCH 00/15] musb: Add support for the Allwinner sunxi musb controller Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 01/15] ARM: sunxi: Add register bit definitions for SRAM mapping syscon Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 02/15] phy-sun4i-usb: Add a helper function to update the iscr register Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 21:47 ` Arnd Bergmann
2015-03-09 21:47 ` Arnd Bergmann
2015-03-10 8:04 ` Hans de Goede
2015-03-10 8:04 ` Hans de Goede
2015-03-10 8:57 ` Arnd Bergmann
2015-03-10 8:57 ` Arnd Bergmann
2015-03-10 10:13 ` Hans de Goede
2015-03-10 10:13 ` Hans de Goede
2015-03-10 10:53 ` Kishon Vijay Abraham I
2015-03-10 10:53 ` Kishon Vijay Abraham I
2015-03-10 11:03 ` Hans de Goede
2015-03-10 11:03 ` Hans de Goede
2015-03-11 9:13 ` Kishon Vijay Abraham I
2015-03-11 9:13 ` Kishon Vijay Abraham I
2015-03-11 11:39 ` Hans de Goede
2015-03-11 11:39 ` Hans de Goede
2015-03-11 12:50 ` Kishon Vijay Abraham I
2015-03-11 12:50 ` Kishon Vijay Abraham I
2015-03-11 13:03 ` Hans de Goede
2015-03-11 13:03 ` Hans de Goede
2015-03-11 13:07 ` Kishon Vijay Abraham I
2015-03-11 13:07 ` Kishon Vijay Abraham I
2015-03-11 14:44 ` Hans de Goede
2015-03-11 14:44 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 03/15] musb: Make musb_write_rxfun* and musb_write_rxhub* work like their tx versions Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 04/15] musb: Make busctl_offset an io-op rather then a define Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 05/15] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 21:50 ` Arnd Bergmann
2015-03-09 21:50 ` Arnd Bergmann
2015-03-10 7:43 ` Hans de Goede
2015-03-10 7:43 ` Hans de Goede
2015-03-10 8:50 ` Arnd Bergmann
2015-03-10 8:50 ` Arnd Bergmann
2015-03-10 8:56 ` Hans de Goede
2015-03-10 8:56 ` Hans de Goede
2015-03-10 13:43 ` Arnd Bergmann
2015-03-10 13:43 ` Arnd Bergmann
2015-03-09 20:40 ` [PATCH 06/15] musb: Fix platform code being unable to override ep access ops Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 07/15] musb: Add support for the Allwinner sunxi musb controller Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 08/15] ARM: dts: sunxi: Add syscon node for controlling SRAM mapping Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 09/15] ARM: dts: sun4i: Add USB Dual Role Controller Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 23:31 ` [linux-sunxi] " Julian Calaby
2015-03-09 23:31 ` Julian Calaby
2015-03-10 9:10 ` Hans de Goede [this message]
2015-03-10 9:10 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 10/15] ARM: dts: sun5i: " Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 11/15] ARM: dts: sun7i: " Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 12/15] ARM: dts: sun4i: Enable USB DRC on Chuwi V7 CW0825 Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-10 15:07 ` Maxime Ripard
2015-03-10 15:07 ` Maxime Ripard
2015-03-10 15:23 ` Hans de Goede
2015-03-10 15:23 ` Hans de Goede
2015-03-10 18:17 ` Maxime Ripard
2015-03-10 18:17 ` Maxime Ripard
2015-03-09 20:40 ` [PATCH 13/15] ARM: dts: sun5i: Enable USB DRC on UTOO P66 Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 14/15] ARM: dts: sun7i: Enable USB DRC on Cubietruck Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 20:40 ` [PATCH 15/15] ARM: dts: sun7i: Enable USB DRC on A20-OLinuxIno-Lime Hans de Goede
2015-03-09 20:40 ` Hans de Goede
2015-03-09 21:44 ` [PATCH 00/15] musb: Add support for the Allwinner sunxi musb controller Arnd Bergmann
2015-03-09 21:44 ` Arnd Bergmann
2015-03-10 1:46 ` Chen-Yu Tsai
2015-03-10 1:46 ` Chen-Yu Tsai
2015-03-10 7:38 ` Hans de Goede
2015-03-10 7:38 ` Hans de Goede
2015-03-10 8:31 ` Arnd Bergmann
2015-03-10 8:31 ` Arnd Bergmann
2015-03-10 17:41 ` Maxime Ripard
2015-03-10 17:41 ` Maxime Ripard
2015-03-10 22:35 ` Hans de Goede
2015-03-10 22:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FEB500.8050409@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.