All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org
Cc: Jean Delvare <jdelvare@suse.de>, Simon Guinot <sguinot@lacie.com>
Subject: Re: [lm-sensors] [PATCH -next] hwmon: fix gpio-fan.c build
Date: Wed, 11 Mar 2015 02:14:19 +0000	[thread overview]
Message-ID: <54FFA4FB.80007@roeck-us.net> (raw)
In-Reply-To: <54FF8171.9080101@infradead.org>

On 03/10/2015 04:42 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y
> by preventing that combination.
>
> Fixes these build errors:
>
> drivers/built-in.o: In function `gpio_fan_remove':
> gpio-fan.c:(.text+0x21e97e): undefined reference to `thermal_cooling_device_unregister'
> drivers/built-in.o: In function `gpio_fan_probe':
> gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:	Jean Delvare <jdelvare@suse.de>
> Cc:	Guenter Roeck <linux@roeck-us.net>
> Cc:	lm-sensors@lm-sensors.org
> Cc:	Simon Guinot <sguinot@lacie.com>
> ---
>   drivers/hwmon/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20150310.orig/drivers/hwmon/Kconfig
> +++ linux-next-20150310/drivers/hwmon/Kconfig
> @@ -510,6 +510,7 @@ config SENSORS_G762
>   config SENSORS_GPIO_FAN
>   	tristate "GPIO fan"
>   	depends on GPIOLIB
> +	depends on THERMAL || THERMAL=n
>   	help
>   	  If you say yes here you get support for fans connected to GPIO lines.
>
>
Applied, thanks.

I really have to add that combination to my build tests :-(

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org
Cc: Jean Delvare <jdelvare@suse.de>, Simon Guinot <sguinot@lacie.com>
Subject: Re: [PATCH -next] hwmon: fix gpio-fan.c build
Date: Tue, 10 Mar 2015 19:14:19 -0700	[thread overview]
Message-ID: <54FFA4FB.80007@roeck-us.net> (raw)
In-Reply-To: <54FF8171.9080101@infradead.org>

On 03/10/2015 04:42 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error when CONFIG_THERMAL=m and SENSORS_GPIO_FAN=y
> by preventing that combination.
>
> Fixes these build errors:
>
> drivers/built-in.o: In function `gpio_fan_remove':
> gpio-fan.c:(.text+0x21e97e): undefined reference to `thermal_cooling_device_unregister'
> drivers/built-in.o: In function `gpio_fan_probe':
> gpio-fan.c:(.text+0x21efbc): undefined reference to `thermal_cooling_device_register'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:	Jean Delvare <jdelvare@suse.de>
> Cc:	Guenter Roeck <linux@roeck-us.net>
> Cc:	lm-sensors@lm-sensors.org
> Cc:	Simon Guinot <sguinot@lacie.com>
> ---
>   drivers/hwmon/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20150310.orig/drivers/hwmon/Kconfig
> +++ linux-next-20150310/drivers/hwmon/Kconfig
> @@ -510,6 +510,7 @@ config SENSORS_G762
>   config SENSORS_GPIO_FAN
>   	tristate "GPIO fan"
>   	depends on GPIOLIB
> +	depends on THERMAL || THERMAL=n
>   	help
>   	  If you say yes here you get support for fans connected to GPIO lines.
>
>
Applied, thanks.

I really have to add that combination to my build tests :-(

Guenter


  reply	other threads:[~2015-03-11  2:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 23:42 [lm-sensors] [PATCH -next] hwmon: fix gpio-fan.c build Randy Dunlap
2015-03-10 23:42 ` Randy Dunlap
2015-03-11  2:14 ` Guenter Roeck [this message]
2015-03-11  2:14   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FFA4FB.80007@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rdunlap@infradead.org \
    --cc=sguinot@lacie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.