* [PATCH v2 1/2] Documentation: update the of_selftest.txt @ 2015-03-09 2:35 ` Wang Long 0 siblings, 0 replies; 11+ messages in thread From: Wang Long @ 2015-03-09 2:35 UTC (permalink / raw) To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w, robherring2-Re5JQEeQqe8AvxtiuMwx3w Cc: pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, long.wanglong-hv44wF8Li93QT0dZR+AlfA, peifeiyue-hv44wF8Li93QT0dZR+AlfA Since the directory "drivers/of/testcase-data" is renamed to "drivers/of/unittest-data". so we should update the path in the of_selftest.txt. When the kernel is built with OF_SELFUNIT enabled, the output dtb is testcases.dtb instead of testcase.dtb, also update it (s/testcase/testcases/). Signed-off-by: Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> --- Documentation/devicetree/of_selftest.txt | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt index 57a808b..3e4e7d4 100644 --- a/Documentation/devicetree/of_selftest.txt +++ b/Documentation/devicetree/of_selftest.txt @@ -1,11 +1,11 @@ -Open Firmware Device Tree Selftest +Open Firmware Device Tree Unittest ---------------------------------- Author: Gaurav Minocha <gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 1. Introduction -This document explains how the test data required for executing OF selftest +This document explains how the test data required for executing OF unittest is attached to the live tree dynamically, independent of the machine's architecture. @@ -22,31 +22,31 @@ most of the device drivers in various use cases. 2. Test-data -The Device Tree Source file (drivers/of/testcase-data/testcases.dts) contains +The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains the test data required for executing the unit tests automated in -drivers/of/selftests.c. Currently, following Device Tree Source Include files -(.dtsi) are included in testcase.dts: +drivers/of/unittest.c. Currently, following Device Tree Source Include files +(.dtsi) are included in testcases.dts: -drivers/of/testcase-data/tests-interrupts.dtsi -drivers/of/testcase-data/tests-platform.dtsi -drivers/of/testcase-data/tests-phandle.dtsi -drivers/of/testcase-data/tests-match.dtsi +drivers/of/unittest-data/tests-interrupts.dtsi +drivers/of/unittest-data/tests-platform.dtsi +drivers/of/unittest-data/tests-phandle.dtsi +drivers/of/unittest-data/tests-match.dtsi When the kernel is build with OF_SELFTEST enabled, then the following make rule $(obj)/%.dtb: $(src)/%.dts FORCE $(call if_changed_dep, dtc) -is used to compile the DT source file (testcase.dts) into a binary blob -(testcase.dtb), also referred as flattened DT. +is used to compile the DT source file (testcases.dts) into a binary blob +(testcases.dtb), also referred as flattened DT. After that, using the following rule the binary blob above is wrapped as an -assembly file (testcase.dtb.S). +assembly file (testcases.dtb.S). $(obj)/%.dtb.S: $(obj)/%.dtb $(call cmd, dt_S_dtb) -The assembly file is compiled into an object file (testcase.dtb.o), and is +The assembly file is compiled into an object file (testcases.dtb.o), and is linked into the kernel image. @@ -98,7 +98,7 @@ child11 -> sibling12 -> sibling13 -> sibling14 -> null Figure 1: Generic structure of un-flattened device tree -Before executing OF selftest, it is required to attach the test data to +Before executing OF unittest, it is required to attach the test data to machine's device tree (if present). So, when selftest_data_add() is called, at first it reads the flattened device tree data linked into the kernel image via the following kernel symbols: -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 1/2] Documentation: update the of_selftest.txt @ 2015-03-09 2:35 ` Wang Long 0 siblings, 0 replies; 11+ messages in thread From: Wang Long @ 2015-03-09 2:35 UTC (permalink / raw) To: robh+dt, gaurav.minocha.os, robherring2 Cc: pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, linux-kernel, long.wanglong, peifeiyue Since the directory "drivers/of/testcase-data" is renamed to "drivers/of/unittest-data". so we should update the path in the of_selftest.txt. When the kernel is built with OF_SELFUNIT enabled, the output dtb is testcases.dtb instead of testcase.dtb, also update it (s/testcase/testcases/). Signed-off-by: Wang Long <long.wanglong@huawei.com> --- Documentation/devicetree/of_selftest.txt | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt index 57a808b..3e4e7d4 100644 --- a/Documentation/devicetree/of_selftest.txt +++ b/Documentation/devicetree/of_selftest.txt @@ -1,11 +1,11 @@ -Open Firmware Device Tree Selftest +Open Firmware Device Tree Unittest ---------------------------------- Author: Gaurav Minocha <gaurav.minocha.os@gmail.com> 1. Introduction -This document explains how the test data required for executing OF selftest +This document explains how the test data required for executing OF unittest is attached to the live tree dynamically, independent of the machine's architecture. @@ -22,31 +22,31 @@ most of the device drivers in various use cases. 2. Test-data -The Device Tree Source file (drivers/of/testcase-data/testcases.dts) contains +The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains the test data required for executing the unit tests automated in -drivers/of/selftests.c. Currently, following Device Tree Source Include files -(.dtsi) are included in testcase.dts: +drivers/of/unittest.c. Currently, following Device Tree Source Include files +(.dtsi) are included in testcases.dts: -drivers/of/testcase-data/tests-interrupts.dtsi -drivers/of/testcase-data/tests-platform.dtsi -drivers/of/testcase-data/tests-phandle.dtsi -drivers/of/testcase-data/tests-match.dtsi +drivers/of/unittest-data/tests-interrupts.dtsi +drivers/of/unittest-data/tests-platform.dtsi +drivers/of/unittest-data/tests-phandle.dtsi +drivers/of/unittest-data/tests-match.dtsi When the kernel is build with OF_SELFTEST enabled, then the following make rule $(obj)/%.dtb: $(src)/%.dts FORCE $(call if_changed_dep, dtc) -is used to compile the DT source file (testcase.dts) into a binary blob -(testcase.dtb), also referred as flattened DT. +is used to compile the DT source file (testcases.dts) into a binary blob +(testcases.dtb), also referred as flattened DT. After that, using the following rule the binary blob above is wrapped as an -assembly file (testcase.dtb.S). +assembly file (testcases.dtb.S). $(obj)/%.dtb.S: $(obj)/%.dtb $(call cmd, dt_S_dtb) -The assembly file is compiled into an object file (testcase.dtb.o), and is +The assembly file is compiled into an object file (testcases.dtb.o), and is linked into the kernel image. @@ -98,7 +98,7 @@ child11 -> sibling12 -> sibling13 -> sibling14 -> null Figure 1: Generic structure of un-flattened device tree -Before executing OF selftest, it is required to attach the test data to +Before executing OF unittest, it is required to attach the test data to machine's device tree (if present). So, when selftest_data_add() is called, at first it reads the flattened device tree data linked into the kernel image via the following kernel symbols: -- 1.8.3.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] Documentation: rename of_selftest.txt to of_unittest.txt 2015-03-09 2:35 ` Wang Long @ 2015-03-09 2:35 ` Wang Long -1 siblings, 0 replies; 11+ messages in thread From: Wang Long @ 2015-03-09 2:35 UTC (permalink / raw) To: robh+dt, gaurav.minocha.os, robherring2 Cc: pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, linux-kernel, long.wanglong, peifeiyue Since the test of the devicetree's OF api use unittest as its name. so we should rename of_selftest.txt to of_unittest.txt. Signed-off-by: Wang Long <long.wanglong@huawei.com> --- Documentation/devicetree/of_selftest.txt | 197 ------------------------------- Documentation/devicetree/of_unittest.txt | 197 +++++++++++++++++++++++++++++++ 2 files changed, 197 insertions(+), 197 deletions(-) delete mode 100644 Documentation/devicetree/of_selftest.txt create mode 100644 Documentation/devicetree/of_unittest.txt diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt deleted file mode 100644 index 3e4e7d4..0000000 --- a/Documentation/devicetree/of_selftest.txt +++ /dev/null @@ -1,197 +0,0 @@ -Open Firmware Device Tree Unittest ----------------------------------- - -Author: Gaurav Minocha <gaurav.minocha.os@gmail.com> - -1. Introduction - -This document explains how the test data required for executing OF unittest -is attached to the live tree dynamically, independent of the machine's -architecture. - -It is recommended to read the following documents before moving ahead. - -[1] Documentation/devicetree/usage-model.txt -[2] http://www.devicetree.org/Device_Tree_Usage - -OF Selftest has been designed to test the interface (include/linux/of.h) -provided to device driver developers to fetch the device information..etc. -from the unflattened device tree data structure. This interface is used by -most of the device drivers in various use cases. - - -2. Test-data - -The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains -the test data required for executing the unit tests automated in -drivers/of/unittest.c. Currently, following Device Tree Source Include files -(.dtsi) are included in testcases.dts: - -drivers/of/unittest-data/tests-interrupts.dtsi -drivers/of/unittest-data/tests-platform.dtsi -drivers/of/unittest-data/tests-phandle.dtsi -drivers/of/unittest-data/tests-match.dtsi - -When the kernel is build with OF_SELFTEST enabled, then the following make rule - -$(obj)/%.dtb: $(src)/%.dts FORCE - $(call if_changed_dep, dtc) - -is used to compile the DT source file (testcases.dts) into a binary blob -(testcases.dtb), also referred as flattened DT. - -After that, using the following rule the binary blob above is wrapped as an -assembly file (testcases.dtb.S). - -$(obj)/%.dtb.S: $(obj)/%.dtb - $(call cmd, dt_S_dtb) - -The assembly file is compiled into an object file (testcases.dtb.o), and is -linked into the kernel image. - - -2.1. Adding the test data - -Un-flattened device tree structure: - -Un-flattened device tree consists of connected device_node(s) in form of a tree -structure described below. - -// following struct members are used to construct the tree -struct device_node { - ... - struct device_node *parent; - struct device_node *child; - struct device_node *sibling; - ... - }; - -Figure 1, describes a generic structure of machine's un-flattened device tree -considering only child and sibling pointers. There exists another pointer, -*parent, that is used to traverse the tree in the reverse direction. So, at -a particular level the child node and all the sibling nodes will have a parent -pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4's -parent points to root node) - -root ('/') - | -child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | - | | | null - | | | - | | child31 -> sibling32 -> null - | | | | - | | null null - | | - | child21 -> sibling22 -> sibling23 -> null - | | | | - | null null null - | -child11 -> sibling12 -> sibling13 -> sibling14 -> null - | | | | - | | | null - | | | - null null child131 -> null - | - null - -Figure 1: Generic structure of un-flattened device tree - - -Before executing OF unittest, it is required to attach the test data to -machine's device tree (if present). So, when selftest_data_add() is called, -at first it reads the flattened device tree data linked into the kernel image -via the following kernel symbols: - -__dtb_testcases_begin - address marking the start of test data blob -__dtb_testcases_end - address marking the end of test data blob - -Secondly, it calls of_fdt_unflatten_tree() to unflatten the flattened -blob. And finally, if the machine's device tree (i.e live tree) is present, -then it attaches the unflattened test data tree to the live tree, else it -attaches itself as a live device tree. - -attach_node_and_children() uses of_attach_node() to attach the nodes into the -live tree as explained below. To explain the same, the test data tree described - in Figure 2 is attached to the live tree described in Figure 1. - -root ('/') - | - testcase-data - | - test-child0 -> test-sibling1 -> test-sibling2 -> test-sibling3 -> null - | | | | - test-child01 null null null - - -Figure 2: Example test data tree to be attached to live tree. - -According to the scenario above, the live tree is already present so it isn't -required to attach the root('/') node. All other nodes are attached by calling -of_attach_node() on each node. - -In the function of_attach_node(), the new node is attached as the child of the -given parent in live tree. But, if parent already has a child then the new node -replaces the current child and turns it into its sibling. So, when the testcase -data node is attached to the live tree above (Figure 1), the final structure is - as shown in Figure 3. - -root ('/') - | -testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | | - (...) | | | null - | | child31 -> sibling32 -> null - | | | | - | | null null - | | - | child21 -> sibling22 -> sibling23 -> null - | | | | - | null null null - | - child11 -> sibling12 -> sibling13 -> sibling14 -> null - | | | | - null null | null - | - child131 -> null - | - null ------------------------------------------------------------------------ - -root ('/') - | -testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | | - | (...) (...) (...) null - | -test-sibling3 -> test-sibling2 -> test-sibling1 -> test-child0 -> null - | | | | - null null null test-child01 - - -Figure 3: Live device tree structure after attaching the testcase-data. - - -Astute readers would have noticed that test-child0 node becomes the last -sibling compared to the earlier structure (Figure 2). After attaching first -test-child0 the test-sibling1 is attached that pushes the child node -(i.e. test-child0) to become a sibling and makes itself a child node, - as mentioned above. - -If a duplicate node is found (i.e. if a node with same full_name property is -already present in the live tree), then the node isn't attached rather its -properties are updated to the live tree's node by calling the function -update_node_properties(). - - -2.2. Removing the test data - -Once the test case execution is complete, selftest_data_remove is called in -order to remove the device nodes attached initially (first the leaf nodes are -detached and then moving up the parent nodes are removed, and eventually the -whole tree). selftest_data_remove() calls detach_node_and_children() that uses -of_detach_node() to detach the nodes from the live device tree. - -To detach a node, of_detach_node() either updates the child pointer of given -node's parent to its sibling or attaches the previous sibling to the given -node's sibling, as appropriate. That is it :) diff --git a/Documentation/devicetree/of_unittest.txt b/Documentation/devicetree/of_unittest.txt new file mode 100644 index 0000000..3e4e7d4 --- /dev/null +++ b/Documentation/devicetree/of_unittest.txt @@ -0,0 +1,197 @@ +Open Firmware Device Tree Unittest +---------------------------------- + +Author: Gaurav Minocha <gaurav.minocha.os@gmail.com> + +1. Introduction + +This document explains how the test data required for executing OF unittest +is attached to the live tree dynamically, independent of the machine's +architecture. + +It is recommended to read the following documents before moving ahead. + +[1] Documentation/devicetree/usage-model.txt +[2] http://www.devicetree.org/Device_Tree_Usage + +OF Selftest has been designed to test the interface (include/linux/of.h) +provided to device driver developers to fetch the device information..etc. +from the unflattened device tree data structure. This interface is used by +most of the device drivers in various use cases. + + +2. Test-data + +The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains +the test data required for executing the unit tests automated in +drivers/of/unittest.c. Currently, following Device Tree Source Include files +(.dtsi) are included in testcases.dts: + +drivers/of/unittest-data/tests-interrupts.dtsi +drivers/of/unittest-data/tests-platform.dtsi +drivers/of/unittest-data/tests-phandle.dtsi +drivers/of/unittest-data/tests-match.dtsi + +When the kernel is build with OF_SELFTEST enabled, then the following make rule + +$(obj)/%.dtb: $(src)/%.dts FORCE + $(call if_changed_dep, dtc) + +is used to compile the DT source file (testcases.dts) into a binary blob +(testcases.dtb), also referred as flattened DT. + +After that, using the following rule the binary blob above is wrapped as an +assembly file (testcases.dtb.S). + +$(obj)/%.dtb.S: $(obj)/%.dtb + $(call cmd, dt_S_dtb) + +The assembly file is compiled into an object file (testcases.dtb.o), and is +linked into the kernel image. + + +2.1. Adding the test data + +Un-flattened device tree structure: + +Un-flattened device tree consists of connected device_node(s) in form of a tree +structure described below. + +// following struct members are used to construct the tree +struct device_node { + ... + struct device_node *parent; + struct device_node *child; + struct device_node *sibling; + ... + }; + +Figure 1, describes a generic structure of machine's un-flattened device tree +considering only child and sibling pointers. There exists another pointer, +*parent, that is used to traverse the tree in the reverse direction. So, at +a particular level the child node and all the sibling nodes will have a parent +pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4's +parent points to root node) + +root ('/') + | +child1 -> sibling2 -> sibling3 -> sibling4 -> null + | | | | + | | | null + | | | + | | child31 -> sibling32 -> null + | | | | + | | null null + | | + | child21 -> sibling22 -> sibling23 -> null + | | | | + | null null null + | +child11 -> sibling12 -> sibling13 -> sibling14 -> null + | | | | + | | | null + | | | + null null child131 -> null + | + null + +Figure 1: Generic structure of un-flattened device tree + + +Before executing OF unittest, it is required to attach the test data to +machine's device tree (if present). So, when selftest_data_add() is called, +at first it reads the flattened device tree data linked into the kernel image +via the following kernel symbols: + +__dtb_testcases_begin - address marking the start of test data blob +__dtb_testcases_end - address marking the end of test data blob + +Secondly, it calls of_fdt_unflatten_tree() to unflatten the flattened +blob. And finally, if the machine's device tree (i.e live tree) is present, +then it attaches the unflattened test data tree to the live tree, else it +attaches itself as a live device tree. + +attach_node_and_children() uses of_attach_node() to attach the nodes into the +live tree as explained below. To explain the same, the test data tree described + in Figure 2 is attached to the live tree described in Figure 1. + +root ('/') + | + testcase-data + | + test-child0 -> test-sibling1 -> test-sibling2 -> test-sibling3 -> null + | | | | + test-child01 null null null + + +Figure 2: Example test data tree to be attached to live tree. + +According to the scenario above, the live tree is already present so it isn't +required to attach the root('/') node. All other nodes are attached by calling +of_attach_node() on each node. + +In the function of_attach_node(), the new node is attached as the child of the +given parent in live tree. But, if parent already has a child then the new node +replaces the current child and turns it into its sibling. So, when the testcase +data node is attached to the live tree above (Figure 1), the final structure is + as shown in Figure 3. + +root ('/') + | +testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null + | | | | | + (...) | | | null + | | child31 -> sibling32 -> null + | | | | + | | null null + | | + | child21 -> sibling22 -> sibling23 -> null + | | | | + | null null null + | + child11 -> sibling12 -> sibling13 -> sibling14 -> null + | | | | + null null | null + | + child131 -> null + | + null +----------------------------------------------------------------------- + +root ('/') + | +testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null + | | | | | + | (...) (...) (...) null + | +test-sibling3 -> test-sibling2 -> test-sibling1 -> test-child0 -> null + | | | | + null null null test-child01 + + +Figure 3: Live device tree structure after attaching the testcase-data. + + +Astute readers would have noticed that test-child0 node becomes the last +sibling compared to the earlier structure (Figure 2). After attaching first +test-child0 the test-sibling1 is attached that pushes the child node +(i.e. test-child0) to become a sibling and makes itself a child node, + as mentioned above. + +If a duplicate node is found (i.e. if a node with same full_name property is +already present in the live tree), then the node isn't attached rather its +properties are updated to the live tree's node by calling the function +update_node_properties(). + + +2.2. Removing the test data + +Once the test case execution is complete, selftest_data_remove is called in +order to remove the device nodes attached initially (first the leaf nodes are +detached and then moving up the parent nodes are removed, and eventually the +whole tree). selftest_data_remove() calls detach_node_and_children() that uses +of_detach_node() to detach the nodes from the live device tree. + +To detach a node, of_detach_node() either updates the child pointer of given +node's parent to its sibling or attaches the previous sibling to the given +node's sibling, as appropriate. That is it :) -- 1.8.3.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] Documentation: rename of_selftest.txt to of_unittest.txt @ 2015-03-09 2:35 ` Wang Long 0 siblings, 0 replies; 11+ messages in thread From: Wang Long @ 2015-03-09 2:35 UTC (permalink / raw) To: robh+dt, gaurav.minocha.os, robherring2 Cc: pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree, linux-kernel, long.wanglong, peifeiyue Since the test of the devicetree's OF api use unittest as its name. so we should rename of_selftest.txt to of_unittest.txt. Signed-off-by: Wang Long <long.wanglong@huawei.com> --- Documentation/devicetree/of_selftest.txt | 197 ------------------------------- Documentation/devicetree/of_unittest.txt | 197 +++++++++++++++++++++++++++++++ 2 files changed, 197 insertions(+), 197 deletions(-) delete mode 100644 Documentation/devicetree/of_selftest.txt create mode 100644 Documentation/devicetree/of_unittest.txt diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt deleted file mode 100644 index 3e4e7d4..0000000 --- a/Documentation/devicetree/of_selftest.txt +++ /dev/null @@ -1,197 +0,0 @@ -Open Firmware Device Tree Unittest ----------------------------------- - -Author: Gaurav Minocha <gaurav.minocha.os@gmail.com> - -1. Introduction - -This document explains how the test data required for executing OF unittest -is attached to the live tree dynamically, independent of the machine's -architecture. - -It is recommended to read the following documents before moving ahead. - -[1] Documentation/devicetree/usage-model.txt -[2] http://www.devicetree.org/Device_Tree_Usage - -OF Selftest has been designed to test the interface (include/linux/of.h) -provided to device driver developers to fetch the device information..etc. -from the unflattened device tree data structure. This interface is used by -most of the device drivers in various use cases. - - -2. Test-data - -The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains -the test data required for executing the unit tests automated in -drivers/of/unittest.c. Currently, following Device Tree Source Include files -(.dtsi) are included in testcases.dts: - -drivers/of/unittest-data/tests-interrupts.dtsi -drivers/of/unittest-data/tests-platform.dtsi -drivers/of/unittest-data/tests-phandle.dtsi -drivers/of/unittest-data/tests-match.dtsi - -When the kernel is build with OF_SELFTEST enabled, then the following make rule - -$(obj)/%.dtb: $(src)/%.dts FORCE - $(call if_changed_dep, dtc) - -is used to compile the DT source file (testcases.dts) into a binary blob -(testcases.dtb), also referred as flattened DT. - -After that, using the following rule the binary blob above is wrapped as an -assembly file (testcases.dtb.S). - -$(obj)/%.dtb.S: $(obj)/%.dtb - $(call cmd, dt_S_dtb) - -The assembly file is compiled into an object file (testcases.dtb.o), and is -linked into the kernel image. - - -2.1. Adding the test data - -Un-flattened device tree structure: - -Un-flattened device tree consists of connected device_node(s) in form of a tree -structure described below. - -// following struct members are used to construct the tree -struct device_node { - ... - struct device_node *parent; - struct device_node *child; - struct device_node *sibling; - ... - }; - -Figure 1, describes a generic structure of machine's un-flattened device tree -considering only child and sibling pointers. There exists another pointer, -*parent, that is used to traverse the tree in the reverse direction. So, at -a particular level the child node and all the sibling nodes will have a parent -pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4's -parent points to root node) - -root ('/') - | -child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | - | | | null - | | | - | | child31 -> sibling32 -> null - | | | | - | | null null - | | - | child21 -> sibling22 -> sibling23 -> null - | | | | - | null null null - | -child11 -> sibling12 -> sibling13 -> sibling14 -> null - | | | | - | | | null - | | | - null null child131 -> null - | - null - -Figure 1: Generic structure of un-flattened device tree - - -Before executing OF unittest, it is required to attach the test data to -machine's device tree (if present). So, when selftest_data_add() is called, -at first it reads the flattened device tree data linked into the kernel image -via the following kernel symbols: - -__dtb_testcases_begin - address marking the start of test data blob -__dtb_testcases_end - address marking the end of test data blob - -Secondly, it calls of_fdt_unflatten_tree() to unflatten the flattened -blob. And finally, if the machine's device tree (i.e live tree) is present, -then it attaches the unflattened test data tree to the live tree, else it -attaches itself as a live device tree. - -attach_node_and_children() uses of_attach_node() to attach the nodes into the -live tree as explained below. To explain the same, the test data tree described - in Figure 2 is attached to the live tree described in Figure 1. - -root ('/') - | - testcase-data - | - test-child0 -> test-sibling1 -> test-sibling2 -> test-sibling3 -> null - | | | | - test-child01 null null null - - -Figure 2: Example test data tree to be attached to live tree. - -According to the scenario above, the live tree is already present so it isn't -required to attach the root('/') node. All other nodes are attached by calling -of_attach_node() on each node. - -In the function of_attach_node(), the new node is attached as the child of the -given parent in live tree. But, if parent already has a child then the new node -replaces the current child and turns it into its sibling. So, when the testcase -data node is attached to the live tree above (Figure 1), the final structure is - as shown in Figure 3. - -root ('/') - | -testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | | - (...) | | | null - | | child31 -> sibling32 -> null - | | | | - | | null null - | | - | child21 -> sibling22 -> sibling23 -> null - | | | | - | null null null - | - child11 -> sibling12 -> sibling13 -> sibling14 -> null - | | | | - null null | null - | - child131 -> null - | - null ------------------------------------------------------------------------ - -root ('/') - | -testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null - | | | | | - | (...) (...) (...) null - | -test-sibling3 -> test-sibling2 -> test-sibling1 -> test-child0 -> null - | | | | - null null null test-child01 - - -Figure 3: Live device tree structure after attaching the testcase-data. - - -Astute readers would have noticed that test-child0 node becomes the last -sibling compared to the earlier structure (Figure 2). After attaching first -test-child0 the test-sibling1 is attached that pushes the child node -(i.e. test-child0) to become a sibling and makes itself a child node, - as mentioned above. - -If a duplicate node is found (i.e. if a node with same full_name property is -already present in the live tree), then the node isn't attached rather its -properties are updated to the live tree's node by calling the function -update_node_properties(). - - -2.2. Removing the test data - -Once the test case execution is complete, selftest_data_remove is called in -order to remove the device nodes attached initially (first the leaf nodes are -detached and then moving up the parent nodes are removed, and eventually the -whole tree). selftest_data_remove() calls detach_node_and_children() that uses -of_detach_node() to detach the nodes from the live device tree. - -To detach a node, of_detach_node() either updates the child pointer of given -node's parent to its sibling or attaches the previous sibling to the given -node's sibling, as appropriate. That is it :) diff --git a/Documentation/devicetree/of_unittest.txt b/Documentation/devicetree/of_unittest.txt new file mode 100644 index 0000000..3e4e7d4 --- /dev/null +++ b/Documentation/devicetree/of_unittest.txt @@ -0,0 +1,197 @@ +Open Firmware Device Tree Unittest +---------------------------------- + +Author: Gaurav Minocha <gaurav.minocha.os@gmail.com> + +1. Introduction + +This document explains how the test data required for executing OF unittest +is attached to the live tree dynamically, independent of the machine's +architecture. + +It is recommended to read the following documents before moving ahead. + +[1] Documentation/devicetree/usage-model.txt +[2] http://www.devicetree.org/Device_Tree_Usage + +OF Selftest has been designed to test the interface (include/linux/of.h) +provided to device driver developers to fetch the device information..etc. +from the unflattened device tree data structure. This interface is used by +most of the device drivers in various use cases. + + +2. Test-data + +The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains +the test data required for executing the unit tests automated in +drivers/of/unittest.c. Currently, following Device Tree Source Include files +(.dtsi) are included in testcases.dts: + +drivers/of/unittest-data/tests-interrupts.dtsi +drivers/of/unittest-data/tests-platform.dtsi +drivers/of/unittest-data/tests-phandle.dtsi +drivers/of/unittest-data/tests-match.dtsi + +When the kernel is build with OF_SELFTEST enabled, then the following make rule + +$(obj)/%.dtb: $(src)/%.dts FORCE + $(call if_changed_dep, dtc) + +is used to compile the DT source file (testcases.dts) into a binary blob +(testcases.dtb), also referred as flattened DT. + +After that, using the following rule the binary blob above is wrapped as an +assembly file (testcases.dtb.S). + +$(obj)/%.dtb.S: $(obj)/%.dtb + $(call cmd, dt_S_dtb) + +The assembly file is compiled into an object file (testcases.dtb.o), and is +linked into the kernel image. + + +2.1. Adding the test data + +Un-flattened device tree structure: + +Un-flattened device tree consists of connected device_node(s) in form of a tree +structure described below. + +// following struct members are used to construct the tree +struct device_node { + ... + struct device_node *parent; + struct device_node *child; + struct device_node *sibling; + ... + }; + +Figure 1, describes a generic structure of machine's un-flattened device tree +considering only child and sibling pointers. There exists another pointer, +*parent, that is used to traverse the tree in the reverse direction. So, at +a particular level the child node and all the sibling nodes will have a parent +pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4's +parent points to root node) + +root ('/') + | +child1 -> sibling2 -> sibling3 -> sibling4 -> null + | | | | + | | | null + | | | + | | child31 -> sibling32 -> null + | | | | + | | null null + | | + | child21 -> sibling22 -> sibling23 -> null + | | | | + | null null null + | +child11 -> sibling12 -> sibling13 -> sibling14 -> null + | | | | + | | | null + | | | + null null child131 -> null + | + null + +Figure 1: Generic structure of un-flattened device tree + + +Before executing OF unittest, it is required to attach the test data to +machine's device tree (if present). So, when selftest_data_add() is called, +at first it reads the flattened device tree data linked into the kernel image +via the following kernel symbols: + +__dtb_testcases_begin - address marking the start of test data blob +__dtb_testcases_end - address marking the end of test data blob + +Secondly, it calls of_fdt_unflatten_tree() to unflatten the flattened +blob. And finally, if the machine's device tree (i.e live tree) is present, +then it attaches the unflattened test data tree to the live tree, else it +attaches itself as a live device tree. + +attach_node_and_children() uses of_attach_node() to attach the nodes into the +live tree as explained below. To explain the same, the test data tree described + in Figure 2 is attached to the live tree described in Figure 1. + +root ('/') + | + testcase-data + | + test-child0 -> test-sibling1 -> test-sibling2 -> test-sibling3 -> null + | | | | + test-child01 null null null + + +Figure 2: Example test data tree to be attached to live tree. + +According to the scenario above, the live tree is already present so it isn't +required to attach the root('/') node. All other nodes are attached by calling +of_attach_node() on each node. + +In the function of_attach_node(), the new node is attached as the child of the +given parent in live tree. But, if parent already has a child then the new node +replaces the current child and turns it into its sibling. So, when the testcase +data node is attached to the live tree above (Figure 1), the final structure is + as shown in Figure 3. + +root ('/') + | +testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null + | | | | | + (...) | | | null + | | child31 -> sibling32 -> null + | | | | + | | null null + | | + | child21 -> sibling22 -> sibling23 -> null + | | | | + | null null null + | + child11 -> sibling12 -> sibling13 -> sibling14 -> null + | | | | + null null | null + | + child131 -> null + | + null +----------------------------------------------------------------------- + +root ('/') + | +testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null + | | | | | + | (...) (...) (...) null + | +test-sibling3 -> test-sibling2 -> test-sibling1 -> test-child0 -> null + | | | | + null null null test-child01 + + +Figure 3: Live device tree structure after attaching the testcase-data. + + +Astute readers would have noticed that test-child0 node becomes the last +sibling compared to the earlier structure (Figure 2). After attaching first +test-child0 the test-sibling1 is attached that pushes the child node +(i.e. test-child0) to become a sibling and makes itself a child node, + as mentioned above. + +If a duplicate node is found (i.e. if a node with same full_name property is +already present in the live tree), then the node isn't attached rather its +properties are updated to the live tree's node by calling the function +update_node_properties(). + + +2.2. Removing the test data + +Once the test case execution is complete, selftest_data_remove is called in +order to remove the device nodes attached initially (first the leaf nodes are +detached and then moving up the parent nodes are removed, and eventually the +whole tree). selftest_data_remove() calls detach_node_and_children() that uses +of_detach_node() to detach the nodes from the live device tree. + +To detach a node, of_detach_node() either updates the child pointer of given +node's parent to its sibling or attaches the previous sibling to the given +node's sibling, as appropriate. That is it :) -- 1.8.3.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt 2015-03-09 2:35 ` Wang Long (?) (?) @ 2015-03-10 14:44 ` Rob Herring [not found] ` <CAL_JsqLgxCQW==4YQrX193g+x22d1iL2jBGY4CSMnq7cQcSgZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> -1 siblings, 1 reply; 11+ messages in thread From: Rob Herring @ 2015-03-10 14:44 UTC (permalink / raw) To: Wang Long Cc: Rob Herring, Gaurav Minocha, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, peifeiyue On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong@huawei.com> wrote: > Since the directory "drivers/of/testcase-data" is renamed > to "drivers/of/unittest-data". so we should update the path > in the of_selftest.txt. > > When the kernel is built with OF_SELFUNIT enabled, the output Still wrong... > dtb is testcases.dtb instead of testcase.dtb, also update it > (s/testcase/testcases/). > > Signed-off-by: Wang Long <long.wanglong@huawei.com> > --- > Documentation/devicetree/of_selftest.txt | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt > index 57a808b..3e4e7d4 100644 > --- a/Documentation/devicetree/of_selftest.txt > +++ b/Documentation/devicetree/of_selftest.txt > @@ -1,11 +1,11 @@ > -Open Firmware Device Tree Selftest > +Open Firmware Device Tree Unittest > ---------------------------------- > > Author: Gaurav Minocha <gaurav.minocha.os@gmail.com> > > 1. Introduction > > -This document explains how the test data required for executing OF selftest > +This document explains how the test data required for executing OF unittest > is attached to the live tree dynamically, independent of the machine's > architecture. > > @@ -22,31 +22,31 @@ most of the device drivers in various use cases. > > 2. Test-data > > -The Device Tree Source file (drivers/of/testcase-data/testcases.dts) contains > +The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains > the test data required for executing the unit tests automated in > -drivers/of/selftests.c. Currently, following Device Tree Source Include files > -(.dtsi) are included in testcase.dts: > +drivers/of/unittest.c. Currently, following Device Tree Source Include files > +(.dtsi) are included in testcases.dts: > > -drivers/of/testcase-data/tests-interrupts.dtsi > -drivers/of/testcase-data/tests-platform.dtsi > -drivers/of/testcase-data/tests-phandle.dtsi > -drivers/of/testcase-data/tests-match.dtsi > +drivers/of/unittest-data/tests-interrupts.dtsi > +drivers/of/unittest-data/tests-platform.dtsi > +drivers/of/unittest-data/tests-phandle.dtsi > +drivers/of/unittest-data/tests-match.dtsi > > When the kernel is build with OF_SELFTEST enabled, then the following make rule Missed this one... > > $(obj)/%.dtb: $(src)/%.dts FORCE > $(call if_changed_dep, dtc) > > -is used to compile the DT source file (testcase.dts) into a binary blob > -(testcase.dtb), also referred as flattened DT. > +is used to compile the DT source file (testcases.dts) into a binary blob > +(testcases.dtb), also referred as flattened DT. > > After that, using the following rule the binary blob above is wrapped as an > -assembly file (testcase.dtb.S). > +assembly file (testcases.dtb.S). > > $(obj)/%.dtb.S: $(obj)/%.dtb > $(call cmd, dt_S_dtb) > > -The assembly file is compiled into an object file (testcase.dtb.o), and is > +The assembly file is compiled into an object file (testcases.dtb.o), and is > linked into the kernel image. > > > @@ -98,7 +98,7 @@ child11 -> sibling12 -> sibling13 -> sibling14 -> null > Figure 1: Generic structure of un-flattened device tree > > > -Before executing OF selftest, it is required to attach the test data to > +Before executing OF unittest, it is required to attach the test data to > machine's device tree (if present). So, when selftest_data_add() is called, This one too. > at first it reads the flattened device tree data linked into the kernel image > via the following kernel symbols: > -- > 1.8.3.4 > ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CAL_JsqLgxCQW==4YQrX193g+x22d1iL2jBGY4CSMnq7cQcSgZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt 2015-03-10 14:44 ` [PATCH v2 1/2] Documentation: update the of_selftest.txt Rob Herring @ 2015-03-10 14:50 ` Rob Herring 0 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2015-03-10 14:50 UTC (permalink / raw) To: Wang Long, Grant Likely Cc: Rob Herring, Gaurav Minocha, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, peifeiyue-hv44wF8Li93QT0dZR+AlfA On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote: >> Since the directory "drivers/of/testcase-data" is renamed >> to "drivers/of/unittest-data". so we should update the path >> in the of_selftest.txt. [...] >> -Before executing OF selftest, it is required to attach the test data to >> +Before executing OF unittest, it is required to attach the test data to >> machine's device tree (if present). So, when selftest_data_add() is called, > > This one too. Or not. The functions are all still "selftest". Not sure why Grant left all those... Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt @ 2015-03-10 14:50 ` Rob Herring 0 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2015-03-10 14:50 UTC (permalink / raw) To: Wang Long, Grant Likely Cc: Rob Herring, Gaurav Minocha, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, peifeiyue On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring <robherring2@gmail.com> wrote: > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong@huawei.com> wrote: >> Since the directory "drivers/of/testcase-data" is renamed >> to "drivers/of/unittest-data". so we should update the path >> in the of_selftest.txt. [...] >> -Before executing OF selftest, it is required to attach the test data to >> +Before executing OF unittest, it is required to attach the test data to >> machine's device tree (if present). So, when selftest_data_add() is called, > > This one too. Or not. The functions are all still "selftest". Not sure why Grant left all those... Rob ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt 2015-03-10 14:50 ` Rob Herring (?) @ 2015-03-10 15:16 ` Gaurav Minocha 2015-03-11 3:07 ` long.wanglong -1 siblings, 1 reply; 11+ messages in thread From: Gaurav Minocha @ 2015-03-10 15:16 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, Rob Herring, devicetree@vger.kernel.org, Ian Campbell, Grant Likely, linux-kernel@vger.kernel.org, Pawel Moll, Kumar Gala, Wang Long, peifeiyue [-- Attachment #1: Type: text/plain, Size: 870 bytes --] Hi Rob, On Mar 10, 2015 7:51 AM, "Rob Herring" <robherring2@gmail.com> wrote: > > On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring <robherring2@gmail.com> wrote: > > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong@huawei.com> wrote: > >> Since the directory "drivers/of/testcase-data" is renamed > >> to "drivers/of/unittest-data". so we should update the path > >> in the of_selftest.txt. > > [...] > > >> -Before executing OF selftest, it is required to attach the test data to > >> +Before executing OF unittest, it is required to attach the test data to > >> machine's device tree (if present). So, when selftest_data_add() is called, > > > > This one too. > > Or not. The functions are all still "selftest". Not sure why Grant > left all those... I will send a patch to replace the selftest with unitest also will update the document if required.. > > Rob [-- Attachment #2: Type: text/html, Size: 1333 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt 2015-03-10 15:16 ` Gaurav Minocha @ 2015-03-11 3:07 ` long.wanglong 0 siblings, 0 replies; 11+ messages in thread From: long.wanglong @ 2015-03-11 3:07 UTC (permalink / raw) To: Gaurav Minocha Cc: Rob Herring, Mark Rutland, Rob Herring, devicetree@vger.kernel.org, Ian Campbell, Grant Likely, linux-kernel@vger.kernel.org, Pawel Moll, Kumar Gala, peifeiyue On 2015/3/10 23:16, Gaurav Minocha wrote: > Hi Rob, > > On Mar 10, 2015 7:51 AM, "Rob Herring" <robherring2@gmail.com <mailto:robherring2@gmail.com>> wrote: >> >> On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring <robherring2@gmail.com <mailto:robherring2@gmail.com>> wrote: >> > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong@huawei.com <mailto:long.wanglong@huawei.com>> wrote: >> >> Since the directory "drivers/of/testcase-data" is renamed >> >> to "drivers/of/unittest-data". so we should update the path >> >> in the of_selftest.txt. >> >> [...] >> >> >> -Before executing OF selftest, it is required to attach the test data to >> >> +Before executing OF unittest, it is required to attach the test data to >> >> machine's device tree (if present). So, when selftest_data_add() is called, >> > >> > This one too. >> >> Or not. The functions are all still "selftest". Not sure why Grant >> left all those... > > I will send a patch to replace the selftest with unitest also will update the document if required.. > Hi Gaurav, Rob I have done the work. before replacing the selftest with unittest, i will fix some error in OF unittest. Please review my patch, and give me some advices. Thanks. Best Regards Wang Long >> >> Rob > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt @ 2015-03-11 3:07 ` long.wanglong 0 siblings, 0 replies; 11+ messages in thread From: long.wanglong @ 2015-03-11 3:07 UTC (permalink / raw) To: Gaurav Minocha Cc: Rob Herring, Mark Rutland, Rob Herring, devicetree@vger.kernel.org, Ian Campbell, Grant Likely, linux-kernel@vger.kernel.org, Pawel Moll, Kumar Gala, peifeiyue On 2015/3/10 23:16, Gaurav Minocha wrote: > Hi Rob, > > On Mar 10, 2015 7:51 AM, "Rob Herring" <robherring2@gmail.com <mailto:robherring2@gmail.com>> wrote: >> >> On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring <robherring2@gmail.com <mailto:robherring2@gmail.com>> wrote: >> > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong@huawei.com <mailto:long.wanglong@huawei.com>> wrote: >> >> Since the directory "drivers/of/testcase-data" is renamed >> >> to "drivers/of/unittest-data". so we should update the path >> >> in the of_selftest.txt. >> >> [...] >> >> >> -Before executing OF selftest, it is required to attach the test data to >> >> +Before executing OF unittest, it is required to attach the test data to >> >> machine's device tree (if present). So, when selftest_data_add() is called, >> > >> > This one too. >> >> Or not. The functions are all still "selftest". Not sure why Grant >> left all those... > > I will send a patch to replace the selftest with unitest also will update the document if required.. > Hi Gaurav, Rob I have done the work. before replacing the selftest with unittest, i will fix some error in OF unittest. Please review my patch, and give me some advices. Thanks. Best Regards Wang Long >> >> Rob > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt 2015-03-10 14:50 ` Rob Herring (?) (?) @ 2015-03-28 1:37 ` Grant Likely -1 siblings, 0 replies; 11+ messages in thread From: Grant Likely @ 2015-03-28 1:37 UTC (permalink / raw) To: Rob Herring, Wang Long Cc: Rob Herring, Gaurav Minocha, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, peifeiyue On Tue, 10 Mar 2015 09:50:58 -0500 , Rob Herring <robherring2@gmail.com> wrote: > On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring <robherring2@gmail.com> wrote: > > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong@huawei.com> wrote: > >> Since the directory "drivers/of/testcase-data" is renamed > >> to "drivers/of/unittest-data". so we should update the path > >> in the of_selftest.txt. > > [...] > > >> -Before executing OF selftest, it is required to attach the test data to > >> +Before executing OF unittest, it is required to attach the test data to > >> machine's device tree (if present). So, when selftest_data_add() is called, > > > > This one too. > > Or not. The functions are all still "selftest". Not sure why Grant > left all those... Because it was churn, and there were patches in-flight that would be affected. They can be changed now. g. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-03-28 1:37 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 2:35 [PATCH v2 1/2] Documentation: update the of_selftest.txt Wang Long
2015-03-09 2:35 ` Wang Long
2015-03-09 2:35 ` [PATCH v2 2/2] Documentation: rename of_selftest.txt to of_unittest.txt Wang Long
2015-03-09 2:35 ` Wang Long
2015-03-10 14:44 ` [PATCH v2 1/2] Documentation: update the of_selftest.txt Rob Herring
[not found] ` <CAL_JsqLgxCQW==4YQrX193g+x22d1iL2jBGY4CSMnq7cQcSgZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 14:50 ` Rob Herring
2015-03-10 14:50 ` Rob Herring
2015-03-10 15:16 ` Gaurav Minocha
2015-03-11 3:07 ` long.wanglong
2015-03-11 3:07 ` long.wanglong
2015-03-28 1:37 ` Grant Likely
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.