From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: thierry.reding@gmail.com, jg1.han@samsung.com
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] backlight: pwm: handle EPROBE_DEFER while requesting the PWM
Date: Wed, 11 Mar 2015 13:48:34 +0100 [thread overview]
Message-ID: <550039A2.9010307@atmel.com> (raw)
In-Reply-To: <1424338214-24236-1-git-send-email-nicolas.ferre@atmel.com>
Le 19/02/2015 10:30, Nicolas Ferre a écrit :
> When trying to request the PWM device with devm_pwm_get(), the EPROBE_DEFER
> flag is not handled properly. It can lead to the PWM not being found.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Any comment on this patch?
Can we see it included during next cycle (4.1)?
(aka ping).
Bye,
> ---
> drivers/video/backlight/pwm_bl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 3a145a643e0d..6897f1c1bc73 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -274,6 +274,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>
> pb->pwm = devm_pwm_get(&pdev->dev, NULL);
> if (IS_ERR(pb->pwm)) {
> + ret = PTR_ERR(pb->pwm);
> + if (ret == -EPROBE_DEFER)
> + goto err_alloc;
> +
> dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
> pb->legacy = true;
> pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] backlight: pwm: handle EPROBE_DEFER while requesting the PWM
Date: Wed, 11 Mar 2015 13:48:34 +0100 [thread overview]
Message-ID: <550039A2.9010307@atmel.com> (raw)
In-Reply-To: <1424338214-24236-1-git-send-email-nicolas.ferre@atmel.com>
Le 19/02/2015 10:30, Nicolas Ferre a ?crit :
> When trying to request the PWM device with devm_pwm_get(), the EPROBE_DEFER
> flag is not handled properly. It can lead to the PWM not being found.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Any comment on this patch?
Can we see it included during next cycle (4.1)?
(aka ping).
Bye,
> ---
> drivers/video/backlight/pwm_bl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 3a145a643e0d..6897f1c1bc73 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -274,6 +274,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>
> pb->pwm = devm_pwm_get(&pdev->dev, NULL);
> if (IS_ERR(pb->pwm)) {
> + ret = PTR_ERR(pb->pwm);
> + if (ret == -EPROBE_DEFER)
> + goto err_alloc;
> +
> dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
> pb->legacy = true;
> pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: <thierry.reding@gmail.com>, <jg1.han@samsung.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-pwm@vger.kernel.org>, <lee.jones@linaro.org>,
<linux-kernel@vger.kernel.org>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] backlight: pwm: handle EPROBE_DEFER while requesting the PWM
Date: Wed, 11 Mar 2015 13:48:34 +0100 [thread overview]
Message-ID: <550039A2.9010307@atmel.com> (raw)
In-Reply-To: <1424338214-24236-1-git-send-email-nicolas.ferre@atmel.com>
Le 19/02/2015 10:30, Nicolas Ferre a écrit :
> When trying to request the PWM device with devm_pwm_get(), the EPROBE_DEFER
> flag is not handled properly. It can lead to the PWM not being found.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Any comment on this patch?
Can we see it included during next cycle (4.1)?
(aka ping).
Bye,
> ---
> drivers/video/backlight/pwm_bl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 3a145a643e0d..6897f1c1bc73 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -274,6 +274,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>
> pb->pwm = devm_pwm_get(&pdev->dev, NULL);
> if (IS_ERR(pb->pwm)) {
> + ret = PTR_ERR(pb->pwm);
> + if (ret == -EPROBE_DEFER)
> + goto err_alloc;
> +
> dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
> pb->legacy = true;
> pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-03-11 12:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 9:30 [PATCH] backlight: pwm: handle EPROBE_DEFER while requesting the PWM Nicolas Ferre
2015-02-19 9:30 ` Nicolas Ferre
2015-02-19 9:30 ` Nicolas Ferre
2015-03-11 12:48 ` Nicolas Ferre [this message]
2015-03-11 12:48 ` Nicolas Ferre
2015-03-11 12:48 ` Nicolas Ferre
2015-03-12 6:59 ` Lee Jones
2015-03-12 6:59 ` Lee Jones
2015-03-12 7:49 ` Thierry Reding
2015-03-12 7:49 ` Thierry Reding
2015-03-12 9:02 ` Lee Jones
2015-03-12 9:02 ` Lee Jones
2015-05-25 9:27 ` Boris Brezillon
2015-05-25 9:27 ` Boris Brezillon
2015-05-26 7:36 ` [NEXT REQUEST][PATCH] " Lee Jones
2015-05-26 7:36 ` Lee Jones
2015-05-26 21:20 ` Stephen Rothwell
2015-05-26 21:20 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550039A2.9010307@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.