From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Fam Zheng <famz@redhat.com>,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] virtio-scsi: clean out duplicate cdb field
Date: Wed, 11 Mar 2015 15:03:10 +0100 [thread overview]
Message-ID: <55004B1E.2010702@redhat.com> (raw)
In-Reply-To: <20150311144311-mutt-send-email-mst@redhat.com>
On 11/03/2015 14:43, Michael S. Tsirkin wrote:
> struct {
> VirtIOSCSICmdReq cmd;
> - uint8_t cdb[];
> } QEMU_PACKED;
Just:
VirtIOSCSICmdReq cmd;
without the wrapping struct.
With this change series
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> VirtIOSCSICtrlTMFReq tmf;
> VirtIOSCSICtrlANReq an;
> } req;
> } VirtIOSCSIReq;
>
> -QEMU_BUILD_BUG_ON(offsetof(VirtIOSCSIReq, req.cdb) !=
> - offsetof(VirtIOSCSIReq, req.cmd) + sizeof(VirtIOSCSICmdReq));
> -
prev parent reply other threads:[~2015-03-11 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426081233-7801-1-git-send-email-mst@redhat.com>
2015-03-11 13:43 ` [Qemu-devel] [PATCH 1/4] virtio-scsi: drop duplicate CDB/SENSE SIZE Michael S. Tsirkin
2015-03-11 13:43 ` [Qemu-devel] [PATCH 2/4] uapi/virtio_scsi: allow overriding CDB/SENSE size Michael S. Tsirkin
2015-03-11 13:43 ` [Qemu-devel] [PATCH 3/4] virtio-scsi: fix cdb/sense size Michael S. Tsirkin
2015-03-11 13:43 ` [Qemu-devel] [PATCH 4/4] virtio-scsi: clean out duplicate cdb field Michael S. Tsirkin
2015-03-11 14:03 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55004B1E.2010702@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.