All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91/dt: fix USB high-speed clock to select UTMI
Date: Wed, 11 Mar 2015 17:53:30 +0100	[thread overview]
Message-ID: <5500730A.4040100@atmel.com> (raw)
In-Reply-To: <1425916273-393-1-git-send-email-nicolas.ferre@atmel.com>

Le 09/03/2015 16:51, Nicolas Ferre a ?crit :
> The UTMI clock must be selected by any high-speed USB IP. The logic behind it
> needs this particular clock.
> So, correct the clock in the device tree files affected.
> 
> Reported-by: Bo Shen <voice.shen@atmel.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

In at91-4.0-fixes now.

> ---
>  arch/arm/boot/dts/at91sam9g45.dtsi | 2 +-
>  arch/arm/boot/dts/at91sam9x5.dtsi  | 4 ++--
>  arch/arm/boot/dts/sama5d3.dtsi     | 2 +-
>  arch/arm/boot/dts/sama5d4.dtsi     | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> index 56fa94bf6776..72be4be57767 100644
> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> @@ -1325,7 +1325,7 @@
>  			reg = <0x00800000 0x100000>;
>  			interrupts = <22 IRQ_TYPE_LEVEL_HIGH 2>;
>  			//TODO
> -			clocks = <&usb>, <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "hclk", "uhpck";
>  			status = "disabled";
>  		};
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index a2ad79b0878c..76043e95b958 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -1062,7 +1062,7 @@
>  				reg = <0x00500000 0x80000
>  				       0xf803c000 0x400>;
>  				interrupts = <23 IRQ_TYPE_LEVEL_HIGH 0>;
> -				clocks = <&usb>, <&udphs_clk>;
> +				clocks = <&utmi>, <&udphs_clk>;
>  				clock-names = "hclk", "pclk";
>  				status = "disabled";
>  
> @@ -1182,7 +1182,7 @@
>  			compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  			reg = <0x00700000 0x100000>;
>  			interrupts = <22 IRQ_TYPE_LEVEL_HIGH 2>;
> -			clocks = <&usb>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "uhpck";
>  			status = "disabled";
>  		};
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index 7ec28dab308a..29c08215d93a 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1426,7 +1426,7 @@
>  			compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  			reg = <0x00700000 0x100000>;
>  			interrupts = <32 IRQ_TYPE_LEVEL_HIGH 2>;
> -			clocks = <&usb>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "uhpck";
>  			status = "disabled";
>  		};
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index d050decd3ca0..3b23b88ca6a2 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -266,7 +266,7 @@
>  			compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  			reg = <0x00600000 0x100000>;
>  			interrupts = <46 IRQ_TYPE_LEVEL_HIGH 2>;
> -			clocks = <&usb>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "uhpck";
>  			status = "disabled";
>  		};
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Bo Shen <voice.shen@atmel.com>, Josh Wu <josh.wu@atmel.com>,
	Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [PATCH] ARM: at91/dt: fix USB high-speed clock to select UTMI
Date: Wed, 11 Mar 2015 17:53:30 +0100	[thread overview]
Message-ID: <5500730A.4040100@atmel.com> (raw)
In-Reply-To: <1425916273-393-1-git-send-email-nicolas.ferre@atmel.com>

Le 09/03/2015 16:51, Nicolas Ferre a écrit :
> The UTMI clock must be selected by any high-speed USB IP. The logic behind it
> needs this particular clock.
> So, correct the clock in the device tree files affected.
> 
> Reported-by: Bo Shen <voice.shen@atmel.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

In at91-4.0-fixes now.

> ---
>  arch/arm/boot/dts/at91sam9g45.dtsi | 2 +-
>  arch/arm/boot/dts/at91sam9x5.dtsi  | 4 ++--
>  arch/arm/boot/dts/sama5d3.dtsi     | 2 +-
>  arch/arm/boot/dts/sama5d4.dtsi     | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> index 56fa94bf6776..72be4be57767 100644
> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> @@ -1325,7 +1325,7 @@
>  			reg = <0x00800000 0x100000>;
>  			interrupts = <22 IRQ_TYPE_LEVEL_HIGH 2>;
>  			//TODO
> -			clocks = <&usb>, <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "hclk", "uhpck";
>  			status = "disabled";
>  		};
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index a2ad79b0878c..76043e95b958 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -1062,7 +1062,7 @@
>  				reg = <0x00500000 0x80000
>  				       0xf803c000 0x400>;
>  				interrupts = <23 IRQ_TYPE_LEVEL_HIGH 0>;
> -				clocks = <&usb>, <&udphs_clk>;
> +				clocks = <&utmi>, <&udphs_clk>;
>  				clock-names = "hclk", "pclk";
>  				status = "disabled";
>  
> @@ -1182,7 +1182,7 @@
>  			compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  			reg = <0x00700000 0x100000>;
>  			interrupts = <22 IRQ_TYPE_LEVEL_HIGH 2>;
> -			clocks = <&usb>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "uhpck";
>  			status = "disabled";
>  		};
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index 7ec28dab308a..29c08215d93a 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1426,7 +1426,7 @@
>  			compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  			reg = <0x00700000 0x100000>;
>  			interrupts = <32 IRQ_TYPE_LEVEL_HIGH 2>;
> -			clocks = <&usb>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "uhpck";
>  			status = "disabled";
>  		};
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index d050decd3ca0..3b23b88ca6a2 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -266,7 +266,7 @@
>  			compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  			reg = <0x00600000 0x100000>;
>  			interrupts = <46 IRQ_TYPE_LEVEL_HIGH 2>;
> -			clocks = <&usb>, <&uhphs_clk>, <&uhpck>;
> +			clocks = <&utmi>, <&uhphs_clk>, <&uhpck>;
>  			clock-names = "usb_clk", "ehci_clk", "uhpck";
>  			status = "disabled";
>  		};
> 


-- 
Nicolas Ferre

  reply	other threads:[~2015-03-11 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 15:51 [PATCH] ARM: at91/dt: fix USB high-speed clock to select UTMI Nicolas Ferre
2015-03-09 15:51 ` Nicolas Ferre
2015-03-11 16:53 ` Nicolas Ferre [this message]
2015-03-11 16:53   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5500730A.4040100@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.