Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

[Michael Tokarev <mjt@tls.msk.ru>]

11.03.2015 11:46, Aneesh Kumar K.V wrote:
[]
> ... Rather than saying
> 
>    "Oh well.  I've no idea how this code has been accepted.
>    It is absolute crap."
> 
> it would be nice if we take up specific issues, w.r.t the os/cpu
> combination where we are running into issues, we may be able to fix this
> easily.

The specific issues were outlined and partially fixed by the v3
patchset.  This is, for example, the way v9fs_request() is called
with arguments for v9fs_marshal function, which are ignored and
new arguments are constructed inside _request.  That's what I
refer to when saying it is a complete crap.  Do you not agree? :)

[]
> Note: At this point i haven't picked any of the patches posted, so if
> you have anything specific you want me to take up, please repost then
> with correct version number (v1, v2...)

I sent a v3 (last) with correct version number, it has just 3 (rather
big) patches: http://thread.gmane.org/gmane.comp.emulators.qemu/324157 .

Thanks,

/mjt