All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	akash.goel@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 07/11] drm/i915/skl: Updated the gen9_enable_rps function
Date: Wed, 11 Mar 2015 13:08:50 -0700	[thread overview]
Message-ID: <5500A0D2.7070403@virtuousgeek.org> (raw)
In-Reply-To: <20150311194621.GA28857@nuc-i3427.alporthouse.com>

On 03/11/2015 12:46 PM, Chris Wilson wrote:
> On Wed, Mar 11, 2015 at 12:27:59PM -0700, Jesse Barnes wrote:
>> On 03/05/2015 09:37 PM, akash.goel@intel.com wrote:
>>> +	/* Leaning on the below call to gen6_set_rps to program/setup the
>>> +	 * Up/Down EI & threshold registers, as well as the RP_CONTROL,
>>> +	 * RP_INTERRUPT_LIMITS & RPNSWREQ registers */
>>> +	dev_priv->rps.power = HIGH_POWER; /* force a reset */
>>
>> Are you also sure that dev_priv->rps.cur_freq != min_freq_softlimit at
>> this point?  That's the condition for calling into the threshold update
>> function (maybe gen6_set_rps should check both variables though).
> 
> It's a good point, but Akash has inherited that bug from me. What I
> think we want is removing the actual intel_set_rps() calls here (and the
> rest of the *_enable_rps()) and do an intel_set_rps_idle() call from the
> common point in the caller, where we can put all the dancing required to
> force the RPS initialisation.

Yeah, that would make things a little clearer.  I'd be fine with that as
a patch on top, fixing up the other functions as well.

Jesse

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-03-11 20:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  5:37 [PATCH v4 00/11] Added missing changes for Turbo feature on SKL akash.goel
2015-03-06  5:37 ` [PATCH 01/11] drm/i915/skl: Added new macros akash.goel
2015-03-11 19:12   ` Ville Syrjälä
2015-03-06  5:37 ` [PATCH 02/11] drm/i915/skl: Updated intel_gpu_freq() and intel_freq_opcode() akash.goel
2015-03-06  5:37 ` [PATCH 03/11] drm/i915/skl: Updated the gen6_init_rps_frequencies function akash.goel
2015-03-11 19:12   ` Ville Syrjälä
2015-03-06  5:37 ` [PATCH 04/11] drm/i915/skl: Updated the gen6_set_rps function akash.goel
2015-03-06  5:37 ` [PATCH 05/11] drm/i915/skl: Restructured the gen6_set_rps_thresholds function akash.goel
2015-03-06  5:37 ` [PATCH 06/11] drm/i915/skl: Updated the gen6_rps_limits function akash.goel
2015-03-06  5:37 ` [PATCH 07/11] drm/i915/skl: Updated the gen9_enable_rps function akash.goel
2015-03-11 19:27   ` Jesse Barnes
2015-03-11 19:46     ` Chris Wilson
2015-03-11 20:08       ` Jesse Barnes [this message]
2015-03-11 20:39     ` Daniel Vetter
2015-03-06  5:37 ` [PATCH 08/11] drm/i915/skl: Updated the i915_frequency_info debugfs function akash.goel
2015-03-11 20:48   ` Ville Syrjälä
2015-03-06  5:37 ` [PATCH 09/11] drm/i915/skl: Updated the act_freq_mhz_show sysfs function akash.goel
2015-03-06  5:37 ` [PATCH 10/11] drm/i915/skl: Enabling processing of Turbo interrupts akash.goel
2015-03-11 19:23   ` Jesse Barnes
2015-03-06  5:37 ` [PATCH 11/11] drm/i915/skl: Enable the RPS interrupts programming akash.goel
2015-03-06 19:44   ` shuang.he
2015-03-11 21:12   ` Jesse Barnes
2015-03-12  9:14     ` Daniel Vetter
2015-03-12 22:08 ` [PATCH v4 00/11] Added missing changes for Turbo feature on SKL Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5500A0D2.7070403@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=akash.goel@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.