From: Michael Tokarev <mjt@tls.msk.ru>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv
Date: Thu, 12 Mar 2015 09:30:42 +0300 [thread overview]
Message-ID: <55013292.9030306@msgid.tls.msk.ru> (raw)
In-Reply-To: <87mw3krckd.fsf@linux.vnet.ibm.com>
10.03.2015 20:23, Aneesh Kumar K.V wrote:
[]>
> I am not sure this is needed, whether to use int err or int ret as the
> variable name is simply a matter of preference for the author.
We have 2 filesystem methods in here, read and write, one near another,
which are written by the same author (but one of them has been later
extended a bit, adding another variable). This patch makes them similar
again.
> Also did
> you compile test the above ? (note: int ret followed by a check with
> variable name 'err').
Well yes. It is a forgotten git commit. Ofcourse I verified the result,
I just forgot to commit because I was distracted by something else, hence
sent a wrong patch. I'll resend it.
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv
Date: Thu, 12 Mar 2015 09:30:42 +0300 [thread overview]
Message-ID: <55013292.9030306@msgid.tls.msk.ru> (raw)
In-Reply-To: <87mw3krckd.fsf@linux.vnet.ibm.com>
10.03.2015 20:23, Aneesh Kumar K.V wrote:
[]>
> I am not sure this is needed, whether to use int err or int ret as the
> variable name is simply a matter of preference for the author.
We have 2 filesystem methods in here, read and write, one near another,
which are written by the same author (but one of them has been later
extended a bit, adding another variable). This patch makes them similar
again.
> Also did
> you compile test the above ? (note: int ret followed by a check with
> variable name 'err').
Well yes. It is a forgotten git commit. Ofcourse I verified the result,
I just forgot to commit because I was distracted by something else, hence
sent a wrong patch. I'll resend it.
/mjt
next prev parent reply other threads:[~2015-03-12 6:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 5:54 [Qemu-trivial] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv Michael Tokarev
2015-03-10 5:54 ` [Qemu-devel] " Michael Tokarev
2015-03-10 7:15 ` [Qemu-trivial] " Gonglei
2015-03-10 7:15 ` Gonglei
2015-03-10 7:20 ` [Qemu-trivial] " Michael Tokarev
2015-03-10 7:20 ` Michael Tokarev
2015-03-10 7:27 ` [Qemu-trivial] " Gonglei
2015-03-10 7:27 ` Gonglei
2015-03-10 17:23 ` [Qemu-trivial] " Aneesh Kumar K.V
2015-03-10 17:23 ` [Qemu-devel] " Aneesh Kumar K.V
2015-03-12 6:30 ` Michael Tokarev [this message]
2015-03-12 6:30 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55013292.9030306@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.