All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/radeon: Changing number of compute pipe lines
@ 2015-03-12  8:48 Oded Gabbay
  2015-03-12  9:04 ` Michel Dänzer
  0 siblings, 1 reply; 3+ messages in thread
From: Oded Gabbay @ 2015-03-12  8:48 UTC (permalink / raw)
  To: dri-devel

From: Ben Goz <ben.goz@amd.com>

The current CP firmware can handle Usermode Queues only on MEC1.
To reflect this firmware change, this commit reduces number of compute pipelines
to 4 - 1, from 8 - 1 (the first pipeline is allocated for kgd).

Signed-off-by: Ben Goz <ben.goz@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
---
 drivers/gpu/drm/radeon/radeon_kfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
index 061eaa9..122eb56 100644
--- a/drivers/gpu/drm/radeon/radeon_kfd.c
+++ b/drivers/gpu/drm/radeon/radeon_kfd.c
@@ -153,7 +153,7 @@ void radeon_kfd_device_init(struct radeon_device *rdev)
 			.compute_vmid_bitmap = 0xFF00,
 
 			.first_compute_pipe = 1,
-			.compute_pipe_count = 8 - 1,
+			.compute_pipe_count = 4 - 1,
 		};
 
 		radeon_doorbell_get_kfd_info(rdev,
-- 
2.1.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/radeon: Changing number of compute pipe lines
  2015-03-12  8:48 [PATCH] drm/radeon: Changing number of compute pipe lines Oded Gabbay
@ 2015-03-12  9:04 ` Michel Dänzer
  2015-03-12  9:08   ` Oded Gabbay
  0 siblings, 1 reply; 3+ messages in thread
From: Michel Dänzer @ 2015-03-12  9:04 UTC (permalink / raw)
  To: Oded Gabbay; +Cc: dri-devel

On 12.03.2015 17:48, Oded Gabbay wrote:
> From: Ben Goz <ben.goz@amd.com>
> 
> The current CP firmware can handle Usermode Queues only on MEC1.
> To reflect this firmware change, this commit reduces number of compute pipelines
> to 4 - 1, from 8 - 1 (the first pipeline is allocated for kgd).
> 
> Signed-off-by: Ben Goz <ben.goz@amd.com>
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_kfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
> index 061eaa9..122eb56 100644
> --- a/drivers/gpu/drm/radeon/radeon_kfd.c
> +++ b/drivers/gpu/drm/radeon/radeon_kfd.c
> @@ -153,7 +153,7 @@ void radeon_kfd_device_init(struct radeon_device *rdev)
>  			.compute_vmid_bitmap = 0xFF00,
>  
>  			.first_compute_pipe = 1,
> -			.compute_pipe_count = 8 - 1,
> +			.compute_pipe_count = 4 - 1,
>  		};
>  
>  		radeon_doorbell_get_kfd_info(rdev,
> 

Does this need to be backported to 3.19? (Does the current CP microcode
work with 3.19?)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/radeon: Changing number of compute pipe lines
  2015-03-12  9:04 ` Michel Dänzer
@ 2015-03-12  9:08   ` Oded Gabbay
  0 siblings, 0 replies; 3+ messages in thread
From: Oded Gabbay @ 2015-03-12  9:08 UTC (permalink / raw)
  To: Michel Dänzer; +Cc: dri-devel



On 03/12/2015 11:04 AM, Michel Dänzer wrote:
> On 12.03.2015 17:48, Oded Gabbay wrote:
>> From: Ben Goz <ben.goz@amd.com>
>>
>> The current CP firmware can handle Usermode Queues only on MEC1.
>> To reflect this firmware change, this commit reduces number of compute pipelines
>> to 4 - 1, from 8 - 1 (the first pipeline is allocated for kgd).
>>
>> Signed-off-by: Ben Goz <ben.goz@amd.com>
>> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
>> ---
>>  drivers/gpu/drm/radeon/radeon_kfd.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
>> index 061eaa9..122eb56 100644
>> --- a/drivers/gpu/drm/radeon/radeon_kfd.c
>> +++ b/drivers/gpu/drm/radeon/radeon_kfd.c
>> @@ -153,7 +153,7 @@ void radeon_kfd_device_init(struct radeon_device *rdev)
>>  			.compute_vmid_bitmap = 0xFF00,
>>  
>>  			.first_compute_pipe = 1,
>> -			.compute_pipe_count = 8 - 1,
>> +			.compute_pipe_count = 4 - 1,
>>  		};
>>  
>>  		radeon_doorbell_get_kfd_info(rdev,
>>
> 
> Does this need to be backported to 3.19? (Does the current CP microcode
> work with 3.19?)
> 
> 
Yes, I remembered that the moment after I sent the email :)
So I added the Cc stable to the patch in my repo.
Thanks for the reminder.

	Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-12  9:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12  8:48 [PATCH] drm/radeon: Changing number of compute pipe lines Oded Gabbay
2015-03-12  9:04 ` Michel Dänzer
2015-03-12  9:08   ` Oded Gabbay

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.